Added the TID252 Ruff rule

Makes it less of a hassle to remember when to do relative and when to do
absolute imports, and makes it somewhat easier to read the code through
e.g. GitHub.

Author: ddabble

CONTRIBUTING.md

@@ -22,7 +22,6 @@
   + [For code in general](#for-code-in-general)
     - [Quotation marks inside strings](#quotation-marks-inside-strings)
     - [String concatenation](#string-concatenation)
-    - [Imports](#imports)
   + [For each module (file)](#for-each-module-file)
     - [Folder/directory location](#folderdirectory-location)
     - [Filename](#filename)
@@ -158,11 +157,6 @@ if an f-string is hard to read, extract inserted code to variables, and insert t
 For translation strings (using `gettext` or `gettext_lazy`), use the standard `format()` method for concatenation.
 For example:<br/>`_("{chant} Batman!").format(chant="NaN" * 15)` (where `gettext_lazy` is imported as `_`).
 
-#### Imports
-
-All imports in a file that are from the same app as the mentioned file, should be relative
-(e.g. `from .models import User` or `from .. import views`).
-
 
 ### For each module (file)
 

pyproject.toml

@@ -68,14 +68,17 @@ show-fixes = true
 format.docstring-code-format = true
 
 lint.select = [
-  "E", # flake8/pycodestyle (Error)
-  "F", # flake8/Pyflakes
-  "I", # isort
+  "E",      # flake8/pycodestyle (Error)
+  "F",      # flake8/Pyflakes
+  "I",      # isort
+  "TID252", # https://docs.astral.sh/ruff/rules/relative-imports/#relative-imports-tid252
 ]
 
 # Disable line length check in migrations
 lint.per-file-ignores."**/migrations/**" = [ "E501" ]
 
+lint.flake8-tidy-imports.ban-relative-imports = "all"
+
 lint.isort.combine-as-imports = true
 
 # Ignore E501 for comments starting with TODO, FIXME, etc.

src/announcements/admin.py

@@ -2,14 +2,13 @@
 from django.template.defaultfilters import urlize
 from django.utils.translation import gettext_lazy as _
 
+from announcements.models import Announcement
 from util.admin_utils import (
     DefaultAdminWidgetsMixin,
     list_filter_factory,
     search_escaped_and_unescaped,
 )
 
-from .models import Announcement
-
 
 class AnnouncementAdmin(DefaultAdminWidgetsMixin, admin.ModelAdmin):
     list_display = (

src/announcements/forms.py

@@ -1,9 +1,8 @@
 from django.forms import ModelForm
 
+from announcements.models import Announcement
 from web.widgets import SemanticChoiceInput, SemanticDateTimeInput
 
-from .models import Announcement
-
 
 class AnnouncementForm(ModelForm):
     class Meta:

src/announcements/templatetags/announcement_tags.py

@@ -1,6 +1,6 @@
 from django import template
 
-from ..models import Announcement
+from announcements.models import Announcement
 
 register = template.Library()
 

src/announcements/tests/test_urls.py

@@ -2,14 +2,13 @@
 from django.utils import timezone
 from django_hosts import reverse
 
+from announcements.models import Announcement
 from util.test_utils import (
     Get,
     assert_requesting_paths_succeeds,
     generate_all_admin_urls_for_model_and_objs,
 )
 
-from ..models import Announcement
-
 
 class UrlTests(TestCase):
     def setUp(self):

src/announcements/urls.py

@@ -1,6 +1,6 @@
 from django.urls import include, path
 
-from . import views
+from announcements import views
 
 urlpatterns = []
 

src/announcements/views.py

@@ -5,11 +5,10 @@
 from django.utils.translation import gettext_lazy as _
 from django.views.generic import CreateView, DeleteView, ListView, UpdateView
 
+from announcements.forms import AnnouncementForm
+from announcements.models import Announcement
 from util.view_utils import CustomFieldsetFormMixin, PreventGetRequestsMixin
 
-from .forms import AnnouncementForm
-from .models import Announcement
-
 
 class AdminAnnouncementListView(PermissionRequiredMixin, ListView):
     permission_required = ("announcements.change_announcement",)

src/card/formfields.py

@@ -2,8 +2,8 @@
 from django.utils.text import capfirst
 from django.utils.translation import gettext_lazy as _
 
-from .validators import card_number_input_validator
-from .widgets import CardNumberInput
+from card.validators import card_number_input_validator
+from card.widgets import CardNumberInput
 
 
 class CardNumberField(forms.CharField):

src/card/modelfields.py

@@ -1,7 +1,7 @@
 from django.db import models
 from django.utils.translation import gettext_lazy as _
 
-from .validators import card_number_validator
+from card.validators import card_number_validator
 
 
 class CardNumberField(models.CharField):
@@ -25,7 +25,7 @@ def __init__(self, **kwargs):
         )
 
     def formfield(self, **kwargs):
-        from . import formfields  # Avoids circular importing
+        from card import formfields  # Avoids circular importing
 
         return super().formfield(
             **{