PALETTE COLOR does not update graphics screen palette

[sir-lazarus]

Test Environment (required)
You can use MEGAINFO from within FREEZER to obtain this information
(long press RESTORE to enter FREEZER, then press HELP to start MEGAINFO)

• Platform: MEGA65 (tested with R3)
• ROM Release: (920413) and tested also with 920416
• Core Commit: aaf4542

Describe the bug
When save the current graphic screen to a IFF-file with the BASIC command SAVEIFF, the used color palette is not stored within the file.

To Reproduce
Steps to reproduce the behavior:

1. open graphic screen
2. change colors of the current palette
3. draw something on the screen with different colors
4. save the screen with SAVEIFF to disk
5. reset the computer
6. open graphic screen
7. load saved graphic from file

Expected behavior
Loaded graphic should have had the same colors as the one which has been saved.

Screenshots
Us the attached test program

Additional context
Enclosed is a test program which changes the colors of the color palette in BASIC, generates a graphic, saves it to disk with SAVEIFF. The color palette is then reset to the standard and the saved image is loaded again. Then you can see that the colors are not the ones that were used when saving. At the end of the program, the color palette is again set as it should be in the image file. Key presses steps though the stages.

[sir-lazarus]

Test program: IFFTEST.D81.zip

[dansanderson]

The test program is using PALETTE COLOR to update the palette, which updates the system palette but not the screen palette. If you opened two screens and tried switching between them, you would notice that they restore their own palettes and not the system palette. The command set intends for you to use PALETTE 0, ... in this case, which would work.

This is not at all intuitive. One possible change would be to redefine PALETTE COLOR to update the palette data of whatever screen is visible. This might take away some capabilities, e.g. the ability to update the display without changing the screen's stored palette, but it seems unlikely that anyone is relying on this.