Rails 7.2 and Ruby 3.4 #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

JPrevost merged 9 commits into main from pw-173-rails72

Oct 7, 2025

.ruby-version

Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		3.2.9
		3.4.6

Dockerfile

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -1,4 +1,4 @@
  
    FROM ruby:3.2.9@sha256:7cfeeb9cdc8826b394f76784c8e227f46e4374269830f7171998e0252b78230a

    FROM ruby:3.4.6@sha256:df2711f5259070c14de6c5433f4b357c20728b66135c9494c081c53a96160251

    RUN mkdir /bento

    WORKDIR /bento

    COPY Gemfile /bento/Gemfile

Gemfile

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -1,5 +1,5 @@
  
    source 'https://rubygems.org'

    ruby '3.2.9'

    ruby '3.4.6'

    gem 'actionpack-action_caching', github: 'rails/actionpack-action_caching', branch: 'master'

    gem 'barnes'

    @@ -18,7 +18,7 @@ gem 'net-smtp', require: false
  
    gem 'nokogiri'

    gem 'puma'

    gem 'rack-attack'

    gem 'rails', '~> 7.1.0'

    gem 'rails', '~> 7.2.0'

    gem 'sass-rails'

    gem 'sentry-rails'

    gem 'sentry-ruby'

Gemfile.lock

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -18,83 +18,77 @@ GIT
  
    GEM

      remote: https://rubygems.org/

      specs:

        actioncable (7.1.5.2)

          actionpack (= 7.1.5.2)

          activesupport (= 7.1.5.2)

        actioncable (7.2.2.2)

          actionpack (= 7.2.2.2)

          activesupport (= 7.2.2.2)

          nio4r (~> 2.0)

          websocket-driver (>= 0.6.1)

          zeitwerk (~> 2.6)

        actionmailbox (7.1.5.2)

          actionpack (= 7.1.5.2)

          activejob (= 7.1.5.2)

          activerecord (= 7.1.5.2)

          activestorage (= 7.1.5.2)

          activesupport (= 7.1.5.2)

          mail (>= 2.7.1)

          net-imap

          net-pop

          net-smtp

        actionmailer (7.1.5.2)

          actionpack (= 7.1.5.2)

          actionview (= 7.1.5.2)

          activejob (= 7.1.5.2)

          activesupport (= 7.1.5.2)

          mail (~> 2.5, >= 2.5.4)

          net-imap

          net-pop

          net-smtp

        actionmailbox (7.2.2.2)

          actionpack (= 7.2.2.2)

          activejob (= 7.2.2.2)

          activerecord (= 7.2.2.2)

          activestorage (= 7.2.2.2)

          activesupport (= 7.2.2.2)

          mail (>= 2.8.0)

        actionmailer (7.2.2.2)

          actionpack (= 7.2.2.2)

          actionview (= 7.2.2.2)

          activejob (= 7.2.2.2)

          activesupport (= 7.2.2.2)

          mail (>= 2.8.0)

          rails-dom-testing (~> 2.2)

        actionpack (7.1.5.2)

          actionview (= 7.1.5.2)

          activesupport (= 7.1.5.2)

        actionpack (7.2.2.2)

          actionview (= 7.2.2.2)

          activesupport (= 7.2.2.2)

          nokogiri (>= 1.8.5)

          racc

          rack (>= 2.2.4)

          rack (>= 2.2.4, < 3.2)

          rack-session (>= 1.0.1)

          rack-test (>= 0.6.3)

          rails-dom-testing (~> 2.2)

          rails-html-sanitizer (~> 1.6)

        actiontext (7.1.5.2)

          actionpack (= 7.1.5.2)

          activerecord (= 7.1.5.2)

          activestorage (= 7.1.5.2)

          activesupport (= 7.1.5.2)

          useragent (~> 0.16)

        actiontext (7.2.2.2)

          actionpack (= 7.2.2.2)

          activerecord (= 7.2.2.2)

          activestorage (= 7.2.2.2)

          activesupport (= 7.2.2.2)

          globalid (>= 0.6.0)

          nokogiri (>= 1.8.5)

        actionview (7.1.5.2)

          activesupport (= 7.1.5.2)

        actionview (7.2.2.2)

          activesupport (= 7.2.2.2)

          builder (~> 3.1)

          erubi (~> 1.11)

          rails-dom-testing (~> 2.2)

          rails-html-sanitizer (~> 1.6)

        activejob (7.1.5.2)

          activesupport (= 7.1.5.2)

        activejob (7.2.2.2)

          activesupport (= 7.2.2.2)

          globalid (>= 0.3.6)

        activemodel (7.1.5.2)

          activesupport (= 7.1.5.2)

        activerecord (7.1.5.2)

          activemodel (= 7.1.5.2)

          activesupport (= 7.1.5.2)

        activemodel (7.2.2.2)

          activesupport (= 7.2.2.2)

        activerecord (7.2.2.2)

          activemodel (= 7.2.2.2)

          activesupport (= 7.2.2.2)

          timeout (>= 0.4.0)

        activestorage (7.1.5.2)

          actionpack (= 7.1.5.2)

          activejob (= 7.1.5.2)

          activerecord (= 7.1.5.2)

          activesupport (= 7.1.5.2)

        activestorage (7.2.2.2)

          actionpack (= 7.2.2.2)

          activejob (= 7.2.2.2)

          activerecord (= 7.2.2.2)

          activesupport (= 7.2.2.2)

          marcel (~> 1.0)

        activesupport (7.1.5.2)

        activesupport (7.2.2.2)

          base64

          benchmark (>= 0.3)

          bigdecimal

          concurrent-ruby (~> 1.0, >= 1.0.2)

          concurrent-ruby (~> 1.0, >= 1.3.1)

          connection_pool (>= 2.2.5)

          drb

          i18n (>= 1.6, < 2)

          logger (>= 1.4.2)

          minitest (>= 5.1)

          mutex_m

          securerandom (>= 0.3)

          tzinfo (~> 2.0)

          tzinfo (~> 2.0, >= 2.0.5)

        addressable (2.8.7)

          public_suffix (>= 2.0.2, < 7.0)

        annotate (3.2.0)

    @@ -117,7 +111,6 @@ GEM
  
        bootsnap (1.18.6)

          msgpack (~> 1.2)

        builder (3.3.0)

        cgi (0.5.0)

        climate_control (1.2.0)

        concurrent-ruby (1.3.5)

        connection_pool (2.5.4)

    @@ -139,8 +132,7 @@ GEM
  
          dotenv (= 3.1.8)

          railties (>= 6.1)

        drb (2.2.3)

        erb (2.2.3)

          cgi

        erb (5.0.2)

        erubi (1.13.1)

        execjs (2.10.0)

        faraday (2.12.2)

    @@ -154,7 +146,7 @@ GEM
  
          ffi (>= 1.15.5)

          rake

        gems (1.3.0)

        globalid (1.2.1)

        globalid (1.3.0)

          activesupport (>= 6.1)

        google-api-client (0.53.0)

          google-apis-core (~> 0.1)

    @@ -236,7 +228,7 @@ GEM
  
          net-imap

          net-pop

          net-smtp

        marcel (1.0.4)

        marcel (1.1.0)

        mini_mime (1.1.5)

        mini_portile2 (2.8.9)

        minitest (5.25.5)

    @@ -280,7 +272,7 @@ GEM
  
        puma (7.0.4)

          nio4r (~> 2.0)

        racc (1.8.1)

        rack (3.2.1)

        rack (3.1.16)

        rack-attack (6.7.0)

          rack (>= 1.0, < 4)

        rack-session (2.1.1)

    @@ -290,31 +282,31 @@ GEM
  
          rack (>= 1.3)

        rackup (2.2.1)

          rack (>= 3)

        rails (7.1.5.2)

          actioncable (= 7.1.5.2)

          actionmailbox (= 7.1.5.2)

          actionmailer (= 7.1.5.2)

          actionpack (= 7.1.5.2)

          actiontext (= 7.1.5.2)

          actionview (= 7.1.5.2)

          activejob (= 7.1.5.2)

          activemodel (= 7.1.5.2)

          activerecord (= 7.1.5.2)

          activestorage (= 7.1.5.2)

          activesupport (= 7.1.5.2)

        rails (7.2.2.2)

          actioncable (= 7.2.2.2)

          actionmailbox (= 7.2.2.2)

          actionmailer (= 7.2.2.2)

          actionpack (= 7.2.2.2)

          actiontext (= 7.2.2.2)

          actionview (= 7.2.2.2)

          activejob (= 7.2.2.2)

          activemodel (= 7.2.2.2)

          activerecord (= 7.2.2.2)

          activestorage (= 7.2.2.2)

          activesupport (= 7.2.2.2)

          bundler (>= 1.15.0)

          railties (= 7.1.5.2)

          railties (= 7.2.2.2)

        rails-dom-testing (2.3.0)

          activesupport (>= 5.0.0)

          minitest

          nokogiri (>= 1.6)

        rails-html-sanitizer (1.6.2)

          loofah (~> 2.21)

          nokogiri (>= 1.15.7, != 1.16.7, != 1.16.6, != 1.16.5, != 1.16.4, != 1.16.3, != 1.16.2, != 1.16.1, != 1.16.0.rc1, != 1.16.0)

        railties (7.1.5.2)

          actionpack (= 7.1.5.2)

          activesupport (= 7.1.5.2)

          irb

        railties (7.2.2.2)

          actionpack (= 7.2.2.2)

          activesupport (= 7.2.2.2)

          irb (~> 1.13)

          rackup (>= 1.0.0)

          rake (>= 12.2)

          thor (~> 1.0, >= 1.2.2)

    @@ -417,6 +409,7 @@ GEM
  
          unicode-emoji (~> 4.1)

        unicode-emoji (4.1.0)

        uri (1.0.3)

        useragent (0.16.11)

        vcr (6.3.1)

          base64

        web-console (4.2.1)

    @@ -428,7 +421,7 @@ GEM
  
          addressable (>= 2.8.0)

          crack (>= 0.3.2)

          hashdiff (>= 0.4.0, < 2.0.0)

        websocket-driver (0.7.7)

        websocket-driver (0.8.0)

          base64

          websocket-extensions (>= 0.1.0)

        websocket-extensions (0.1.5)

    @@ -466,7 +459,7 @@ DEPENDENCIES
  
      pg

      puma

      rack-attack

      rails (~> 7.1.0)

      rails (~> 7.2.0)

      rubocop

      rubocop-rails

      sass-rails

    @@ -483,7 +476,7 @@ DEPENDENCIES
  
      webmock

    RUBY VERSION

       ruby 3.2.9p265

       ruby 3.4.6p54

    BUNDLED WITH

       2.4.19

app/models/normalize_timdex.rb

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -68,7 +68,7 @@ def extract_collection_id(identifiers)
  
      def extract_list(contributors)

        contributors&.map do |creator|

          [creator['value'], '&field[]=creators_text&q[]=' << URI.encode_www_form_component(creator['value'])]

          [creator['value'], "&field[]=creators_text&q[]=#{URI.encode_www_form_component(creator['value'])}"]

        end

      end

bin/rubocop

-Original file line number
+Diff line change
@@ -0,0 +1,8 @@
+    #!/usr/bin/env ruby
+    require "rubygems"
+    require "bundler/setup"
+    # explicit rubocop config increases performance slightly while avoiding config confusion.
+    ARGV.unshift("--config", File.expand_path("../.rubocop.yml", __dir__))
+    load Gem.bin_path("rubocop", "rubocop")

bin/setup

-Original file line number
+Diff line change
@@ -1,8 +1,8 @@
     #!/usr/bin/env ruby
     require "fileutils"
-    # path to your application root.
     APP_ROOT = File.expand_path("..", __dir__)
+    APP_NAME = "mit-bento"
     def system!(*args)
       system(*args, exception: true)
@@ Expand Down Expand Up / @@ -30,4 +30,8 @@ FileUtils.chdir APP_ROOT do @@
       puts "\n== Restarting application server =="
       system! "bin/rails restart"
+      # puts "\n== Configuring puma-dev =="
+      # system "ln -nfs #{APP_ROOT} ~/.puma-dev/#{APP_NAME}"
+      # system "curl -Is https://#{APP_NAME}.test/up | head -n 1"
     end

config/application.rb

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -9,12 +9,12 @@
  
    module MitBento

      class Application < Rails::Application

        # Initialize configuration defaults for originally generated Rails version.

        config.load_defaults 7.1

        config.load_defaults 7.2

        # Please, add to the `ignore` list any other `lib` subdirectories that do

        # not contain `.rb` files, or that should not be reloaded or eager loaded.

        # Common ones are `templates`, `generators`, or `middleware`, for example.

        config.autoload_lib(ignore: %w(assets tasks))

        config.autoload_lib(ignore: %w[assets tasks])

        # Configuration for the application, engines, and railties goes here.

        #

config/environments/development.rb

-Original file line number
+Diff line change
@@ Expand Up / @@ -14,7 +14,7 @@ @@
       # Show full error reports.
       config.consider_all_requests_local = true
-      # Enable server timing
+      # Enable server timing.
       config.server_timing = true
       # Enable/disable caching. By default caching is disabled.
@@ Expand All / @@ -24,9 +24,7 @@ @@
         config.action_controller.enable_fragment_cache_logging = true
         config.cache_store = :memory_store
-        config.public_file_server.headers = {
-          "Cache-Control" => "public, max-age=#{2.days.to_i}"
-        }
+        config.public_file_server.headers = { "Cache-Control" => "public, max-age=#{2.days.to_i}" }
       else
         config.action_controller.perform_caching = false
@@ Expand All / @@ -39,9 +37,13 @@ @@
       # Don't care if the mailer can't send.
       config.action_mailer.raise_delivery_errors = false
+      # Disable caching for Action Mailer templates even if Action Controller
+      # caching is enabled.
+      #
       config.action_mailer.perform_caching = false
       config.action_mailer.delivery_method = :file
+      config.action_mailer.default_url_options = { host: "localhost", port: 3000 }
       # Print deprecation notices to the Rails logger.
       config.active_support.deprecation = :log
@@ Expand Down Expand Up / @@ -93,6 +95,9 @@ @@
       # Uncomment if you wish to allow Action Cable access from any origin.
       # config.action_cable.disable_request_forgery_protection = true
-      # Raise error when a before_action's only/except options reference missing actions
+      # Raise error when a before_action's only/except options reference missing actions.
       config.action_controller.raise_on_missing_callback_actions = true
+      # Apply autocorrection by RuboCop to files generated by `bin/rails generate`.
+      # config.generators.apply_rubocop_autocorrect_after_generate!
     end

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rails 7.2 and Ruby 3.4 #1471

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!