Skip to content

Commit fc6d538

Browse files
authored
Merge pull request #42 from MONEYMONG/feature/moneymong-520-플로우-개선작업
moneymong-520 feat: 회원가입 플로우 개선 작업
2 parents 770036c + aefa3d5 commit fc6d538

File tree

23 files changed

+825
-250
lines changed

23 files changed

+825
-250
lines changed

core/design-system/src/main/java/com/moneymong/moneymong/design_system/component/button/Button.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ fun MDSButton(
3030
@DrawableRes iconResource: Int? = null,
3131
enabled: Boolean = true,
3232
contentHorizontalPadding: Dp = 0.dp,
33+
cornerShape : Dp = 10.dp,
3334
) {
3435
val backgroundColor = if (enabled) type.backgroundColor else disabledBackgroundColor
3536
val contentColor = if (enabled) type.contentColor else disabledContentColor
@@ -38,10 +39,10 @@ fun MDSButton(
3839
modifier = modifier
3940
.background(
4041
color = backgroundColor,
41-
shape = RoundedCornerShape(10.dp)
42+
shape = RoundedCornerShape(cornerShape)
4243
)
4344
.clip(
44-
RoundedCornerShape(10.dp)
45+
RoundedCornerShape(cornerShape)
4546
)
4647
.clickable(
4748
onClick = onClick,
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.moneymong.moneymong.model.sign
22

33
data class UnivResponse(
4-
val universityName: String,
5-
val grade: Int
4+
val universityName: String?,
5+
val grade: Int?
66
)

feature/agency/src/main/java/com/moneymong/moneymong/feature/agency/search/AgencySearchViewModel.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ class AgencySearchViewModel @Inject constructor(
6868
isLoading = false,
6969
joinedAgencies = fetchMyAgenciesResult.getOrThrow()
7070
.map { myAgencyResponse -> myAgencyResponse.toAgency() },
71-
isUniversityStudent = fetchMyUniversityResult.getOrThrow().universityName.isNotBlank(),
71+
isUniversityStudent = fetchMyUniversityResult.getOrThrow().universityName?.isNotBlank() ?: false ,
7272
)
7373
}
7474
} else {

feature/home/src/main/java/com/moneymong/moneymong/home/HomeScreen.kt

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,10 @@ import com.moneymong.moneymong.feature.sign.navigation.loginScreen
2929
import com.moneymong.moneymong.feature.sign.navigation.navigateLogin
3030
import com.moneymong.moneymong.feature.sign.navigation.navigateSignComplete
3131
import com.moneymong.moneymong.feature.sign.navigation.navigateSignUp
32+
import com.moneymong.moneymong.feature.sign.navigation.navigateSignUpUniversity
3233
import com.moneymong.moneymong.feature.sign.navigation.signCompleteScreen
3334
import com.moneymong.moneymong.feature.sign.navigation.signUpScreen
35+
import com.moneymong.moneymong.feature.sign.navigation.signUpUniversity
3436
import com.moneymong.moneymong.feature.sign.navigation.splashRoute
3537
import com.moneymong.moneymong.feature.sign.navigation.splashScreen
3638
import com.moneymong.moneymong.home.navigation.rememberHomeNavigator
@@ -99,7 +101,15 @@ fun HomeScreen(
99101
)
100102

101103
signUpScreen(
102-
navigateToSignComplete = homeNavController::navigateSignComplete,
104+
navigateToLedger = homeNavController::navigateLedger,
105+
navigateToSignUniversity = homeNavController::navigateSignUpUniversity,
106+
navigateToAgency = homeNavController::navigateAgency,
107+
navigateUp = homeNavController::navigateUp
108+
)
109+
110+
signUpUniversity(
111+
navigateToLedger = homeNavController::navigateLedger,
112+
navigateToAgency = homeNavController::navigateAgency,
103113
navigateUp = homeNavController::navigateUp
104114
)
105115

feature/mymong/src/main/java/com/moneymong/moneymong/feature/mymong/main/MyMongScreen.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ fun MyMongScreen(
101101
name = state.name,
102102
email = state.email,
103103
university = state.university,
104-
grade = state.grade,
105104
getInfo = viewModel::getInfo
106105
)
107106
Spacer(modifier = Modifier.height(16.dp))

feature/mymong/src/main/java/com/moneymong/moneymong/feature/mymong/main/MyMongState.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ data class MyMongState(
66
val name: String = "",
77
val email: String = "",
88
val university: String = "",
9-
val grade: Int = 0,
109
val infoErrorMessage: String = "",
1110
val logoutErrorMessage: String = "",
1211
val isInfoLoading: Boolean = true,

feature/mymong/src/main/java/com/moneymong/moneymong/feature/mymong/main/MyMongViewModel.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ class MyMongViewModel @Inject constructor(
5353
name = it.name,
5454
email = it.email,
5555
university = it.university.orEmpty(),
56-
grade = it.grade
5756
)
5857
}
5958
}.onFailure {

feature/mymong/src/main/java/com/moneymong/moneymong/feature/mymong/main/view/MyMongInfoView.kt

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ internal fun MyMongInfoView(
4343
name: String,
4444
email: String,
4545
university: String,
46-
grade: Int,
4746
getInfo: () -> Unit
4847
) {
4948
Box(
@@ -66,10 +65,7 @@ internal fun MyMongInfoView(
6665
email = email
6766
)
6867
Spacer(modifier = Modifier.height(20.dp))
69-
UniversityInfo(
70-
university = university,
71-
grade = grade
72-
)
68+
UniversityInfo(university = university)
7369
}
7470
}
7571
}
@@ -123,14 +119,10 @@ private fun Profile(
123119

124120
@Composable
125121
fun UniversityInfo(
126-
university: String,
127-
grade: Int
122+
university: String
128123
) {
129-
val universityInfoText = when {
130-
university.isEmpty() -> "정보 없음"
131-
grade == 5 -> "$university ${grade}학년 이상"
132-
else -> "$university ${grade}학년"
133-
}
124+
125+
val universityInfoText = university.ifEmpty { "정보 없음" }
134126

135127
Box(
136128
modifier = Modifier

0 commit comments

Comments
 (0)