Merge pull request #118 from MONEYMONG/refactor/error-code

Error case 수정

Author: Siwon-L

Projects/Core/MMNetwork/Sources/NetworkManager.swift

@@ -29,15 +29,13 @@ public final class NetworkManager: NetworkManagerInterfacae {
     {
       if let message = errorResponse.message {
         throw MoneyMongError.appError(
-          MoneyMongError.Code(rawValue: errorResponse.code) ?? .default,
-          errorMessage: message
+          MoneyMongError.Code(rawValue: errorResponse.code) ?? .default
         )
       }
 
       if let messages = errorResponse.messages {
         throw MoneyMongError.appError(
-          MoneyMongError.Code(rawValue: errorResponse.code) ?? .default,
-          errorMessage: messages.joined(separator: "\n")
+          MoneyMongError.Code(rawValue: errorResponse.code) ?? .default
         )
       }
     }
@@ -98,22 +96,20 @@ public final class NetworkManager: NetworkManagerInterfacae {
       {
         if let message = errorResponse.message {
           throw MoneyMongError.appError(
-            MoneyMongError.Code(rawValue: errorResponse.code) ?? .default,
-            errorMessage: message
+            MoneyMongError.Code(rawValue: errorResponse.code) ?? .default
           )
         }
 
         if let messages = errorResponse.messages {
           throw MoneyMongError.appError(
-            MoneyMongError.Code(rawValue: errorResponse.code) ?? .default,
-            errorMessage: messages.joined(separator: "\n")
+            MoneyMongError.Code(rawValue: errorResponse.code) ?? .default
           )
         }
       }
 
       assertionFailure("dto디코딩, error디코딩 모두 실패 이러면 안되요 디버깅 해주세요")
 
-      throw MoneyMongError.appError(.default, errorMessage: "디코딩 실패")
+      throw MoneyMongError.appError(.default)
     case let .failure(error):
       throw error
     }

Projects/Core/MMNetwork/Testing/MockNetworkManager.swift

@@ -1,4 +1,6 @@
 import Repository
+import MMNetworkInterface
+import Utility
 
 public final class MockNetworkManager: NetworkManagerInterfacae {
   public var returnValue: (any Responsable)?
@@ -7,16 +9,16 @@ public final class MockNetworkManager: NetworkManagerInterfacae {
 
   public var requestCallCount: Int = 0
 
-  public func request<DTO>(target: any Core.TargetType, of type: DTO.Type) async throws -> DTO where DTO : Core.Responsable {
+  public func request<DTO>(target: any TargetType, of type: DTO.Type) async throws -> DTO where DTO : Responsable {
     requestCallCount += 1
     targetType = target
-    if isError { throw MoneyMongError.appError(.default, errorMessage: "error case") }
+    if isError { throw MoneyMongError.appError(.default) }
     return returnValue as! DTO
   }
 
-  public func request(target: any Core.TargetType) async throws {
+  public func request(target: any TargetType) async throws {
     requestCallCount += 1
     targetType = target
-    if isError { throw MoneyMongError.appError(.default, errorMessage: "error case") }
+    if isError { throw MoneyMongError.appError(.default) }
   }
 }

Projects/Core/Repository/Sources/APIs/SignAPI/Repository/SignRepository.swift

@@ -33,15 +33,15 @@ public struct SignRepository: SignRepositoryInterface {
     do {
       return try await kakaoAuthManager.sign()
     } catch {
-      throw MoneyMongError.unknown(error.localizedDescription)
+      throw MoneyMongError.default(error.localizedDescription)
     }
   }
 
   public func appleSign() async throws -> AppleAuthInfo {
     do {
       return try await appleAuthManager.sign()
     } catch {
-      throw MoneyMongError.unknown(error.localizedDescription)
+      throw MoneyMongError.default(error.localizedDescription)
     }
   }
 

Projects/Domain/Agency/Sources/DeleteAgencyUseCase.swift

@@ -24,7 +24,7 @@ public struct DeleteAgencyUseCase: DeleteAgencyUseCaseInterface {
       widgetRefreshController.refresh()
     }
     guard let id else {
-      throw MoneyMongError.appError(.default, errorMessage: "소속을 삭제할 수 없습니다\n잠시 후 다시 시도해 주세요")
+      throw MoneyMongError.default("소속을 삭제할 수 없습니다\n잠시 후 다시 시도해 주세요")
     }
     try await agencyRepo.deleteAgency(id: id)
     let newAgency = try await agencyRepo.fetchMyAgency().first

Projects/Domain/Auth/Testing/MockAutoSignUseCase.swift

@@ -4,6 +4,6 @@ public struct MockAutoSignUseCase: AutoSignUseCaseInterface {
   public init() {}
 
   public func execute() async throws {
-    throw MoneyMongError.appError(.default, errorMessage: "")
+    throw MoneyMongError.appError(.default)
   }
 }

Projects/Domain/BaseDomain/Sources/SocialLogin/Apple/AppleAuthManager.swift

@@ -44,7 +44,7 @@ extension AppleAuthManager: ASAuthorizationControllerDelegate {
           let name = appIDCredntial.fullName
     else {
       continuation?
-        .resume(throwing: MoneyMongError.unknown("유저 정보를 가져오지 못했습니다."))
+        .resume(throwing: MoneyMongError.default("유저 정보를 가져오지 못했습니다."))
       return
     }
     guard let familyName = name.familyName,
@@ -75,6 +75,6 @@ extension AppleAuthManager: ASAuthorizationControllerDelegate {
       return
     }
     continuation?
-      .resume(throwing: MoneyMongError.unknown(error.localizedDescription))
+      .resume(throwing: MoneyMongError.default(error.localizedDescription))
   }
 }

Projects/Domain/BaseDomain/Sources/SocialLogin/Kakao/KakaoAuthManager.swift

@@ -43,7 +43,7 @@ extension KakaoAuthManager {
       if let kakaoError = error as? SdkError {
         let reason = kakaoError.getClientError().reason
         if reason == .Cancelled { return }
-        continuation.resume(throwing: MoneyMongError.unknown(kakaoError.localizedDescription))
+        continuation.resume(throwing: MoneyMongError.default(kakaoError.localizedDescription))
       }
       if let accessToken = oauthToken?.accessToken {
         continuation.resume(returning: KakaoAuthInfo(accessToken: accessToken))
@@ -56,7 +56,7 @@ extension KakaoAuthManager {
       if let kakaoError = error as? SdkError {
         let reason = kakaoError.getClientError().reason
         if reason == .Cancelled { return }
-        continuation.resume(throwing: MoneyMongError.unknown(kakaoError.localizedDescription))
+        continuation.resume(throwing: MoneyMongError.default(kakaoError.localizedDescription))
       }
       if let accessToken = oauthToken?.accessToken {
         continuation.resume(returning: KakaoAuthInfo(accessToken: accessToken))

Projects/Feature/Agency/Sources/Scene/JoinAgency/JoinAgencyReactor.swift

@@ -85,8 +85,14 @@ final class JoinAgencyReactor: Reactor {
         newState.snackBarMessage = "잘못된 초대코드입니다"
       }
 
-    case let .joinAgencyResponse(.failure(value)):
-      newState.errorMessage = value.errorDescription
+    case let .joinAgencyResponse(.failure(error)):
+      if error == MoneyMongError.appError(.invitation_001) ||
+          error == MoneyMongError.appError(.invitation_002) ||
+          error == MoneyMongError.appError(.invitation_003) {
+        newState.snackBarMessage = "잘못된 초대코드입니다"
+      } else {
+        newState.errorMessage = error.errorDescription
+      }
     }
     return newState
   }

Projects/Feature/Ledger/Sources/Scene/Ledger/Creaters/Manual/ManualCreater/CreateManualLedgerReactor.swift

@@ -151,7 +151,7 @@ final class CreateManualLedgerReactor: Reactor {
         let imageURL: ImageInfo
         guard let index = currentState.content.documentImages.firstIndex(where: {
           $0.id == image.id
-        }) else { throw MoneyMongError.appError(.default, errorMessage: "이미지 삭제가 정상적으로 이뤄지지 않았습니다") }
+        }) else { throw MoneyMongError.default("이미지 삭제가 정상적으로 이뤄지지 않았습니다") }
         imageURL = currentState.content.documentImages[index]
         try await deleteImageUseCase.execute(imageURL)
         return index
@@ -265,14 +265,14 @@ private extension CreateManualLedgerReactor {
   func requestCreateLedgerRecord() -> Observable<Mutation> {
     return .task {
       guard let amount = Int(currentState.content.amount.filter { $0.isNumber }) else {
-        throw MoneyMongError.appError(.default, errorMessage: "금액을 확인해 주세요")
+        throw MoneyMongError.default("금액을 확인해 주세요")
       }
       guard let date = formatter.mergeWithISO8601(
         date: currentState.content.date,
         time: currentState.content.time != "" ? currentState.content.time : formatter.convertToTime(date: .now)
       )
       else {
-        throw MoneyMongError.appError(.default, errorMessage: "날짜 및 시간을 확인해 주세요")
+        throw MoneyMongError.default("날짜 및 시간을 확인해 주세요")
       }
       let memo = currentState.content.memo.isEmpty ? "내용없음" : currentState.content.memo
       return try await createLedgerUseCase.execute(
@@ -301,7 +301,7 @@ private extension CreateManualLedgerReactor {
   func uploadImage(image: ImageData) -> Observable<Mutation> {
     return .task {
       guard let resizeImateData = UIImage(data: image.data)?.jpegData(compressionQuality: 0.027) else {
-        throw MoneyMongError.appError(.default, errorMessage: "첨부 이미지를 확인해 주세요")
+        throw MoneyMongError.default("첨부 이미지를 확인해 주세요")
       }
       var entity = try await uploadImageUseCase.execute(imageData: resizeImateData)
       entity.id = image.id

Projects/Feature/Sign/Sources/Scene/Splash/SplashVC.swift

@@ -55,7 +55,7 @@ final class SplashVC: BaseVC, View {
       .observe(on: MainScheduler.instance)
       .filter { $0 }
       .bind(with: self) { owner, value in
-        owner.coordinator?.alert(title: "안정적인 머니몽 사용을 위해\n최신 버전으로 업데이트가 필요해요!") {
+        owner.coordinator?.alert(title: "최적의 사용 환경을 위해\n머니몽 업데이트가 필요해요") {
           if let url = URL(string: "itms-apps://itunes.apple.com/app/id6503661220"),
                        UIApplication.shared.canOpenURL(url)
           {