Changes per PR comments

1. change declaration of constant 2-D character array to allow initializing
   strings of different sizes.
2. pass optional args to mpas_log_write from close_file_with_message,
   even when not present.
3. use format of MPAS_IO_NETCDF when creating test data file.

Author: jim-p-w

src/core_test/mpas_test_core_io.F

@@ -32,11 +32,7 @@ subroutine close_file_with_message(fileHandle, message, args)
 
       ! log an error message
       if (present(message)) then
-         if (present(args)) then
-            ERROR_WRITE_ARGS(message, intArgs=args)
-         else
-            ERROR_WRITE(message)
-         end if
+         ERROR_WRITE_ARGS(message, intArgs=args)
       end if
 
       ! close the provided file
@@ -66,7 +62,8 @@ subroutine test_read_string_buffer_check(domain, ierr)
       integer :: local_ierr, i
       type(MPAS_IO_Handle_type) :: fileHandle
       character (len=StrKIND), dimension(1), parameter :: dimNamesString = ['StrLen']
-      character (len=StrKIND), dimension(2), parameter :: dimNamesStringTime = ['StrLen', 'Time  ']
+      character (len=StrKIND), dimension(2), parameter :: dimNamesStringTime = &
+         [character(len=StrKIND) :: 'StrLen', 'Time']
       character (len=32), parameter :: varName1 = 'stringVar'
       character (len=32), parameter :: varName2 = 'stringTimeVar'
       character (len=*), parameter :: varValue1 = 'This is a string'
@@ -80,7 +77,7 @@ subroutine test_read_string_buffer_check(domain, ierr)
       ierr = 0
 
       ! open a file to write char variables to
-      fileHandle = MPAS_io_open(filename, MPAS_IO_WRITE, MPAS_IO_NETCDF4, domain % ioContext, &
+      fileHandle = MPAS_io_open(filename, MPAS_IO_WRITE, MPAS_IO_NETCDF, domain % ioContext, &
                                   clobber_file=.true., truncate_file=.true., ierr=local_ierr)
       if (local_ierr /= MPAS_IO_NOERR) then
          ierr = 1