hard-coded file paths prevent file migrations

[RedSPINE]

Hello there ! I’m trying to use this plugin, and realized I wasn't free to move the files around without breaking stuff.
Additionally, I went through some code and did not understand why those hard-coded file paths were needed.

For example, in global_state_data.gd, the filepath of game_state.gd is given through method parameters, but I do not understand why those 4 lines :

func get_state(key_name : String, state_type_path : String) -> GameState:
	var new_state : Resource
	var new_state_script = load(state_type_path)
	if new_state_script is GDScript:
		new_state = new_state_script.new()

Could not be replaced by one line :

func get_state(key_name : String, state_type_path : String) -> GameState:
	var new_state : Resource = GameState.new()

Erasing the need to submit the file path for the game_state script and allowing me to move it around without breaking anything.

I am no expert and would like to be enlightened 😆 thank you !

[RedSPINE]

Another example is for the SceneLister, that tracks the level scenes using their paths instead of referencing PackedScenes.

[Maaack]

Thanks for the feedback!

I recall my original intent with global_state_data.gd was to be application agnostic. I wanted users to have the option to use GameState, or any other custom Resource they want. I think an argument can be made that this added flexibility isn't helpful for a "Game Template", though. It's also a bit at odds, since it's become less flexible for moving files around after install.

In the second case of the SceneLister, I recall the intent there being to lazy load the levels. If I pass them in as PackedScenes, then (as I understand it) they'd all get loaded into memory at the same time as SceneLister. It's an optimization, but one that I think is generally helpful. For convenience, the SceneLister can be pointed to a directory, and it'll auto-fill the files list, so you don't need to change each one.

I hope that helps explain some of the design choices. I'm open to thoughts and feedback (welcoming others to chime in, too). I feel pretty flexible on the first point. For the second point, unless additional information comes to light, I lean toward keeping the current functionality.

[RedSPINE]

I see ! Well what I was going to do in any was to modify the GameState directly to add the data I need to save in there :)
That's what I’ve done on my side and I think it also is easier to understand for a newcomer.

For the second case, I understood by playing with it and I think I’ll keep it that way ! It will be easier for my partners to simply add their levels in the dedicated folder, indeed ! Thank you for you answer !