It wouldn't hurt to clean up the member variables in the class, as they're declared and initialized in inconsistent ways. However, I tried to keep changes minimal for this PR.
- Can remove all the
volatile markers, as all these member variables are protected by the mux.
- Use either inline initialization in the class definition or initialization in
begin. Currently it's a mix.
- Add doc comments or remove them for internal variables. Right now some have them, some don't, and some have empty blocks.
Originally posted by @cleishm in #15 (comment)
It wouldn't hurt to clean up the member variables in the class, as they're declared and initialized in inconsistent ways. However, I tried to keep changes minimal for this PR.
volatilemarkers, as all these member variables are protected by themux.begin. Currently it's a mix.Originally posted by @cleishm in #15 (comment)