Refactor common code to helper function

Author: GilbertCherrie

app/controllers/vm_cloud_controller.rb

@@ -115,16 +115,18 @@ def get_filters
   end
 
   def prefix_by_nodetype(nodetype)
-    case TreeBuilder.get_model_for_prefix(nodetype).underscore
+    model = TreeBuilder.get_model_for_prefix(nodetype)
+    return nil if model.nil?
+
+    case model.underscore
     when "miq_template" then "images"
     when "vm"           then "instances"
     end
   end
 
   def set_elements_and_redirect_unauthorized_user
-    params[:id] = normalize_vm_node_id(params[:id])
-    @nodetype, _id = parse_nodetype_and_id(params[:id])
-    prefix = prefix_by_nodetype(@nodetype)
+    prefix = setup_node_and_prefix
+    return true if prefix.nil?
 
     # Position in tree that matches selected record
     if role_allows?(:feature => "instances_accord") && prefix == "instances"

app/controllers/vm_common.rb

@@ -800,6 +800,28 @@ def normalize_vm_node_id(id)
     record ? TreeBuilder.build_node_id(record) : id
   end
 
+  # Shared preamble for all VM explorer set_elements_and_redirect_unauthorized_user methods.
+  # Normalises params[:id], parses the nodetype, resolves the accordion prefix, and handles
+  # the case where the prefix is nil (bad/unrecognised node id) by redirecting back to the
+  # explorer with an error flash.
+  #
+  # Returns the resolved prefix string, or nil if a redirect was already issued (in which
+  # case the caller should return immediately).
+  def setup_node_and_prefix
+    params[:id] = normalize_vm_node_id(params[:id])
+    @nodetype, = parse_nodetype_and_id(params[:id])
+    prefix = prefix_by_nodetype(@nodetype)
+
+    if prefix.nil?
+      session.delete(:exp_parms)
+      flash_to_session(_("Can't access selected records"), :error)
+      redirect_to(:action => 'explorer', :id => nil)
+      return nil
+    end
+
+    prefix
+  end
+
   # if node is VM or Template is true - select parent node in explorer tree but show info of Vm/Template
   def resolve_node_info(id)
     nodetype, id = id.split("-")

app/controllers/vm_infra_controller.rb

@@ -42,16 +42,18 @@ def features
   end
 
   def prefix_by_nodetype(nodetype)
-    case TreeBuilder.get_model_for_prefix(nodetype).underscore
+    model = TreeBuilder.get_model_for_prefix(nodetype)
+    return nil if model.nil?
+
+    case model.underscore
     when "miq_template" then "templates"
     when "vm"           then "vms"
     end
   end
 
   def set_elements_and_redirect_unauthorized_user
-    params[:id] = normalize_vm_node_id(params[:id])
-    @nodetype, _id = parse_nodetype_and_id(params[:id])
-    prefix = prefix_by_nodetype(@nodetype)
+    prefix = setup_node_and_prefix
+    return true if prefix.nil?
 
     # Position in tree that matches selected record
     if role_allows?(:feature => "vandt_accord")

app/controllers/vm_or_template_controller.rb

@@ -32,16 +32,18 @@ def features
   end
 
   def prefix_by_nodetype(nodetype)
-    case TreeBuilder.get_model_for_prefix(nodetype).underscore
+    model = TreeBuilder.get_model_for_prefix(nodetype)
+    return nil if model.nil?
+
+    case model.underscore
     when "miq_template" then "templates_images"
     when "vm"           then "vms_instances"
     end
   end
 
   def set_elements_and_redirect_unauthorized_user
-    params[:id] = normalize_vm_node_id(params[:id])
-    @nodetype, = parse_nodetype_and_id(params[:id])
-    prefix = prefix_by_nodetype(@nodetype)
+    prefix = setup_node_and_prefix
+    return true if prefix.nil?
 
     # Position in tree that matches selected record
     if role_allows?(:feature => "#{prefix}_filter_accord")