Make RNGs thread-local

michalsta · michalsta · commit c0fca7a7b0d5 · 2025-06-06T14:07:41.000+02:00
diff --git a/IsoSpec++/isoMath.cpp b/IsoSpec++/isoMath.cpp
@@ -146,9 +146,8 @@ double InverseLowerIncompleteGamma2(int a, double x)
     return s;
 }
 
-std::random_device random_dev;
-std::mt19937 random_gen(random_dev());
-std::uniform_real_distribution<double> stdunif(0.0, 1.0);
+thread_local std::mt19937 random_gen(std::random_device{}());
+thread_local std::uniform_real_distribution<double> stdunif(0.0, 1.0);
 
 size_t rdvariate_binom(size_t tries, double succ_prob, std::mt19937& rgen)
 {
diff --git a/IsoSpec++/isoMath.h b/IsoSpec++/isoMath.h
@@ -70,8 +70,8 @@ inline double InverseChiSquareCDF2(int k, double x)
     return InverseLowerIncompleteGamma2(k, x*tgamma(static_cast<double>(k)/2.0)) * 2.0;
 }
 
-extern std::mt19937 random_gen;
-extern std::uniform_real_distribution<double> stdunif;
+extern thread_local std::mt19937 random_gen;
+extern thread_local std::uniform_real_distribution<double> stdunif;
 
 inline double rdvariate_beta_1_b(double b, std::mt19937& rgen = random_gen)
 {

Original file line number	Diff line number	Diff line change
`@@ -146,9 +146,8 @@ double InverseLowerIncompleteGamma2(int a, double x)`
`146`	`146`	`return s;`
`147`	`147`	`}`
`148`	`148`
`149`		`-std::random_device random_dev;`
`150`		`-std::mt19937 random_gen(random_dev());`
`151`		`-std::uniform_real_distribution<double> stdunif(0.0, 1.0);`
	`149`	`+thread_local std::mt19937 random_gen(std::random_device{}());`
	`150`	`+thread_local std::uniform_real_distribution<double> stdunif(0.0, 1.0);`
`152`	`151`
`153`	`152`	`size_t rdvariate_binom(size_t tries, double succ_prob, std::mt19937& rgen)`
`154`	`153`	`{`
Original file line number	Diff line number	Diff line change
`@@ -70,8 +70,8 @@ inline double InverseChiSquareCDF2(int k, double x)`
`70`	`70`	`return InverseLowerIncompleteGamma2(k, xtgamma(static_cast<double>(k)/2.0)) 2.0;`
`71`	`71`	`}`
`72`	`72`
`73`		`-extern std::mt19937 random_gen;`
`74`		`-extern std::uniform_real_distribution<double> stdunif;`
	`73`	`+extern thread_local std::mt19937 random_gen;`
	`74`	`+extern thread_local std::uniform_real_distribution<double> stdunif;`
`75`	`75`
`76`	`76`	`inline double rdvariate_beta_1_b(double b, std::mt19937& rgen = random_gen)`
`77`	`77`	`{`