Skip to content

Fast can message reception bug? #25

@abauske

Description

@abauske

In https://github.com/Microchip-MPLAB-Harmony/bootloader/blob/df97872c0f83dcef3d3f4671a569fc8f4325d7f5/templates/src/optimized/bootloader_can_arm.c.ftl#L453C30-L453C30 rxBuf of type ${PERIPH_NAME}_RX_BUFFER* is being increased by ${PERIPH_USED}_RX_FIFO0_ELEMENT_SIZE. Should it not be increased by one only (next element)?
Or even: As sizeof(${PERIPH_NAME}_RX_BUFFER) is not necessarily the same as ${PERIPH_USED}_RX_FIFO0_ELEMENT_SIZE we maybe should even consider using rxBuf = (${PERIPH_NAME}_RX_BUFFER *) (rxFiFo0 + count * ${PERIPH_USED}_RX_FIFO0_ELEMENT_SIZE) in each iteration of the loop, right?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions