Skip to content

Commit e16cbaa

Browse files
committed
Add "load-root-tileset" event
1 parent 2c68b2f commit e16cbaa

File tree

7 files changed

+13
-6
lines changed

7 files changed

+13
-6
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ import { TilesRenderer } from '3d-tiles-renderer';
8383
const tilesRenderer = new TilesRenderer( './path/to/tileset.json' );
8484
tilesRenderer.setCamera( camera );
8585
tilesRenderer.setResolutionFromRenderer( camera, renderer );
86-
tilesRenderer.addEventListener( 'load-tileset', () => {
86+
tilesRenderer.addEventListener( 'load-root-tileset', () => {
8787

8888
// optionally center the tileset in case it's far off center
8989
const sphere = new Sphere();

example/three/cesiumCompare.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ async function initThree() {
264264
tiles.setCamera( camera );
265265

266266
let controls;
267-
tiles.addEventListener( 'load-tileset', () => {
267+
tiles.addEventListener( 'load-root-tileset', () => {
268268

269269
// position the camera based on the model
270270
const sphere = new Sphere();

example/three/ionExample.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function reinstantiateTiles() {
6969

7070
tiles = new TilesRenderer();
7171
tiles.registerPlugin( new CesiumIonAuthPlugin( { apiToken: params.ionAccessToken, assetId: params.ionAssetId } ) );
72-
tiles.addEventListener( 'load-tileset', () => {
72+
tiles.addEventListener( 'load-root-tileset', () => {
7373

7474
// because ion examples typically are positioned on the planet surface we can orient
7575
// it such that up is Y+ and center the model

src/core/renderer/tiles/TilesRendererBase.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -360,6 +360,11 @@ export class TilesRendererBase {
360360
tileset: root,
361361
url: processedUrl,
362362
} );
363+
this.dispatchEvent( {
364+
type: 'load-root-tileset',
365+
tileset: root,
366+
url: processedUrl,
367+
} );
363368

364369
} )
365370
.catch( error => {

src/three/plugins/ReorientationPlugin.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,11 +104,11 @@ export class ReorientationPlugin {
104104

105105
}
106106

107-
tiles.removeEventListener( 'load-tileset', this._callback );
107+
tiles.removeEventListener( 'load-root-tileset', this._callback );
108108

109109
};
110110

111-
tiles.addEventListener( 'load-tileset', this._callback );
111+
tiles.addEventListener( 'load-root-tileset', this._callback );
112112

113113
if ( tiles.root ) {
114114

@@ -138,7 +138,7 @@ export class ReorientationPlugin {
138138
group.quaternion.identity();
139139
group.scale.set( 1, 1, 1 );
140140

141-
this.tiles.removeEventListener( 'load-tileset', this._callback );
141+
this.tiles.removeEventListener( 'load-root-tileset', this._callback );
142142

143143
}
144144

src/three/renderer/tiles/TilesRenderer.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ export interface TilesRendererEventMap {
77
'add-camera': { camera: Camera };
88
'delete-camera': { camera: Camera };
99
'camera-resolution-change': {};
10+
'load-root-tileset': { tileset: object, url: string };
1011
'load-tileset': { tileset: object, /* @deprecated Use tileset instead */ tileSet?: object, url: string };
1112
/* @deprecated Use 'load-tileset' instead */
1213
'load-tile-set': { tileset: object, /* @deprecated Use tileset instead */ tileSet?: object, url: string };

test/three/TilesRenderer.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ function typecheck( renderer: TilesRenderer ) {
2929
renderer.addEventListener( 'add-camera', addCamera );
3030
renderer.addEventListener( 'delete-camera', deleteCamera );
3131
renderer.addEventListener( 'camera-resolution-change', emptyEvent );
32+
renderer.addEventListener( 'load-root-tileset', emptyEvent );
3233
renderer.addEventListener( 'load-tileset', loadTileset );
3334
renderer.addEventListener( 'tiles-load-start', emptyEvent );
3435
renderer.addEventListener( 'tiles-load-end', emptyEvent );

0 commit comments

Comments
 (0)