bug: wrf convert_vertical_state does not use which_vert,

[hkershaw-brown]

Skeleton will fill in later

wrf convert_vertical_state

DART/models/wrf/model_mod.f90

Line 3048 in 4c89e64

subroutine convert_vertical_state(state_handle, num, locs, loc_qtys, loc_indx, &

Does not use the passed in which_vert. It uses a module global
wrf%dom(id)%localization_coord

DART/models/wrf/model_mod.f90

Line 3094 in 4c89e64

if (wrf%dom(id)%localization_coord == VERTISLEVEL) then

So if you call convert_vertical_state to test the routine, and pass in a which_vert, this is ignored and whatever is set in the model_nml is used.

[hkershaw-brown]

Same bug in convert_vertical_obs

ignores the input which_vert:

DART/models/wrf/model_mod.f90

Lines 3027 to 3044 in 4c89e64

	subroutine convert_vertical_obs(state_handle, num, locs, loc_qtys, loc_types, &
	which_vert, status)
	type(ensemble_type), intent(in) :: state_handle
	integer, intent(in) :: num
	type(location_type), intent(inout) :: locs(:)
	integer, intent(in) :: loc_qtys(:)
	integer, intent(in) :: loc_types(:)
	integer, intent(in) :: which_vert
	integer, intent(out) :: status(:)
	integer :: i
	do i=1, num
	call vert_convert(state_handle, locs(i), loc_qtys(i), status(i))
	enddo
	end subroutine convert_vertical_obs