Skip to content

Commit aaee90b

Browse files
Cleanup junit tests and javadocs
1 parent a9496b0 commit aaee90b

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

src/test/java/edu/ucsb/nceas/mdqengine/scheduler/RequestReportJobTest.java

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,6 @@ public static void overrideConfigFilePathInMDQConfig(String fullPathToMetadigPro
161161

162162
// Junit Tests
163163

164-
// TODO: Add junit test for 'submitReportRequest'
165-
166164
/**
167165
* Confirm that a sysmeta object is returned. No exception should be thrown.
168166
*/
@@ -178,9 +176,7 @@ public void testGetSystemMetadataFromHashStore() throws Exception {
178176
}
179177

180178
/**
181-
* Confirm that when a NotAuthorized is thrown after calling the MN API as a backup method to
182-
* retrieve system metadata, this test method does not bubble up the exception and simply
183-
* returns
179+
* Confirm that an IOException is thrown when a sysmeta is not available
184180
*/
185181
@Test
186182
public void testGetSystemMetadataFromHashStore_metadataNotFound() throws Exception {
@@ -209,7 +205,7 @@ public void testGetObjectFromHashStore() throws Exception {
209205
}
210206

211207
/**
212-
* Confirm that a file not found exception is thrown when supplied with a pid that has no
208+
* Confirm that a FileNotFoundException is thrown when supplied with a pid that has no
213209
* data object.
214210
*/
215211
@Test
@@ -303,10 +299,10 @@ public void testGetStorePropsFromMetadigProps() {
303299
String sysmetaNamespace = (String) storeConfig.get("store_metadata_namespace");
304300

305301
assertEquals(hashStoreRootDirectory, storePath);
306-
assertEquals("3", storeDepth);
307-
assertEquals("2", storeWidth);
308-
assertEquals("SHA-256", storeAlgo);
309-
assertEquals("https://ns.dataone.org/service/types/v2.0#SystemMetadata", sysmetaNamespace);
302+
assertEquals(hashStoreDepth, storeDepth);
303+
assertEquals(hashStoreWidth, storeWidth);
304+
assertEquals(hashStoreAlgorithm, storeAlgo);
305+
assertEquals(hashStoreSysmetaNamespace, sysmetaNamespace);
310306
}
311307

312308
/**

0 commit comments

Comments
 (0)