Merge pull request #524 from NERSC/integration

additional smoke test for checkings NATS connection

Author: swelborn

frontend/interactEM/src/components/natsstatus.tsx

@@ -9,6 +9,14 @@ type NatsStatus = {
   tooltip: string
 }
 
+export const NATS_STATUS_TOOLTIPS = {
+  disconnected: "NATS is not connected",
+  draining: "NATS connection is draining",
+  closed: "NATS connection is closed",
+  connected: "NATS connection is active",
+  connecting: "NATS connection is establishing",
+} as const
+
 const getNatsStatus = (
   connection: NatsConnection | null,
   isConnected: boolean,
@@ -17,38 +25,38 @@ const getNatsStatus = (
     return {
       color: "error",
       label: "Disconnected",
-      tooltip: "NATS is not connected",
+      tooltip: NATS_STATUS_TOOLTIPS.disconnected,
     }
   }
 
   if (connection.isDraining()) {
     return {
       color: "warning",
       label: "Draining",
-      tooltip: "NATS connection is draining",
+      tooltip: NATS_STATUS_TOOLTIPS.draining,
     }
   }
 
   if (connection.isClosed()) {
     return {
       color: "error",
       label: "Closed",
-      tooltip: "NATS connection is closed",
+      tooltip: NATS_STATUS_TOOLTIPS.closed,
     }
   }
 
   if (isConnected) {
     return {
       color: "success",
       label: "Connected",
-      tooltip: "NATS connection is active",
+      tooltip: NATS_STATUS_TOOLTIPS.connected,
     }
   }
 
   return {
     color: "warning",
     label: "Connecting",
-    tooltip: "NATS connection is establishing",
+    tooltip: NATS_STATUS_TOOLTIPS.connecting,
   }
 }
 

frontend/interactEM/tests/e2e/fixtures/auth.ts

@@ -1,4 +1,4 @@
-import { expect, test as base, type Page } from "@playwright/test"
+import { expect, test as base, type Page, type TestType } from "@playwright/test"
 
 const username = process.env.FIRST_SUPERUSER_USERNAME
 const password = process.env.FIRST_SUPERUSER_PASSWORD
@@ -23,7 +23,7 @@ type Fixtures = {
   authPage: Page
 }
 
-export const test = base.extend<Fixtures>({
+export const test: TestType<Fixtures, {}> = base.extend<Fixtures>({
   authPage: async ({ page }, use) => {
     await login(page)
     await use(page)

frontend/interactEM/tests/e2e/smoke.spec.ts

@@ -1,7 +1,21 @@
 import { expect } from "@playwright/test"
+import { NATS_STATUS_TOOLTIPS } from "../../src/components/natsstatus"
 import { test } from "./fixtures/auth"
 
 test("loads composer page", async ({ authPage }) => {
   await authPage.waitForSelector(".composer-page", { timeout: 20_000 })
   await expect(authPage.locator(".composer-page")).toBeVisible()
 })
+
+test("shows NATS connected after login", async ({ authPage }) => {
+  const natsChip = authPage
+    .locator(".composer-page")
+    .getByText("NATS", { exact: true })
+
+  await expect(natsChip).toBeVisible()
+  await natsChip.hover()
+  await expect(authPage.getByRole("tooltip")).toHaveText(
+    NATS_STATUS_TOOLTIPS.connected,
+    { timeout: 5_000 },
+  )
+})

frontend/interactEM/tsconfig.json

@@ -21,7 +21,7 @@
     "noFallthroughCasesInSwitch": true,
     // Recommended setting (not in strict, but should be)
     "noUncheckedIndexedAccess": true,
-    "types": ["node"]
+    "types": ["node", "@playwright/test"]
   },
   "include": ["src", "tests", "playwright.config.ts"],
   "references": [{ "path": "./tsconfig.node.json" }]