fix: Fix issue where strip extra post hook with include codes would include everything due to exclude codes defaulting to all codes.

Author: EdgyEdgemond

src/starlette_problem/handler.py

@@ -175,7 +175,8 @@ def __init__(
 
     def __call__(self: t.Self, content: dict, _request: Request, response: JSONResponse) -> tuple[dict, JSONResponse]:
         strip_extras = self.enabled and (
-            response.status_code in self.include_status_codes or response.status_code not in self.exclude_status_codes
+            response.status_code in self.include_status_codes
+            or (not self.include_status_codes and response.status_code not in self.exclude_status_codes)
         )
 
         new_content = content.copy()

tests/test_handler.py

@@ -147,6 +147,34 @@ def test_strip_extras_post_hook_exclude_status_code(self):
             == b'{"type":"something-wrong","title":"This is an error.","status":500,"a":"b","detail":"something bad"}'
         )
 
+    def test_strip_extras_post_hook_include_status_code(self):
+        request = mock.Mock(headers={})
+        exc = SomethingWrongError("something bad", a="b")
+
+        eh = handler.ExceptionHandler(
+            post_hooks=[handler.StripExtrasPostHook(include_status_codes=[500], enabled=True)],
+        )
+        response = eh(request, exc)
+
+        assert (
+            response.body
+            == b'{"type":"something-wrong","title":"This is an error.","status":500,"detail":"something bad"}'
+        )
+
+    def test_strip_extras_post_hook_include_status_code_correctly_allows_other_codes_through(self):
+        request = mock.Mock(headers={})
+        exc = SomethingWrongError("something bad", a="b")
+
+        eh = handler.ExceptionHandler(
+            post_hooks=[handler.StripExtrasPostHook(include_status_codes=[400], enabled=True)],
+        )
+        response = eh(request, exc)
+
+        assert (
+            response.body
+            == b'{"type":"something-wrong","title":"This is an error.","status":500,"a":"b","detail":"something bad"}'
+        )
+
     def test_strip_extras_post_hook_custom_mandatory(self):
         request = mock.Mock(headers={})
         exc = SomethingWrongError("something bad", a="b")