Merge pull request #134 from JunAishima/handle-bnlpeople-exceptions

bnlpeople query failures fail more gracefully

Author: stuartcampbell

src/nsls2api/services/bnlpeople_service.py

@@ -35,7 +35,12 @@ async def get_username_by_id(lifenumber: str) -> Optional[str]:
 
     url = f"{base_url}/api/BNLPeople?employeeNumber={lifenumber}"
     logger.debug(f"Calling URL: {url}")
-    person = await _call_bnlpeople_webservice(url)
+    try:
+        person = await _call_bnlpeople_webservice(url)
+    except Exception as error:
+        message = f"BNL People API query failed for lifenumber {lifenumber}"
+        logger.exception(message)
+        return None
     logger.debug(person)
     if len(person) == 0 or len(person) > 1:
         logger.warning(