Fix silent failure when attaching evidence to unsaved reviews (#1690)

Author: Copilot

client/src/js/SM/Attachments.js

@@ -248,7 +248,8 @@ SM.Attachments.Grid = Ext.extend(Ext.grid.GridPanel, {
       style: 'width: 95px;',
       buttonText: `Attach image...`,
       buttonCfg: {
-          icon: "img/attachment.svg"
+          icon: "img/attachment.svg",
+          tooltip: ''
       },
       listeners: {
           fileselected: onFileSelected
@@ -257,6 +258,18 @@ SM.Attachments.Grid = Ext.extend(Ext.grid.GridPanel, {
     const config = {
       loadArtifacts: loadArtifacts,
       fileUploadField: fileUploadField,
+      updateAttachmentButtonState: function(reviewExists, hasWriteAccess) {
+        fileUploadField.setDisabled(!reviewExists || !hasWriteAccess)
+        if (fileUploadField.button) {
+          if (!reviewExists) {
+            fileUploadField.button.setTooltip('Save the review before attaching evidence')
+          } else if (!hasWriteAccess) {
+            fileUploadField.button.setTooltip('No write access')
+          } else {
+            fileUploadField.button.setTooltip('Attach an image file as evidence for this review')
+          }
+        }
+      },
       disableSelection: true,
       layout: 'fit',
       cls: 'custom-artifacts',

client/src/js/review.js

@@ -1219,6 +1219,9 @@ async function addReview( params ) {
     assetId: leaf.assetId
   })
 
+  // Track whether a review exists in the database
+  attachmentsGrid.reviewExists = false
+  
   /******************************************************/
   // END Attachments Panel
   /******************************************************/
@@ -1388,11 +1391,6 @@ async function addReview( params ) {
             projection: ['detail','ccis','check','fix']
           }
         }),
-        Ext.Ajax.requestPromise({
-          responseType: 'json',
-          url: `${STIGMAN.Env.apiBase}/collections/${collectionId}/reviews/${assetId}/${groupGridRecord.data.ruleId}`,
-          method: 'GET',
-        }),
         Ext.Ajax.requestPromise({
           responseType: 'json',
           url: `${STIGMAN.Env.apiBase}/collections/${collectionId}/reviews/${assetId}/${groupGridRecord.data.ruleId}`,
@@ -1403,7 +1401,7 @@ async function addReview( params ) {
         })      
       ]
 
-      const [content, review, reviewProjected] = await Promise.all(requests)
+      const [content, reviewProjected] = await Promise.all(requests)
 
       // CONTENT
       reviewTab.contentPanel.update(content)
@@ -1418,8 +1416,13 @@ async function addReview( params ) {
 
       // Display the review
       reviewForm.groupGridRecord = groupGridRecord
-      reviewForm.loadValues(review)
+      reviewForm.loadValues(reviewProjected)
       reviewForm.isLoaded = true
+      
+      // Check if review exists in database and update attachment button accordingly
+      attachmentsGrid.reviewExists = !!reviewProjected
+      attachmentsGrid.updateAttachmentButtonState(attachmentsGrid.reviewExists, reviewForm.defaultAccess === 'rw')
+      
       reviewForm.setReviewFormItemStates()
 
       if (! reviewProjected) {
@@ -1674,6 +1677,11 @@ async function addReview( params ) {
         saveParams.sm.selectRow(saveParams.index);
         return
       }
+      
+      // After successful save, review now exists in database
+      attachmentsGrid.reviewExists = true
+      attachmentsGrid.updateAttachmentButtonState(true, reviewForm.defaultAccess === 'rw')
+      
       reviewForm.setReviewFormItemStates(reviewForm)
     }
     catch (e) {