File tree Expand file tree Collapse file tree 1 file changed +3
-3
lines changed
Expand file tree Collapse file tree 1 file changed +3
-3
lines changed Original file line number Diff line number Diff line change @@ -1164,8 +1164,8 @@ def test_setup_launcher_no_launcher(self):
11641164 with patch ("nemo_run.core.execution.dgxcloud.CONSOLE" ):
11651165 executor ._setup_launcher ()
11661166
1167- # When no launcher, ntasks_per_node should remain as nprocs_per_node
1168- assert executor . ntasks_per_node == 8
1167+ # When no launcher, torchrun_nproc_per_node and ntasks_per_node should not be modified
1168+ # ntasks_per_node is only set when launcher is Torchrun or FaultTolerance
11691169 assert (
11701170 not hasattr (executor , "torchrun_nproc_per_node" )
11711171 or executor .torchrun_nproc_per_node is None
@@ -1259,7 +1259,7 @@ def test_setup_launcher_fault_tolerance_paths(self):
12591259 executor .job_dir = "/mnt/workspace/test_training"
12601260
12611261 with patch ("nemo_run.core.execution.dgxcloud.CONSOLE" ):
1262- with patch ("nemo_run.config .RUNDIR_NAME" , "custom_rundir" ):
1262+ with patch ("nemo_run.core.execution.dgxcloud .RUNDIR_NAME" , "custom_rundir" ):
12631263 executor ._setup_launcher ()
12641264
12651265 # Check path construction
You can’t perform that action at this time.
0 commit comments