f

Signed-off-by: oliver könig <okoenig@nvidia.com>

Author: ko3n1g

test/run/ray/test_kuberay.py

@@ -217,6 +217,7 @@ def test_create_basic_cluster(self, cluster_with_basic_executor, mock_k8s_client
         assert body["metadata"]["name"] == "testuser-test-cluster-raycluster"
         assert body["metadata"]["namespace"] == "test-namespace"
         assert body["spec"]["rayVersion"] == "2.43.0"
+
     def test_create_advanced_cluster(self, cluster_with_advanced_executor, mock_k8s_clients):
         """Test creating an advanced Ray cluster with volumes and custom settings."""
         mock_api, _ = mock_k8s_clients
@@ -747,9 +748,11 @@ class TestKubeRayExecutorUtilityFunctions:
     @pytest.fixture
     def basic_cluster_dict(self):
         """Create a basic cluster dictionary for testing."""
-        from nemo_run.core.execution.kuberay import (populate_meta,
-                                                     populate_ray_head,
-                                                     populate_worker_group)
+        from nemo_run.core.execution.kuberay import (
+            populate_meta,
+            populate_ray_head,
+            populate_worker_group,
+        )
 
         cluster = {}
         cluster = populate_meta(cluster, "test-cluster", "default", {}, "2.43.0")
@@ -863,8 +866,7 @@ def test_populate_ray_head_missing_spec(self):
 
     def test_populate_ray_head_without_dashboard_host(self):
         """Test populate_ray_head automatically adds dashboard-host."""
-        from nemo_run.core.execution.kuberay import (populate_meta,
-                                                     populate_ray_head)
+        from nemo_run.core.execution.kuberay import populate_meta, populate_ray_head
 
         cluster = populate_meta({}, "test-cluster", "default", {}, "2.43.0")
         ray_start_params = {}
@@ -891,8 +893,7 @@ def test_populate_ray_head_without_dashboard_host(self):
 
     def test_update_worker_group_replicas_success(self, basic_cluster_dict):
         """Test successfully updating worker group replicas."""
-        from nemo_run.core.execution.kuberay import \
-            update_worker_group_replicas
+        from nemo_run.core.execution.kuberay import update_worker_group_replicas
 
         cluster, success = update_worker_group_replicas(
             basic_cluster_dict, "workers", max_replicas=5, min_replicas=1, replicas=3
@@ -906,8 +907,7 @@ def test_update_worker_group_replicas_success(self, basic_cluster_dict):
 
     def test_update_worker_group_replicas_not_found(self, basic_cluster_dict):
         """Test updating non-existent worker group replicas."""
-        from nemo_run.core.execution.kuberay import \
-            update_worker_group_replicas
+        from nemo_run.core.execution.kuberay import update_worker_group_replicas
 
         cluster, success = update_worker_group_replicas(
             basic_cluster_dict, "nonexistent", max_replicas=5, min_replicas=1, replicas=3
@@ -917,8 +917,7 @@ def test_update_worker_group_replicas_not_found(self, basic_cluster_dict):
 
     def test_update_worker_group_resources_success(self, basic_cluster_dict):
         """Test successfully updating worker group resources."""
-        from nemo_run.core.execution.kuberay import \
-            update_worker_group_resources
+        from nemo_run.core.execution.kuberay import update_worker_group_resources
 
         cluster, success = update_worker_group_resources(
             basic_cluster_dict,
@@ -938,8 +937,7 @@ def test_update_worker_group_resources_success(self, basic_cluster_dict):
 
     def test_update_worker_group_resources_all_containers(self, basic_cluster_dict):
         """Test updating resources for all containers in a worker group."""
-        from nemo_run.core.execution.kuberay import \
-            update_worker_group_resources
+        from nemo_run.core.execution.kuberay import update_worker_group_resources
 
         # Add another container to test "all_containers" functionality
         basic_cluster_dict["spec"]["workerGroupSpecs"][0]["template"]["spec"]["containers"].append(
@@ -968,8 +966,7 @@ def test_update_worker_group_resources_all_containers(self, basic_cluster_dict):
 
     def test_update_worker_group_resources_specific_container(self, basic_cluster_dict):
         """Test updating resources for a specific container."""
-        from nemo_run.core.execution.kuberay import \
-            update_worker_group_resources
+        from nemo_run.core.execution.kuberay import update_worker_group_resources
 
         # Add another container
         basic_cluster_dict["spec"]["workerGroupSpecs"][0]["template"]["spec"]["containers"].append(
@@ -996,8 +993,7 @@ def test_update_worker_group_resources_specific_container(self, basic_cluster_di
 
     def test_update_worker_group_resources_no_containers(self):
         """Test updating resources when worker group has no containers."""
-        from nemo_run.core.execution.kuberay import \
-            update_worker_group_resources
+        from nemo_run.core.execution.kuberay import update_worker_group_resources
 
         cluster = {
             "spec": {
@@ -1067,8 +1063,7 @@ def test_delete_worker_group_not_found(self, basic_cluster_dict):
 
     def test_worker_group_with_labels_and_annotations(self):
         """Test creating worker group with labels and annotations."""
-        from nemo_run.core.execution.kuberay import (populate_meta,
-                                                     populate_worker_group)
+        from nemo_run.core.execution.kuberay import populate_meta, populate_worker_group
 
         cluster = populate_meta({}, "test-cluster", "default", {}, "2.43.0")
         cluster["spec"]["workerGroupSpecs"] = []
@@ -2189,9 +2184,7 @@ def test_kuberay_job_both_configs_fail(self):
 
     def test_executor_load_kube_config_success(self):
         """Test successful loading of kube config for KubeRayExecutor."""
-        with patch(
-            "nemo_run.core.execution.kuberay.config.load_kube_config"
-        ) as mock_load_kube:
+        with patch("nemo_run.core.execution.kuberay.config.load_kube_config") as mock_load_kube:
             with patch("nemo_run.core.execution.kuberay.client.CustomObjectsApi"):
                 with patch("nemo_run.core.execution.kuberay.client.CoreV1Api"):
                     executor = KubeRayExecutor(namespace="test-namespace")
@@ -2234,15 +2227,3 @@ def test_executor_both_configs_fail(self):
 
                 # Should raise the original kube config error
                 assert exc_info.value == kube_config_error
-            ):
-                with pytest.raises(Exception) as exc_info:
-                    KubeRayExecutor(namespace="test-namespace")
-
-                # Should raise the original kube config error
-                assert exc_info.value == kube_config_error
-            ):
-                with pytest.raises(Exception) as exc_info:
-                    KubeRayExecutor(namespace="test-namespace")
-
-                # Should raise the original kube config error
-                assert exc_info.value == kube_config_error