Skip to content

Conversation

@galagam
Copy link
Collaborator

@galagam galagam commented Jan 29, 2026

Description

Update to new ModelOpt-quantized models.
This resolves fp8 quantization errors in AD.
Also, attempting to unwaive the BF16 test which fails in CI, and error was not reproduced locally - will check if CI passes with the new BF16 checkpoint.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Summary by CodeRabbit

Release Notes

  • Tests
    • Enabled FP8 quantization testing to validate model performance under new configurations
    • Updated model support with new identifiers and accuracy reference data
    • Enhanced accuracy benchmarks across multiple quantization algorithms (FP8, FP4, BF16)
    • Improved test coverage with updated model paths and performance metrics

✏️ Tip: You can customize this high-level summary in your review settings.

@galagam galagam marked this pull request as draft January 29, 2026 16:55
@galagam galagam marked this pull request as ready for review January 30, 2026 05:13
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 30, 2026

📝 Walkthrough

Walkthrough

The changes add new accuracy reference data for the NVIDIA-Nemotron-3-Super-120B-012726 model to the test suite, update test configurations with new model identifiers and paths, and enable previously skipped tests for this model variant.

Changes

Cohort / File(s) Summary
Accuracy Reference Data
tests/integration/defs/accuracy/references/gsm8k.yaml, tests/integration/defs/accuracy/references/mmlu.yaml
Added new model entry (nvidia/NVIDIA-Nemotron-3-Super-120B-012726) with accuracy metrics (82.363/82.121 for GSM8K; 86.88/86.12 for MMLU) and quantization configurations (FP8 for both quant_algo and kv_cache_quant_algo).
Test Configuration Updates
tests/integration/defs/accuracy/test_llm_api_autodeploy.py
Updated TestNemotronSuperV3 class configuration: changed MODEL_NAME and MODEL_PATH_* constants to reference new NVIDIA-branded identifiers; removed @pytest.mark.skip decorator from FP8 test, enabling it to run.
Test Waiver Updates
tests/integration/test_lists/waives.txt
Removed skip waiver for accuracy/test_llm_api_autodeploy.py::TestNemotronSuperV3::test_bf16, allowing the test to execute.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description explains the purpose (resolving FP8 quantization errors and investigating BF16 test failures) but the 'Test Coverage' section is empty and lacks details about which specific tests validate these changes.
Title check ✅ Passed The title accurately summarizes the main changes: updating SuperV3 checkpoints and accuracy thresholds, which aligns with changes across multiple test configuration and reference files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@galagam galagam changed the title [none][chore] AutoDeploy: Update SuperV3 checkpoints and thresholds [None][chore] AutoDeploy: Update SuperV3 checkpoints and thresholds Jan 30, 2026
@galagam
Copy link
Collaborator Author

galagam commented Jan 30, 2026

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34196 [ run ] triggered by Bot. Commit: 69c1d90

@galagam galagam changed the title [None][chore] AutoDeploy: Update SuperV3 checkpoints and thresholds [None][chore] AutoDeploy Update SuperV3 checkpoints and thresholds Jan 30, 2026
@galagam galagam changed the title [None][chore] AutoDeploy Update SuperV3 checkpoints and thresholds [None][chore] AutoDeploy update SuperV3 checkpoints and accuracy thresholds Jan 30, 2026
@tensorrt-cicd
Copy link
Collaborator

PR_Github #34196 [ run ] completed with state SUCCESS. Commit: 69c1d90
/LLM/main/L0_MergeRequest_PR pipeline #26386 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@galagam galagam force-pushed the gagam/update-super-checkpoint branch from 69c1d90 to 70cc6ec Compare January 30, 2026 10:57
@galagam
Copy link
Collaborator Author

galagam commented Jan 30, 2026

/bot run --extra-stage "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34217 [ run ] triggered by Bot. Commit: 70cc6ec

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34217 [ run ] completed with state DISABLED
CI server is currently disabled for scheduled maintenance. Estimated completion time: 7 AM PST on 1/30.

@galagam
Copy link
Collaborator Author

galagam commented Jan 30, 2026

/bot run --extra-stage "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34229 [ run ] triggered by Bot. Commit: 70cc6ec

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34229 [ run ] completed with state DISABLED
CI server is currently disabled for scheduled maintenance. Estimated completion time: 8 AM PST on 1/30.

@galagam
Copy link
Collaborator Author

galagam commented Jan 30, 2026

/bot run --extra-stage "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1"

@galagam
Copy link
Collaborator Author

galagam commented Jan 30, 2026

/bot kill

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34237 [ kill ] triggered by Bot. Commit: 70cc6ec

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34237 [ kill ] completed with state SUCCESS. Commit: 70cc6ec
Successfully killed previous jobs for commit 70cc6ec

@galagam
Copy link
Collaborator Author

galagam commented Jan 30, 2026

/bot run --extra-stage "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34241 [ run ] triggered by Bot. Commit: 70cc6ec

Copy link
Collaborator

@govind-ramnarayan govind-ramnarayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34241 [ run ] completed with state SUCCESS. Commit: 70cc6ec
/LLM/main/L0_MergeRequest_PR pipeline #26410 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants