Deprecate apex.contrib.fmha and apex.contrib.multihead_attn #1932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crcrpar
reviewed
Sep 22, 2025
Collaborator
crcrpar
left a comment
crcrpar
left a comment
There was a problem hiding this comment.
Generally this deprecation looks good to me though was there some discussion or something while I'm virtually on vacation in the last weeks?
crcrpar
reviewed
Oct 27, 2025
Comment on lines
+36
to
+41
| from apex import deprecated_warning | ||
| deprecated_warning( | ||
| "`apex.contrib.fmha` is deprecated and will be removed in March 2026. " | ||
| "We encourage you to migrate to PyTorch native MultiheadAttention" | ||
| "The documentation is available in https://docs.pytorch.org/docs/main/generated/torch.nn.MultiheadAttention.html" | ||
| ) |
Collaborator
There was a problem hiding this comment.
@Aidyn-A shouldn't we propose F.scaled_dot_product_attention instead? as this is torch.autograd.Function
or, have this warning in custom nn.Module.__init__
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @crcrpar @eqy