Adding support for hostpath on NIMService

Signed-off-by: Vishesh Tanksale <[email protected]>

Author: visheshtanksale

api/apps/v1alpha1/nimservice_types.go

@@ -728,6 +728,17 @@ func (n *NIMService) GetVolumes(modelPVC *PersistentVolumeClaim) []corev1.Volume
 				},
 			},
 		})
+	} else if n.Spec.Storage.HostPath != nil && *n.Spec.Storage.HostPath != "" {
+		hostPathType := corev1.HostPathDirectoryOrCreate
+		volumes = append(volumes, corev1.Volume{
+			Name: "model-store",
+			VolumeSource: corev1.VolumeSource{
+				HostPath: &corev1.HostPathVolumeSource{
+					Path: *n.Spec.Storage.HostPath,
+					Type: &hostPathType,
+				},
+			},
+		})
 	}
 
 	if n.GetProxyCertConfigMap() != "" {

internal/controller/platform/kserve/nimservice.go

@@ -342,9 +342,11 @@ func (r *NIMServiceReconciler) renderAndSyncCache(ctx context.Context,
 		modelPVC = &nimService.Spec.Storage.PVC
 	} else if nimService.Spec.Storage.EmptyDir != nil {
 		modelPVC = nil
+	} else if nimService.Spec.Storage.HostPath != nil && *nimService.Spec.Storage.HostPath != "" {
+		modelPVC = nil
 	} else {
-		err := fmt.Errorf("neither external PVC name or NIMCache volume is provided")
-		logger.Error(err, "failed to determine PVC for model-store")
+		err := fmt.Errorf("neither external PVC name, NIMCache volume, empty dir or local host path should be provided")
+		logger.Error(err, "failed to determine PVC , NIMCache volume, empty dir or local host path for model-store")
 		return nil, "", nil, err
 	}
 

internal/controller/platform/standalone/nimservice.go

@@ -372,9 +372,11 @@ func (r *NIMServiceReconciler) reconcileNIMService(ctx context.Context, nimServi
 		modelPVC = &nimService.Spec.Storage.PVC
 	} else if nimService.Spec.Storage.EmptyDir != nil {
 		modelPVC = nil
+	} else if nimService.Spec.Storage.HostPath != nil && *nimService.Spec.Storage.HostPath != "" {
+		modelPVC = nil
 	} else {
-		err = fmt.Errorf("neither external PVC name, NIMCache volume or empty dir is provided")
-		logger.Error(err, "failed to determine PVC , NIMCache volume or empty dir for model-store")
+		err = fmt.Errorf("neither external PVC name, NIMCache volume, empty dir or local host path should be provided")
+		logger.Error(err, "failed to determine PVC , NIMCache volume, empty dir or local host path for model-store")
 		return ctrl.Result{}, err
 	}