Skip to content

Commit 4320e84

Browse files
Added extra awaits
1 parent d259465 commit 4320e84

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

playwright/pageobjects/web-reader.page.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,6 @@ class HtmlReaderPage extends WebReaderPage {
136136

137137
async scrollDown(): Promise<void> {
138138
await this.tocButton.click();
139-
//await expect(this.tocButton).toBeVisible();
140139
await this.chapterName.click();
141140
await expect(await this.tocButton.getAttribute('aria-expanded')).toBe(
142141
'false'
@@ -183,11 +182,13 @@ class PdfReaderPage extends WebReaderPage {
183182
}
184183

185184
async scrollDown(): Promise<void> {
185+
await expect(this.pageTwo).toBeVisible();
186186
await this.pageTwo.scrollIntoViewIfNeeded();
187187
}
188188

189189
async scrollUp(): Promise<void> {
190190
await this.scrollDown();
191+
await expect(this.pageOne).toBeVisible();
191192
await this.pageOne.scrollIntoViewIfNeeded();
192193
}
193194
}

playwright/tests/html-reader-settings.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,9 @@ test.describe('Test HTML pub', () => {
100100
await htmlReaderPage.chapterName.click();
101101
await htmlReaderPage.settingsButton.click();
102102
await htmlReaderPage.scrollingStyle.click();
103-
await expect(htmlReaderPage.chapterName).toBeVisible();
103+
await expect(htmlReaderPage.chapterHeading).toBeVisible();
104104
await htmlReaderPage.paginatedStyle.click();
105-
await expect(htmlReaderPage.chapterName).toBeVisible();
105+
await expect(htmlReaderPage.chapterHeading).toBeVisible();
106106
});
107107

108108
test('Maintain changed settings when exit and reenter reader', async ({

playwright/tests/pdf-reader-settings.spec.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ test.describe('Test PDF pub', () => {
55
test('Confirm reader settings are visible', async ({ page }) => {
66
const pdfReaderPage = new PdfReaderPage(page);
77
await pdfReaderPage.loadPage('/pdf/collection');
8+
await expect(pdfReaderPage.settingsButton).toBeVisible();
89
await expect(pdfReaderPage.fullScreenButton).toBeVisible();
910
await pdfReaderPage.settingsButton.click();
1011
await expect(pdfReaderPage.zoomInButton).toBeVisible();
@@ -35,8 +36,10 @@ test.describe('Test PDF pub', () => {
3536
await pdfReaderPage.settingsButton.click();
3637
await pdfReaderPage.scrollingStyle.click();
3738
await expect(pdfReaderPage.scrollingStyle).toBeChecked();
39+
await pdfReaderPage.settingsButton.click();
3840
await pdfReaderPage.scrollDown();
3941
await pdfReaderPage.scrollUp();
42+
await pdfReaderPage.settingsButton.click();
4043
await pdfReaderPage.paginatedStyle.click();
4144
await expect(pdfReaderPage.paginatedStyle).toBeChecked();
4245
});
@@ -56,6 +59,7 @@ test.describe('Test PDF pub', () => {
5659
test('Open and exit full screen', async ({ page }) => {
5760
const pdfReaderPage = new PdfReaderPage(page);
5861
await pdfReaderPage.loadPage('/pdf/collection');
62+
await expect(pdfReaderPage.fullScreenButton).toBeVisible();
5963
await pdfReaderPage.fullScreenButton.click();
6064
await pdfReaderPage.exitFullScreenButton.click();
6165
await expect(pdfReaderPage.fullScreenButton).toBeVisible();

0 commit comments

Comments
 (0)