pass a User to CreateAnystackLicenseJob and update tests

Author: steven-fox

app/Jobs/CreateAnystackLicenseJob.php

@@ -3,6 +3,7 @@
 namespace App\Jobs;
 
 use App\Enums\Subscription;
+use App\Models\User;
 use App\Notifications\LicenseKeyGenerated;
 use Illuminate\Bus\Queueable;
 use Illuminate\Contracts\Queue\ShouldQueue;
@@ -12,41 +13,44 @@
 use Illuminate\Queue\SerializesModels;
 use Illuminate\Support\Facades\Cache;
 use Illuminate\Support\Facades\Http;
-use Illuminate\Support\Facades\Notification;
 
 class CreateAnystackLicenseJob implements ShouldQueue
 {
     use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
 
     public function __construct(
-        public string $email,
+        public User $user,
         public Subscription $subscription,
         public ?string $firstName = null,
         public ?string $lastName = null,
     ) {}
 
     public function handle(): void
     {
-        $contact = $this->createContact();
+        if (! $this->user->anystack_contact_id) {
+            $contact = $this->createContact();
 
-        $license = $this->createLicense($contact['id']);
+            $this->user->anystack_contact_id = $contact['id'];
+            $this->user->save();
+        }
 
-        Cache::put($this->email.'.license_key', $license['key'], now()->addDay());
+        $license = $this->createLicense($this->user->anystack_contact_id);
 
-        Notification::route('mail', $this->email)
-            ->notify(new LicenseKeyGenerated(
-                $license['key'],
-                $this->subscription,
-                $this->firstName
-            ));
+        Cache::put($this->user->email.'.license_key', $license['key'], now()->addDay());
+
+        $this->user->notify(new LicenseKeyGenerated(
+            $license['key'],
+            $this->subscription,
+            $this->firstName
+        ));
     }
 
     private function createContact(): array
     {
         $data = collect([
             'first_name' => $this->firstName,
             'last_name' => $this->lastName,
-            'email' => $this->email,
+            'email' => $this->user->email,
         ])
             ->filter()
             ->all();

app/Jobs/CreateUserFromStripeCustomer.php

@@ -10,6 +10,7 @@
 use Illuminate\Queue\SerializesModels;
 use Illuminate\Support\Facades\Hash;
 use Illuminate\Support\Facades\Log;
+use Illuminate\Support\Facades\Validator;
 use Illuminate\Support\Str;
 use Laravel\Cashier\Cashier;
 use Stripe\Customer;
@@ -39,6 +40,10 @@ public function handle(): void
             return;
         }
 
+        Validator::validate(['email' => $this->customer->email], [
+            'email' => 'required|email|max:255',
+        ]);
+
         $user = new User;
         $user->name = $this->customer->name;
         $user->email = $this->customer->email;

app/Jobs/HandleCustomerSubscriptionCreatedJob.php

@@ -2,6 +2,7 @@
 
 namespace App\Jobs;
 
+use App\Models\User;
 use Illuminate\Bus\Queueable;
 use Illuminate\Contracts\Queue\ShouldQueue;
 use Illuminate\Foundation\Bus\Dispatchable;
@@ -27,9 +28,10 @@ public function handle(): void
             return;
         }
 
+        /** @var User $user */
         $user = Cashier::findBillable($stripeSubscription->customer);
 
-        if (! $user || ! ($email = $user->email)) {
+        if (! $user || ! $user->email) {
             $this->fail('Failed to find user from Stripe subscription customer.');
 
             return;
@@ -42,7 +44,7 @@ public function handle(): void
         $lastName = $nameParts[1] ?? null;
 
         dispatch(new CreateAnystackLicenseJob(
-            $email,
+            $user,
             $subscriptionPlan,
             $firstName,
             $lastName,

tests/Feature/Jobs/CreateAnystackLicenseJobTest.php

@@ -4,6 +4,7 @@
 
 use App\Enums\Subscription;
 use App\Jobs\CreateAnystackLicenseJob;
+use App\Models\User;
 use App\Notifications\LicenseKeyGenerated;
 use Illuminate\Foundation\Testing\RefreshDatabase;
 use Illuminate\Support\Facades\Cache;
@@ -45,8 +46,13 @@ protected function setUp(): void
     /** @test */
     public function it_creates_contact_and_license_on_anystack()
     {
+        $user = User::factory()->create([
+            'email' => '[email protected]',
+            'name' => 'John Doe',
+        ]);
+
         $job = new CreateAnystackLicenseJob(
-            '[email protected]',
+            $user,
             Subscription::Max,
             'John',
             'Doe'
@@ -79,8 +85,13 @@ public function it_creates_contact_and_license_on_anystack()
     /** @test */
     public function it_stores_license_key_in_cache()
     {
+        $user = User::factory()->create([
+            'email' => '[email protected]',
+            'name' => 'John Doe',
+        ]);
+
         $job = new CreateAnystackLicenseJob(
-            '[email protected]',
+            $user,
             Subscription::Max,
             'John',
             'Doe'
@@ -94,20 +105,24 @@ public function it_stores_license_key_in_cache()
     /** @test */
     public function it_sends_license_key_notification()
     {
+        $user = User::factory()->create([
+            'email' => '[email protected]',
+            'name' => 'John Doe',
+        ]);
+
         $job = new CreateAnystackLicenseJob(
-            '[email protected]',
+            $user,
             Subscription::Max,
             'John',
             'Doe'
         );
 
         $job->handle();
 
-        Notification::assertSentOnDemand(
-            LicenseKeyGenerated::class,
+        Notification::assertSentTo(
+            $user,
             function (LicenseKeyGenerated $notification, array $channels, object $notifiable) {
-                return $notifiable->routes['mail'] === '[email protected]' &&
-                        $notification->licenseKey === 'test-license-key-12345' &&
+                return $notification->licenseKey === 'test-license-key-12345' &&
                         $notification->subscription === Subscription::Max &&
                         $notification->firstName === 'John';
             }
@@ -117,9 +132,14 @@ function (LicenseKeyGenerated $notification, array $channels, object $notifiable
     /** @test */
     public function it_handles_missing_name_components()
     {
+        $user = User::factory()->create([
+            'email' => '[email protected]',
+            'name' => null,
+        ]);
+
         // Create and run the job with missing name components
         $job = new CreateAnystackLicenseJob(
-            '[email protected]',
+            $user,
             Subscription::Max,
         );
 
@@ -135,11 +155,10 @@ public function it_handles_missing_name_components()
         });
 
         // Assert notification was sent with null firstName
-        Notification::assertSentOnDemand(
-            LicenseKeyGenerated::class,
+        Notification::assertSentTo(
+            $user,
             function (LicenseKeyGenerated $notification, array $channels, object $notifiable) {
-                return $notifiable->routes['mail'] === '[email protected]' &&
-                       $notification->licenseKey === 'test-license-key-12345' &&
+                return $notification->licenseKey === 'test-license-key-12345' &&
                        $notification->subscription === Subscription::Max &&
                        $notification->firstName === null;
             }

tests/Feature/Jobs/CreateUserFromStripeCustomerTest.php

@@ -6,6 +6,7 @@
 use App\Models\User;
 use Illuminate\Foundation\Testing\RefreshDatabase;
 use Illuminate\Support\Facades\Hash;
+use Illuminate\Validation\ValidationException;
 use Stripe\Customer;
 use Tests\TestCase;
 
@@ -96,4 +97,22 @@ public function it_handles_a_null_name_in_stripe_customer()
             'stripe_id' => 'cus_noname123',
         ]);
     }
+
+    /** @test */
+    public function it_fails_when_customer_has_no_email()
+    {
+        $customer = Customer::constructFrom([
+            'id' => 'cus_noemail123',
+            'name' => 'No Email',
+            'email' => '',
+        ]);
+
+        $job = new CreateUserFromStripeCustomer($customer);
+
+        $this->expectException(ValidationException::class);
+
+        $job->handle();
+
+        $this->assertDatabaseCount('users', 0);
+    }
 }

tests/Feature/Jobs/HandleCustomerSubscriptionCreatedJobTest.php

@@ -6,6 +6,7 @@
 use App\Jobs\CreateAnystackLicenseJob;
 use App\Jobs\CreateUserFromStripeCustomer;
 use App\Jobs\HandleCustomerSubscriptionCreatedJob;
+use App\Models\User;
 use Illuminate\Foundation\Testing\RefreshDatabase;
 use Illuminate\Support\Facades\Bus;
 use Laravel\Cashier\Events\WebhookHandled;
@@ -38,7 +39,8 @@ public function it_dispatches_the_create_anystack_license_job_with_correct_data(
         $job->handle();
 
         Bus::assertDispatched(CreateAnystackLicenseJob::class, function (CreateAnystackLicenseJob $job) {
-            return $job->email === '[email protected]' &&
+            return $job->user instanceof User &&
+                   $job->user->email === '[email protected]' &&
                    $job->subscription === Subscription::Max &&
                    $job->firstName === 'John' &&
                    $job->lastName === 'Doe';
@@ -99,7 +101,11 @@ public function it_fails_when_customer_has_no_email()
 
         $this->mockStripeClient($mockCustomer);
 
-        dispatch_sync(new CreateUserFromStripeCustomer($mockCustomer));
+        User::factory()->create([
+            'stripe_id' => 'cus_S9dhoV2rJK2Auy',
+            'name' => 'John Doe',
+            'email' => '',
+        ]);
 
         Bus::fake();
 

tests/Feature/Livewire/OrderSuccessTest.php

@@ -153,6 +153,8 @@ public function allLineItems()
             }
         };
 
-        $this->app->instance(StripeClient::class, $mockStripeClient);
+        $this->app->bind(StripeClient::class, function ($app, $parameters) use ($mockStripeClient) {
+            return $mockStripeClient;
+        });
     }
 }

tests/Feature/StripePurchaseHandlingTest.php

@@ -92,8 +92,8 @@ public function a_license_is_created_when_a_stripe_subscription_is_created()
 
         $this->postJson('/stripe/webhook', $payload);
 
-        Bus::assertDispatched(CreateAnystackLicenseJob::class, function ($job) {
-            return $job->email === '[email protected]' &&
+        Bus::assertDispatched(CreateAnystackLicenseJob::class, function (CreateAnystackLicenseJob $job) {
+            return $job->user->email === '[email protected]' &&
                    $job->subscription === Subscription::Max &&
                    $job->firstName === 'John' &&
                    $job->lastName === 'Doe';