Skip to content

Commit cd0f6a7

Browse files
author
Mihail Slavchev
committed
update binding-generator project to produce *.jar instead of *.aar
1 parent 429d0a3 commit cd0f6a7

File tree

7 files changed

+20
-34
lines changed

7 files changed

+20
-34
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ before_install:
3535
- export ANDROID_NDK_HOME=`pwd`/android-ndk-$NDK_VERSION
3636
- export PATH=${PATH}:${ANDROID_NDK_HOME}
3737
script:
38-
- "./gradlew createPackage -i -PpreReleaseVersion=$PACKAGE_VERSION -PgitCommitVersion=$TRAVIS_COMMIT --stacktrace"
38+
- "./gradlew createPackage -i -PpreReleaseVersion=$PACKAGE_VERSION -PgitCommitVersion=$TRAVIS_COMMIT -PembedBindingGenerator=true --stacktrace"
3939
- echo no | android create avd --force -n Arm21 -t android-21 -b armeabi-v7a -c 12M
4040
- emulator -avd Arm21 -no-skin -no-audio -no-window &
4141
- android-wait-for-emulator

binding-generator/build.gradle

Lines changed: 7 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,11 @@
1-
apply plugin: 'com.android.model.library'
2-
3-
model {
4-
android {
5-
compileSdkVersion = 23
6-
buildToolsVersion = "23.0.3"
7-
8-
defaultConfig.with {
9-
minSdkVersion.apiLevel = 17
10-
targetSdkVersion.apiLevel = 22
11-
}
12-
13-
lintOptions.with {
14-
abortOnError = false
15-
}
16-
17-
}
18-
}
1+
apply plugin: 'java'
192

203
dependencies {
214
compile fileTree(dir: 'libs', include: ['*.jar'])
5+
6+
sourceCompatibility = 1.7
7+
targetCompatibility = 1.7
228
}
9+
10+
jar {
11+
}

binding-generator/src/main/java/com/tns/bindings/Dump.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
import org.ow2.asmdex.*;
66
import org.ow2.asmdex.structureCommon.*;
77

8-
import android.util.Log;
9-
108
import com.tns.bindings.desc.ClassDescriptor;
119
import com.tns.bindings.desc.Descriptor;
1210
import com.tns.bindings.desc.MethodDescriptor;
@@ -609,7 +607,7 @@ private void generateHashCodeSuper(ClassVisitor cv)
609607
private void generateMethod(ClassVisitor cv, ClassDescriptor classTo, MethodDescriptor method, int methodNumber, String classSignature, String tnsClassSignature, int fieldBit)
610608
{
611609
if (ProxyGenerator.IsLogEnabled) {
612-
Log.d("Generator", "generatingMethod " + method.getName());
610+
System.out.println("Generator: generatingMethod " + method.getName());
613611
}
614612

615613
//TODO: handle checked exceptions

binding-generator/src/main/java/com/tns/bindings/ProxyGenerator.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77

88
import org.ow2.asmdex.ApplicationWriter;
99

10-
import android.util.Log;
11-
1210
import com.tns.bindings.desc.ClassDescriptor;
1311

1412
public class ProxyGenerator
@@ -70,7 +68,7 @@ public String generateProxy(String proxyName, ClassDescriptor classToProxy, Hash
7068
proxyFileName += "-" + proxyThumb;
7169
}
7270

73-
if (IsLogEnabled) Log.d("Generator", "Saving proxy with file name: " + proxyFileName);
71+
if (IsLogEnabled) System.out.println("Generator: Saving proxy with file name: " + proxyFileName);
7472
String proxyPath = saveProxy(proxyFileName, generatedBytes);
7573

7674
return proxyPath;

build-artifacts/project-template-gradle/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,6 @@ dependencies {
197197
// builtBy 'copyAarDependencies'
198198
// }
199199

200-
compile project(':binding-generator')
201200
compile project(':runtime')
202201
}
203202

build-artifacts/project-template-gradle/settings.gradle

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,4 @@ include "asbg"
33
project(":asbg").projectDir = file("build-tools/android-static-binding-generator")
44

55
include "runtime"
6-
project(":runtime").projectDir = file("build-tools/runtime-modules/runtime")
7-
8-
9-
include "binding-generator"
10-
project(":binding-generator").projectDir = file("build-tools/runtime-modules/binding-generator")
6+
project(":runtime").projectDir = file("build-tools/runtime-modules/runtime")

runtime/build.gradle

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -173,8 +173,14 @@ model {
173173
}
174174
}
175175

176-
dependencies {
177-
compile project(':binding-generator')
176+
if (project.hasProperty("embedBindingGenerator")) {
177+
dependencies {
178+
compile fileTree(dir: (project(':binding-generator').buildDir.toString() + "/libs"), include: ['*.jar'])
179+
}
180+
} else {
181+
dependencies {
182+
compile project(':binding-generator')
183+
}
178184
}
179185

180186
task setPackageVersion {
@@ -225,4 +231,4 @@ task revertVersionFile(type: Exec) {
225231
commandLine "git", "checkout", "--", versionFilePath
226232
}
227233
}
228-
}
234+
}

0 commit comments

Comments
 (0)