Merge pull request #973 from NativeScript/pete/prepare-release

Merge "master" into "release"

Author: petekanev

.github/ISSUE_TEMPLATE.md

@@ -2,7 +2,7 @@
 
 ## Please, provide the details below:
 
-### Did you verify this is a real problem by searching [Stack Overflow](http://stackoverflow.com/questions/tagged/nativescript) and the [other open issues in this repo](https://github.com/NativeScript/nativescript/issues)?
+### Did you verify this is a real problem by searching the [NativeScript Forum](http://forum.nativescript.org) and the [other open issues in this repo](https://github.com/NativeScript/nativescript/issues)?
 
 ### Tell us about the problem
 <!--Please, ensure your title is less than 63 characters long and starts with a capital
@@ -40,4 +40,5 @@ Please provide us with the log by following these steps:
 <!--
 Please provide us with the necessary information to reproduce your problem. That includes but is not limited to presenting us with steps to reproduce the problem, or a small repo example.
 -->
+Consider using the [playground](https://play.nativescript.org) to provide the code you have issues with.
 

.gitmodules

@@ -4,3 +4,7 @@
 [submodule "test-app/app/src/main/assets/app/shared"]
 	path = test-app/app/src/main/assets/app/shared
 	url = https://github.com/NativeScript/common-runtime-tests-app.git
+[submodule "test-app/build-tools/android-dts-generator"]
+	path = test-app/build-tools/android-dts-generator
+	url = https://github.com/NativeScript/android-dts-generator.git
+	branch = master

.travis.yml

@@ -10,22 +10,6 @@ env:
 
 matrix:
   include:
-    - stage: "Static Binding Generator Parser Tests"
-      language: node_js 
-      node_js: "6"
-      git:
-        submodules: false
-      script:
-        - cd android-static-binding-generator
-        - npm install && node run-tests
-        - cd ..
-    - stage: "Static Binding Generator Class Generator Tests"
-      language: android
-      jdk: oraclejdk8
-      git:
-        submodules: false
-      script:
-        - "android-static-binding-generator/project/staticbindinggenerator/gradlew test --project-dir android-static-binding-generator/project/staticbindinggenerator/"    
     - stage: "Build and Tests"
       sudo: true
       language: android
@@ -41,15 +25,13 @@ matrix:
         submodules: false
       script:
         # (master branch) build the runtime twice - optimized, and regular packages, skip on PRs
-        # test-app/gradlew runtest will take care of building the runtime for its testing needs
+        # test-app/gradlew runtests will take care of building the runtime for its testing needs
         - 'if [ "$TRAVIS_PULL_REQUEST" = "false" ]; then bash ./gradlew -PpreReleaseVersion=$PACKAGE_VERSION -PgitCommitVersion=$TRAVIS_COMMIT --stacktrace; fi'
         - echo no | android create avd --force -n $EMULATOR_NAME-$EMULATOR_API_LEVEL -t android-$EMULATOR_API_LEVEL --abi $ANDROID_ABI -c 12M
         - emulator -avd $EMULATOR_NAME-$EMULATOR_API_LEVEL -no-skin -no-audio -no-window &
         - android-wait-for-emulator
-        - cd test-app 
         - "./gradlew runtest --stacktrace"
         - adb -e logcat -d 300
-        - cd ..
       before_install:
         - echo "y" | sdkmanager "cmake;3.6.4111459"
         - sed -i 's/[email protected]:/https:\/\/github.com\//' .gitmodules

CHANGELOG.md

@@ -1,3 +1,22 @@
+4.0.0-rc
+==
+
+## Breaking Changes
+
+ - [Rewrite the build script routine to no longer use flavors as the primary mechanism to apply nativescript plugin Android configurations (#890)](https://github.com/NativeScript/android-runtime/issues/890) - **If you see the `All flavors must now belong to a named flavor dimension.` build error, ensure that you are using the latest CLI. Plugins will be built implicitly by the CLI, version 4.0.0-rc or newer.**
+ - [Application package outputs are now located at `platforms/android/app/build/outputs/<build-type>/<flavor - if any>/app-<build-type>.apk` (#938)](https://github.com/NativeScript/android-runtime/issues/938)
+
+## What's New
+
+ - [Respect `.jar` and `.aar` libraries from `App_Resources/Android/libs` (#899)](https://github.com/NativeScript/android-runtime/issues/899)
+ - [Add user-defined Android project files - `.java`, resources, assets in `App_Resources/Android` (#700)](https://github.com/NativeScript/android-runtime/issues/700) - **Enabled after updating the App_Resources/Android subdirectory structure. Use `tns resources update android` with CLI 4.0.0-rc or newer.**
+ - [Console API improvements - file name, line, column support in Chrome DevTools; Objects are expanded to JSON representations (#894) (#884)](https://github.com/NativeScript/android-runtime/pull/894) - **Replaces the console API in the `tns-core-modules`.**
+ - [Update Gradle to 4.1 and Android plugin for Gradle to 3.0.1 (#938)](https://github.com/NativeScript/android-runtime/issues/938)
+
+## Bug Fixes
+
+ - [fix: static binding generator creating wrong files, when two extended classes have the same name (#692)](https://github.com/NativeScript/android-runtime/issues/692)
+
 3.4.2
 ==
 

CODE_OF_CONDUCT.md

@@ -0,0 +1,83 @@
+# NativeScript Community Code of Conduct
+
+Our community members come from all walks of life and are all at different stages of their personal and professional journeys. To support everyone, we've prepared a short code of conduct. Our mission is best served in an environment that is friendly, safe, and accepting; free from intimidation or harassment.
+
+Towards this end, certain behaviors and practices will not be tolerated.
+
+## tl;dr
+
+- Be respectful. 
+- We're here to help.
+- Abusive behavior is never tolerated. 
+- Violations of this code may result in swift and permanent expulsion from the NativeScript community channels. 
+
+## Administrators
+
+- Dan Wilson (@DanWilson on Slack)
+- Jen Looper (@jen.looper on Slack)
+- TJ VanToll (@tjvantoll on Slack)
+
+## Scope
+
+We expect all members of the NativeScript community, including administrators, users, facilitators, and vendors to abide by this Code of Conduct at all times in our community venues, online and in person, and in one-on-one communications pertaining to NativeScript affairs.
+
+This policy covers the usage of the NativeScript Slack community, as well as the NativeScript support forums, NativeScript GitHub repositories, the NativeScript website, and any NativeScript-related events. This Code of Conduct is in addition to, and does not in any way nullify or invalidate, any other terms or conditions related to use of NativeScript.
+
+The definitions of various subjective terms such as "discriminatory", "hateful", or "confusing" will be decided at the sole discretion of the NativeScript administrators.
+
+## Friendly, Harassment-Free Space
+
+We are committed to providing a friendly, safe, and welcoming environment for all, regardless of gender identity, sexual orientation, disability, ethnicity, religion, age, physical appearance, body size, race, or similar personal characteristics.
+
+We ask that you please respect that people have differences of opinion regarding technical choices, and acknowledge that every design or implementation choice carries a trade-off and numerous costs. There is seldom a single right answer. A difference of technology preferences is never a license to be rude.
+
+Any spamming, trolling, flaming, baiting, or other attention-stealing behaviour is not welcome, and will not be tolerated.
+
+Harassing other users of NativeScript is never tolerated, whether via public or private media.
+
+Avoid using offensive or harassing package names, nicknames, or other identifiers that might detract from a friendly, safe, and welcoming environment for all.
+
+Harassment includes, but is not limited to: harmful or prejudicial verbal or written comments related to gender identity, sexual orientation, disability, ethnicity, religion, age, physical appearance, body size, race, or similar personal characteristics; inappropriate use of nudity, sexual images, and/or sexually explicit language in public spaces; threats of physical or non-physical harm; deliberate intimidation, stalking or following; harassing photography or recording; sustained disruption of talks or other events; inappropriate physical contact; and unwelcome sexual attention.
+
+## Acceptable Content
+
+The NativeScript administrators reserve the right to make judgement calls about what is and isn't appropriate in published content. These are guidelines to help you be successful in our community.
+
+Content must contain something applicable to the previously stated goals of the NativeScript community. "Spamming", that is, publishing any form of content that is not applicable, is not allowed.
+
+Content must not contain illegal or infringing content. You should only publish content to NativeScript properties if you have the right to do so. This includes complying with all software license agreements or other intellectual property restrictions. For example, redistributing an MIT-licensed module with the copyright notice removed, would not be allowed. You will be responsible for any violation of laws or others’ intellectual property rights.
+
+Content must not be malware. For example, content (code, video, pictures, words, etc.) which is designed to maliciously exploit or damage computer systems, is not allowed.
+
+Content name, description, and other visible metadata must not include abusive, inappropriate, or harassing content.
+
+## Reporting Violations of this Code of Conduct
+
+If you believe someone is harassing you or has otherwise violated this Code of Conduct, please contact the administrators and send us an abuse report. If this is the initial report of a problem, please include as much detail as possible. It is easiest for us to address issues when we have more context.
+
+## Consequences
+
+All content published to the NativeScript community channels is hosted at the sole discretion of the NativeScript administrators.
+
+Unacceptable behavior from any community member, including sponsors, employees, customers, or others with decision-making authority, will not be tolerated.
+
+Anyone asked to stop unacceptable behavior is expected to comply immediately.
+
+If a community member engages in unacceptable behavior, the NativeScript administrators may take any action they deem appropriate, up to and including a temporary ban or permanent expulsion from the community without warning (and without refund in the case of a paid event or service).
+
+## Addressing Grievances
+
+If you feel you have been falsely or unfairly accused of violating this Code of Conduct, you should notify the administrators. We will do our best to ensure that your grievance is handled appropriately.
+
+In general, we will choose the course of action that we judge as being most in the interest of fostering a safe and friendly community.
+
+## Contact Info
+Please contact Dan Wilson @DanWilson if you need to report a problem or address a grievance related to an abuse report.
+
+You are also encouraged to contact us if you are curious about something that might be "on the line" between appropriate and inappropriate content. We are happy to provide guidance to help you be a successful part of our community.
+
+## Credit and License
+
+This Code of Conduct borrows heavily from the WADE Code of Conduct, which is derived from the NodeBots Code of Conduct, which in turn borrows from the npm Code of Conduct, which was derived from the Stumptown Syndicate Citizen's Code of Conduct, and the Rust Project Code of Conduct.
+
+This document may be reused under a Creative Commons Attribution-ShareAlike License.

LICENSE

@@ -186,7 +186,7 @@ Apache License
       same "printed page" as the copyright notice for easier
       identification within third-party archives.
 
-   Copyright (c) 2015-2016 Telerik AD
+   Copyright (c) 2015-2018 Telerik AD
 
    Licensed under the Apache License, Version 2.0 (the "License");
    you may not use this file except in compliance with the License.
@@ -198,4 +198,4 @@ Apache License
    distributed under the License is distributed on an "AS IS" BASIS,
    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    See the License for the specific language governing permissions and
-   limitations under the License.
+   limitations under the License.

README.md

@@ -1,22 +1,42 @@
+# Android Runtime for NativeScript
 [![Build Status](https://travis-ci.org/NativeScript/android-runtime.svg?branch=master)](https://travis-ci.org/NativeScript/android-runtime)
+[![Waffle.io - NativeScript Android Runtime](https://badge.waffle.io/NativeScript/android-runtime.svg?columns=In%20Progress)](https://waffle.io/NativeScript/android-runtime)
 
-# Android-Runtime
-Contains the source code for the NativeScript's Android runtime. The android-runtime is a main component used in [NativeScript](https://www.nativescript.org/).
+Contains the source code for the NativeScript's Android Runtime. [NativeScript](https://www.nativescript.org/) is a framework which enables developers to write truly native mobile applications for Android and iOS using JavaScript and CSS. Each mobile platform has its own ecosystem and offers completely different development tools and language(s) - Java for Android and Objective C (Swift) for iOS. In order to translate JavaScript code to the corresponding native APIs some kind of proxy mechanism is needed. This is exactly what the "Runtime" parts of NativeScript are responsible for. The Android Runtime may be thought of as "The Bridge" between the JavaScript and Android worlds. A NativeScript application for Android is a standard native package (apk) which besides the JavaScript files embed the runtime as well.
 
-# Main Projects
+<!-- TOC depthFrom:2 -->
+
+- [Main Projects](#main-projects)
+- [Helper Projects](#helper-projects)
+- [Architecture Diagram](#architecture-diagram)
+- [Build Prerequisites](#build-prerequisites)
+- [How to build](#how-to-build)
+- [How to run tests](#how-to-run-tests)
+- [Get Help](#get-help)
+
+<!-- /TOC -->
+
+## Main Projects
 The repo is structured in the following projects (ordered by dependencies):
 
 * [**android-metadata-generator**](android-metadata-generator) - generates metadata necessary for the Android Runtime.
 * [**android-binding-generator**](test-app/runtime-binding-generator) - enables Java & Android types to be dynamically created at runtime. Needed by the `extend` routine.
 * [**android-runtime**](test-app/runtime) - contains the core logic behind the NativeScript's Android Runtime. This project contains native C++ code and needs the Android NDK to build properly.
 * [**android-runtime-testapp**](test-app/app) - this is a vanilla Android Application, which contains the tests for the runtime project.
 
-# Helper Projects
+## Helper Projects
 
 * [**android-static-binding-generator**](android-static-binding-generator) - build tool that generates bindings based on the user's javascript code.
 * [**project-template**](build-artifacts/project-template-gradle) - this is an empty placeholder Android Application project, used by the [NativeScript CLI](https://github.com/NativeScript/nativescript-cli) when building an Android project.
 
-# Build Prerequisites
+## Architecture Diagram
+The NativeScript Android Runtime architecture can be summarized in the following diagram. 
+
+![Android Runtime diagram](https://github.com/NativeScript/docs/blob/master/docs/img/ns-runtime-android.png)
+
+For more details on how it works, read the [documentation](https://docs.nativescript.org/runtimes/android/overview). 
+
+## Build Prerequisites
 Following are the minimal prerequisites to build the runtime package.
 
 * Install the latest [Android Studio ](https://developer.android.com/studio/index.html).
@@ -25,7 +45,7 @@ Following are the minimal prerequisites to build the runtime package.
 * Download Android Support Repository through the Android SDK Manager
 * Download Build Tools 25.0.2 through the Android SDK Manager.
 
-# How to build
+## How to Build
 
 * Run command 
 
@@ -46,7 +66,7 @@ Following are the minimal prerequisites to build the runtime package.
 
   `Note:` To cut the build time in half and package only the optimized (stripped) version of the runtime package comment out 'tasks.generateRuntimeAar.execute()' in the [build.gradle](https://github.com/NativeScript/android-runtime/blob/v3.0.0-rc.1/build.gradle#L114) script.
 
-# How to run tests
+## How to Run Tests
 
 * Go to subfolder test-app after you built the runtime.
 * Start an emulator or connect a device.
@@ -56,3 +76,6 @@ Following are the minimal prerequisites to build the runtime package.
 ```Shell
 gradlew runtest
 ```
+
+## Get Help
+Please, use [github issues](https://github.com/NativeScript/android-runtime/issues) strictly for [reporting bugs](CONTRIBUTING.md#reporting-bugs) or [requesting features](CONTRIBUTING.md#requesting-new-features). For general questions and support, check out the [NativeScript community forum](https://discourse.nativescript.org/) or ask our experts in [NativeScript community Slack channel](http://developer.telerik.com/wp-login.php?action=slack-invitation).