fix: re-enable ngDevMode tree shaking

Author: edusperoni

packages/angular/ng-package.json

@@ -1,5 +1,5 @@
 {
-  "$schema": "../../node_modules/ng-packagr/package.schema.json",
+  "$schema": "../../node_modules/ng-packagr/ng-package.schema.json",
   "assets": [".npmignore"],
   "lib": {
     "entryFile": "src/index.ts"

packages/angular/references.d.ts

@@ -1,2 +1,10 @@
-/* eslint-disable @typescript-eslint/triple-slash-reference */
-/// <reference path="../../references.d.ts" />
+/* eslint-disable */
+/// <reference path="../../references.d.ts" />
+
+declare global {
+  const ngDevMode: boolean;
+}
+
+declare module globalThis {
+  const ngDevMode: boolean;
+}

packages/angular/src/lib/cdk/dialog/dialog-services.ts

@@ -53,7 +53,15 @@ export abstract class _NativeDialogBase<C extends NativeModalRef> implements OnD
     return parent ? parent._getAfterAllClosed() : this._afterAllClosedAtThisLevel;
   }
 
-  constructor(private _injector: Injector, private _defaultOptions: NativeDialogConfig | undefined, private _parentDialog: _NativeDialogBase<C> | undefined, private _dialogRefConstructor: Type<NativeDialogRef<any>>, private _nativeModalType: Type<C>, private _dialogDataToken: InjectionToken<any>, private locationStrategy: NSLocationStrategy) {}
+  constructor(
+    private _injector: Injector,
+    private _defaultOptions: NativeDialogConfig | undefined,
+    private _parentDialog: _NativeDialogBase<C> | undefined,
+    private _dialogRefConstructor: Type<NativeDialogRef<any>>,
+    private _nativeModalType: Type<C>,
+    private _dialogDataToken: InjectionToken<any>,
+    private locationStrategy: NSLocationStrategy,
+  ) {}
 
   /**
    * Opens a modal dialog containing the given component.
@@ -76,7 +84,7 @@ export abstract class _NativeDialogBase<C extends NativeModalRef> implements OnD
   open<T, D = any, R = any>(componentOrTemplateRef: ComponentType<T> | TemplateRef<T>, config?: NativeDialogConfig<D>): NativeDialogRef<T, R> {
     config = _applyConfigDefaults(config, this._defaultOptions || new NativeDialogConfig());
 
-    if (config.id && this.getDialogById(config.id) && (typeof global.ngDevMode === 'undefined' || global.ngDevMode)) {
+    if (config.id && this.getDialogById(config.id) && (typeof ngDevMode === 'undefined' || ngDevMode)) {
       throw Error(`Dialog with id "${config.id}" exists already. The dialog id must be unique.`);
     }
     const dialogRef = this._attachDialogContent<T, R>(componentOrTemplateRef, config);
@@ -141,7 +149,7 @@ export abstract class _NativeDialogBase<C extends NativeModalRef> implements OnD
       //     detachedLoaderRef.instance.createTemplatePortal(options.templateRef);
       nativeModalRef.attachTemplatePortal(
         // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-        new TemplatePortal<T>(componentOrTemplateRef, null!, <any>{ $implicit: config.data, dialogRef })
+        new TemplatePortal<T>(componentOrTemplateRef, null!, <any>{ $implicit: config.data, dialogRef }),
       );
     } else {
       const injector = this._createInjector<T>(config, dialogRef);

packages/angular/src/lib/cdk/portal/common.ts

@@ -20,7 +20,7 @@ export abstract class Portal<T> {
 
   /** Attach this portal to a host. */
   attach(host: PortalOutlet): T {
-    if (typeof global.ngDevMode === 'undefined' || global.ngDevMode) {
+    if (typeof ngDevMode === 'undefined' || ngDevMode) {
       if (host == null) {
         throwNullPortalOutletError();
       }
@@ -41,7 +41,7 @@ export abstract class Portal<T> {
     if (host != null) {
       this._attachedHost = null;
       host.detach();
-    } else if (typeof global.ngDevMode === 'undefined' || global.ngDevMode) {
+    } else if (typeof ngDevMode === 'undefined' || ngDevMode) {
       throwNoPortalAttachedError();
     }
   }
@@ -187,7 +187,7 @@ export abstract class BasePortalOutlet implements PortalOutlet {
 
   /** Attaches a portal. */
   attach(portal: Portal<any>): any {
-    if (typeof global.ngDevMode === 'undefined' || global.ngDevMode) {
+    if (typeof ngDevMode === 'undefined' || ngDevMode) {
       if (!portal) {
         throwNullPortalError();
       }
@@ -213,7 +213,7 @@ export abstract class BasePortalOutlet implements PortalOutlet {
       return this.attachDomPortal(portal);
     }
 
-    if (typeof global.ngDevMode === 'undefined' || global.ngDevMode) {
+    if (typeof ngDevMode === 'undefined' || ngDevMode) {
       throwUnknownPortalTypeError();
     }
   }

packages/angular/src/lib/cdk/portal/nsdom-portal-outlet.ts

@@ -24,7 +24,7 @@ export class NativeScriptDomPortalOutlet extends BasePortalOutlet {
     private _componentFactoryResolver: ComponentFactoryResolver,
     private _appRef: ApplicationRef,
     private _defaultInjector: Injector,
-    @Optional() viewUtil?: ViewUtil
+    @Optional() viewUtil?: ViewUtil,
   ) {
     super();
     this._viewUtil = viewUtil || this._defaultInjector.get(ViewUtil);
@@ -111,7 +111,7 @@ export class NativeScriptDomPortalOutlet extends BasePortalOutlet {
    */
   attachDomPortal = (portal: DomPortal) => {
     const element = portal.element;
-    if (!element.parentNode && (typeof global.ngDevMode === 'undefined' || global.ngDevMode)) {
+    if (!element.parentNode && (typeof ngDevMode === 'undefined' || ngDevMode)) {
       throw Error('DOM portal content must be attached to a parent node.');
     }
 

packages/angular/src/lib/cdk/portal/portal-directives.ts

@@ -52,7 +52,10 @@ export class CdkPortalOutlet extends BasePortalOutlet implements OnInit, OnDestr
   /** Reference to the currently-attached component/view ref. */
   private _attachedRef: CdkPortalOutletAttachedRef;
 
-  constructor(private _viewContainerRef: ViewContainerRef, private renderer: Renderer2) {
+  constructor(
+    private _viewContainerRef: ViewContainerRef,
+    private renderer: Renderer2,
+  ) {
     super();
   }
 
@@ -157,7 +160,7 @@ export class CdkPortalOutlet extends BasePortalOutlet implements OnInit, OnDestr
    */
   attachDomPortal = (portal: DomPortal) => {
     const element = portal.element;
-    if (!element.parentNode && (typeof global.ngDevMode === 'undefined' || global.ngDevMode)) {
+    if (!element.parentNode && (typeof ngDevMode === 'undefined' || ngDevMode)) {
       throw Error('DOM portal content must be attached to a parent node.');
     }
 

packages/angular/src/lib/nativescript-ng-zone.ts

@@ -149,8 +149,10 @@ export class NativeScriptNgZone implements NgZone {
     self.shouldCoalesceRunChangeDetection = shouldCoalesceRunChangeDetection;
     self.lastRequestAnimationFrameId = -1;
     self.nativeRequestAnimationFrame = function (cb) {
-      const nativeDispatchToMainThread = Utils[Zone.__symbol__('dispatchToMainThread')] || Utils.dispatchToMainThread;
-      nativeDispatchToMainThread(cb);
+      // const nativeDispatchToMainThread = Utils[Zone.__symbol__('dispatchToMainThread')] || Utils.dispatchToMainThread;
+      // nativeDispatchToMainThread(cb);
+      const nativeDispatchToMainThread = global[Zone.__symbol__('setTimeout')] || global.setTimeout;
+      nativeDispatchToMainThread(cb, 1000);
       return currentRafId++;
     };
     forkInnerZoneWithAngularBehavior(self);
@@ -377,7 +379,7 @@ function delayChangeDetectionForEvents(zone: NgZonePrivate) {
         },
         undefined,
         () => {},
-        () => {}
+        () => {},
       );
     }
     zone.fakeTopEventTask.invoke();

references.d.ts

@@ -7,7 +7,6 @@ declare namespace NodeJS {
     interface Global {
         __runtimeVersion: any;
         TNS_ENV: string;
-        ngDevMode: unknown | null;
     }
 }