[#10] Fix: Trim URL for unnormalized case

Author: pcfulife

packages/core/src/metrics/util.ts

@@ -49,3 +49,12 @@ export function getStatusCodeGroup(statusCode: number) {
         }
     }
 }
+
+export const trimUrl = (url: string, maxDepth?: number) => {
+    if (typeof maxDepth === 'number') {
+        const withStartingSlashUrl = url.startsWith('/') ? url : '/' + url
+        return withStartingSlashUrl.split('/', maxDepth + 1).join('/')
+    } else {
+        return url
+    }
+}

packages/core/src/next/utils.ts

@@ -3,6 +3,8 @@ import path from 'node:path'
 
 import {glob} from 'glob'
 
+import {trimUrl} from '../metrics/util'
+
 interface RouteInfo {
     page: string
     regex: string
@@ -69,6 +71,6 @@ export function createNextRoutesUrlGroup(maxDepth: number) {
             }
         }
 
-        return typeof maxDepth === 'number' ? withoutBasePathUrl.split('/', maxDepth + 1).join('/') : withoutBasePathUrl
+        return trimUrl(withoutBasePathUrl, maxDepth)
     }
 }

packages/hono/src/middleware/metrics.ts

@@ -4,6 +4,7 @@ import {
     getStatusCodeGroup,
     isBypassPath,
     startTraceHistogram,
+    trimUrl,
 } from '@naverpay/prometheus-core'
 
 import type {HonoPrometheusExporterOptions} from '../types'
@@ -29,7 +30,7 @@ export function getHonoMetricsMiddleware({
 
     const extendedNormalizePath = (context: Context) => {
         const url = new URL(context.req.url)
-        return normalizeNextRoutesPath?.(url.href) || normalizePath?.(context) || url.pathname
+        return normalizeNextRoutesPath?.(url.href) || normalizePath?.(context) || trimUrl(url.pathname, maxDepth)
     }
 
     return async (context, next) => {

packages/koa/src/middleware/metrics.ts

@@ -4,6 +4,7 @@ import {
     getStatusCodeGroup,
     isBypassPath,
     startTraceHistogram,
+    trimUrl,
 } from '@naverpay/prometheus-core'
 import onFinished from 'on-finished'
 
@@ -29,7 +30,7 @@ export function getKoaMetricsMiddleware({
     const normalizeNextRoutesPath = nextjs ? createNextRoutesUrlGroup(maxDepth) : undefined
 
     const extendedNormalizePath = (context: Context) => {
-        return normalizeNextRoutesPath?.(context.url) || normalizePath?.(context) || context.path
+        return normalizeNextRoutesPath?.(context.url) || normalizePath?.(context) || trimUrl(context.path)
     }
 
     return async (context, next) => {