fix: use index for bytes iteration

Author: Nerivec

src/spinel/hdlc.ts

@@ -158,8 +158,8 @@ export function encodeHdlcFrame(buffer: Buffer): HdlcFrame {
     hdlcFrame.data[hdlcFrame.length] = HdlcReservedByte.FLAG;
     hdlcFrame.length += 1;
 
-    for (const aByte of buffer) {
-        hdlcFrame.length = encodeByte(hdlcFrame, aByte, hdlcFrame.length);
+    for (let i = 0; i < buffer.byteLength; i++) {
+        hdlcFrame.length = encodeByte(hdlcFrame, buffer[i], hdlcFrame.length);
     }
 
     let fcs = hdlcFrame.fcs;

src/zigbee/mac.ts

@@ -1094,7 +1094,8 @@ function encodeMACHeader(data: Buffer, offset: number, header: MACHeader, zigbee
 function crc16CCITT(data: Buffer): number {
     let fcs = 0x0000;
 
-    for (const aByte of data) {
+    for (let i = 0; i < data.byteLength; i++) {
+        const aByte = data[i];
         let q = (fcs ^ aByte) & 0x0f;
         fcs = (fcs >> 4) ^ (q * 0x1081);
         q = (fcs ^ (aByte >> 4)) & 0x0f;

src/zigbee/zigbee.ts

@@ -163,9 +163,8 @@ const CRC16X25_TABLE = new Uint16Array([
 export function computeInstallCodeCRC(data: number[] | Uint8Array | Buffer): number {
     let crc = 0xffff;
 
-    for (const aByte of data) {
-        const byte = aByte & 0xff;
-        crc = (crc >>> 8) ^ CRC16X25_TABLE[(crc ^ byte) & 0xff];
+    for (let i = 0; i < data.length; i++) {
+        crc = (crc >>> 8) ^ CRC16X25_TABLE[(crc ^ (data[i] & 0xff)) & 0xff];
     }
 
     return ~crc & 0xffff;