Skip to content

Commit cb3c07d

Browse files
committed
Fix an issue that would prevent os from detecting
1 parent 2484beb commit cb3c07d

File tree

7 files changed

+113
-95
lines changed

7 files changed

+113
-95
lines changed

example/.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,11 @@
55
*.swp
66
.DS_Store
77
.atom/
8+
.build/
89
.buildlog/
910
.history
1011
.svn/
12+
.swiftpm/
1113
migrate_working_dir/
1214

1315
# IntelliJ related

example/lib/main.dart

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,17 @@ class ExampleApp extends StatelessWidget {
2020
// your own [ManUpService]
2121
service: HttpManUpService('https://example.com/my_config.json',
2222
http: Client()),
23-
child: const Text('My App'),
23+
child: const Scaffold(body: Center(child: Text('My App'))),
2424
// Optionals
25-
onComplete: (_) {},
26-
onError: (_) {},
27-
onStatusChanged: (status) {},
25+
onComplete: (_) {
26+
print('ManUp validation complete');
27+
},
28+
onError: (_) {
29+
print('ManUp validation error');
30+
},
31+
onStatusChanged: (status) {
32+
print('ManUp status is "$status"');
33+
},
2834
shouldShowAlert: () => true,
2935
),
3036
);

example/pubspec.lock

Lines changed: 38 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -13,42 +13,42 @@ packages:
1313
dependency: transitive
1414
description:
1515
name: async
16-
sha256: "947bfcf187f74dbc5e146c9eb9c0f10c9f8b30743e341481c1e2ed3ecc18c20c"
16+
sha256: d2872f9c19731c2e5f10444b14686eb7cc85c76274bd6c16e1816bff9a3bab63
1717
url: "https://pub.dev"
1818
source: hosted
19-
version: "2.11.0"
19+
version: "2.12.0"
2020
boolean_selector:
2121
dependency: transitive
2222
description:
2323
name: boolean_selector
24-
sha256: "6cfb5af12253eaf2b368f07bacc5a80d1301a071c73360d746b7f2e32d762c66"
24+
sha256: "8aab1771e1243a5063b8b0ff68042d67334e3feab9e95b9490f9a6ebf73b42ea"
2525
url: "https://pub.dev"
2626
source: hosted
27-
version: "2.1.1"
27+
version: "2.1.2"
2828
characters:
2929
dependency: transitive
3030
description:
3131
name: characters
32-
sha256: "04a925763edad70e8443c99234dc3328f442e811f1d8fd1a72f1c8ad0f69a605"
32+
sha256: f71061c654a3380576a52b451dd5532377954cf9dbd272a78fc8479606670803
3333
url: "https://pub.dev"
3434
source: hosted
35-
version: "1.3.0"
35+
version: "1.4.0"
3636
clock:
3737
dependency: transitive
3838
description:
3939
name: clock
40-
sha256: cb6d7f03e1de671e34607e909a7213e31d7752be4fb66a86d29fe1eb14bfb5cf
40+
sha256: fddb70d9b5277016c77a80201021d40a2247104d9f4aa7bab7157b7e3f05b84b
4141
url: "https://pub.dev"
4242
source: hosted
43-
version: "1.1.1"
43+
version: "1.1.2"
4444
collection:
4545
dependency: transitive
4646
description:
4747
name: collection
48-
sha256: ee67cb0715911d28db6bf4af1026078bd6f0128b07a5f66fb2ed94ec6783c09a
48+
sha256: "2f5709ae4d3d59dd8f7cd309b4e023046b57d8a6c82130785d2b0e5868084e76"
4949
url: "https://pub.dev"
5050
source: hosted
51-
version: "1.18.0"
51+
version: "1.19.1"
5252
cupertino_icons:
5353
dependency: "direct main"
5454
description:
@@ -61,10 +61,10 @@ packages:
6161
dependency: transitive
6262
description:
6363
name: fake_async
64-
sha256: "511392330127add0b769b75a987850d136345d9227c6b94c96a04cf4a391bf78"
64+
sha256: "6a95e56b2449df2273fd8c45a662d6947ce1ebb7aafe80e550a3f68297f3cacc"
6565
url: "https://pub.dev"
6666
source: hosted
67-
version: "1.3.1"
67+
version: "1.3.2"
6868
ffi:
6969
dependency: transitive
7070
description:
@@ -188,18 +188,18 @@ packages:
188188
dependency: transitive
189189
description:
190190
name: leak_tracker
191-
sha256: "3f87a60e8c63aecc975dda1ceedbc8f24de75f09e4856ea27daf8958f2f0ce05"
191+
sha256: c35baad643ba394b40aac41080300150a4f08fd0fd6a10378f8f7c6bc161acec
192192
url: "https://pub.dev"
193193
source: hosted
194-
version: "10.0.5"
194+
version: "10.0.8"
195195
leak_tracker_flutter_testing:
196196
dependency: transitive
197197
description:
198198
name: leak_tracker_flutter_testing
199-
sha256: "932549fb305594d82d7183ecd9fa93463e9914e1b67cacc34bc40906594a1806"
199+
sha256: f8b613e7e6a13ec79cfdc0e97638fddb3ab848452eff057653abd3edba760573
200200
url: "https://pub.dev"
201201
source: hosted
202-
version: "3.0.5"
202+
version: "3.0.9"
203203
leak_tracker_testing:
204204
dependency: transitive
205205
description:
@@ -227,10 +227,10 @@ packages:
227227
dependency: transitive
228228
description:
229229
name: matcher
230-
sha256: d2323aa2060500f906aa31a895b4030b6da3ebdcc5619d14ce1aada65cd161cb
230+
sha256: dc58c723c3c24bf8d3e2d3ad3f2f9d7bd9cf43ec6feaa64181775e60190153f2
231231
url: "https://pub.dev"
232232
source: hosted
233-
version: "0.12.16+1"
233+
version: "0.12.17"
234234
material_color_utilities:
235235
dependency: transitive
236236
description:
@@ -243,10 +243,10 @@ packages:
243243
dependency: transitive
244244
description:
245245
name: meta
246-
sha256: bdb68674043280c3428e9ec998512fb681678676b3c54e773629ffe74419f8c7
246+
sha256: e3641ec5d63ebf0d9b41bd43201a66e3fc79a65db5f61fc181f04cd27aab950c
247247
url: "https://pub.dev"
248248
source: hosted
249-
version: "1.15.0"
249+
version: "1.16.0"
250250
package_info_plus:
251251
dependency: "direct main"
252252
description:
@@ -267,10 +267,10 @@ packages:
267267
dependency: transitive
268268
description:
269269
name: path
270-
sha256: "087ce49c3f0dc39180befefc60fdb4acd8f8620e5682fe2476afd0b3688bb4af"
270+
sha256: "75cca69d1490965be98c73ceaea117e8a04dd21217b37b292c9ddbec0d955bc5"
271271
url: "https://pub.dev"
272272
source: hosted
273-
version: "1.9.0"
273+
version: "1.9.1"
274274
path_provider:
275275
dependency: transitive
276276
description:
@@ -347,55 +347,55 @@ packages:
347347
dependency: transitive
348348
description: flutter
349349
source: sdk
350-
version: "0.0.99"
350+
version: "0.0.0"
351351
source_span:
352352
dependency: transitive
353353
description:
354354
name: source_span
355-
sha256: "53e943d4206a5e30df338fd4c6e7a077e02254531b138a15aec3bd143c1a8b3c"
355+
sha256: "254ee5351d6cb365c859e20ee823c3bb479bf4a293c22d17a9f1bf144ce86f7c"
356356
url: "https://pub.dev"
357357
source: hosted
358-
version: "1.10.0"
358+
version: "1.10.1"
359359
stack_trace:
360360
dependency: transitive
361361
description:
362362
name: stack_trace
363-
sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b"
363+
sha256: "8b27215b45d22309b5cddda1aa2b19bdfec9df0e765f2de506401c071d38d1b1"
364364
url: "https://pub.dev"
365365
source: hosted
366-
version: "1.11.1"
366+
version: "1.12.1"
367367
stream_channel:
368368
dependency: transitive
369369
description:
370370
name: stream_channel
371-
sha256: ba2aa5d8cc609d96bbb2899c28934f9e1af5cddbd60a827822ea467161eb54e7
371+
sha256: "969e04c80b8bcdf826f8f16579c7b14d780458bd97f56d107d3950fdbeef059d"
372372
url: "https://pub.dev"
373373
source: hosted
374-
version: "2.1.2"
374+
version: "2.1.4"
375375
string_scanner:
376376
dependency: transitive
377377
description:
378378
name: string_scanner
379-
sha256: "556692adab6cfa87322a115640c11f13cb77b3f076ddcc5d6ae3c20242bedcde"
379+
sha256: "921cd31725b72fe181906c6a94d987c78e3b98c2e205b397ea399d4054872b43"
380380
url: "https://pub.dev"
381381
source: hosted
382-
version: "1.2.0"
382+
version: "1.4.1"
383383
term_glyph:
384384
dependency: transitive
385385
description:
386386
name: term_glyph
387-
sha256: a29248a84fbb7c79282b40b8c72a1209db169a2e0542bce341da992fe1bc7e84
387+
sha256: "7f554798625ea768a7518313e58f83891c7f5024f88e46e7182a4558850a4b8e"
388388
url: "https://pub.dev"
389389
source: hosted
390-
version: "1.2.1"
390+
version: "1.2.2"
391391
test_api:
392392
dependency: transitive
393393
description:
394394
name: test_api
395-
sha256: "5b8a98dafc4d5c4c9c72d8b31ab2b23fc13422348d2997120294d3bac86b4ddb"
395+
sha256: fb31f383e2ee25fbbfe06b40fe21e1e458d14080e3c67e7ba0acfde4df4e0bbd
396396
url: "https://pub.dev"
397397
source: hosted
398-
version: "0.7.2"
398+
version: "0.7.4"
399399
typed_data:
400400
dependency: transitive
401401
description:
@@ -480,10 +480,10 @@ packages:
480480
dependency: transitive
481481
description:
482482
name: vm_service
483-
sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d"
483+
sha256: "0968250880a6c5fe7edc067ed0a13d4bae1577fe2771dcf3010d52c4a9d3ca14"
484484
url: "https://pub.dev"
485485
source: hosted
486-
version: "14.2.5"
486+
version: "14.3.1"
487487
web:
488488
dependency: transitive
489489
description:
@@ -509,5 +509,5 @@ packages:
509509
source: hosted
510510
version: "1.0.4"
511511
sdks:
512-
dart: ">=3.5.0 <4.0.0"
512+
dart: ">=3.7.0-0 <4.0.0"
513513
flutter: ">=3.24.0"

lib/src/http_man_up_service.dart

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,16 @@ part of manup;
22

33
class HttpManUpService extends ManUpService {
44
final String url;
5-
final PackageInfoProvider packageInfoProvider;
65
final Client http;
7-
final String? os;
8-
9-
ManUpDelegate? delegate;
106

117
HttpManUpService(
128
this.url, {
139
required this.http,
14-
this.os,
15-
this.packageInfoProvider = const DefaultPackageInfoProvider(),
10+
String? os,
11+
PackageInfoProvider packageInfoProvider =
12+
const DefaultPackageInfoProvider(),
1613
ConfigStorage storage = const ConfigStorage(),
17-
this.delegate,
14+
ManUpDelegate? delegate,
1815
}) : super(
1916
delegate: delegate,
2017
os: os,

0 commit comments

Comments
 (0)