feat: add condition type RecommendationProvided to workload

Author: knave

internal/autoscaler/autoscaler_test.go

@@ -34,6 +34,7 @@ import (
 	"github.com/samber/lo"
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/errors"
+	"k8s.io/apimachinery/pkg/api/meta"
 	"k8s.io/apimachinery/pkg/api/resource"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/types"
@@ -483,6 +484,8 @@ func verifyRecommendationStatus(workload *tfv1.TensorFusionWorkload, expectedRes
 	Eventually(func(g Gomega) {
 		g.Expect(k8sClient.Get(ctx, key, workload)).Should(Succeed())
 		g.Expect(workload.Status.Recommendation.Equal(expectedRes)).To(BeTrue())
+		g.Expect(meta.FindStatusCondition(workload.Status.Conditions,
+			constants.ConditionStatusTypeRecommendationProvided)).To(Not(BeNil()))
 		res, _ := utils.GPUResourcesFromAnnotations(getWorkers(workload)[0].Annotations)
 		g.Expect(res.Equal(expectedRes)).To(BeTrue())
 	}).Should(Succeed())

internal/autoscaler/recommender/percentile_recommender.go

@@ -103,7 +103,7 @@ func (p *PercentileRecommender) Recommend(ctx context.Context, workload *workloa
 		UpperBoundVram:   QuantityFromAmount(p.upperBoundVram.GetVramEstimation(aggregator)),
 	}
 
-	log.Info("current recommended resources from percentile recommender", "workload", workload.Name, "resources", rr)
+	log.V(6).Info("current recommended resources from percentile recommender", "workload", workload.Name, "resources", rr)
 
 	targetRes := &tfv1.Resources{}
 	if curRes.Requests.Tflops.Cmp(rr.LowerBoundTflops) < 0 ||

internal/autoscaler/workload/handler.go

@@ -4,12 +4,15 @@ import (
 	"context"
 	"fmt"
 	"maps"
+	"time"
 
 	tfv1 "github.com/NexusGPU/tensor-fusion/api/v1"
 	"github.com/NexusGPU/tensor-fusion/internal/constants"
 	"github.com/NexusGPU/tensor-fusion/internal/gpuallocator"
 	"github.com/NexusGPU/tensor-fusion/internal/utils"
 	corev1 "k8s.io/api/core/v1"
+	"k8s.io/apimachinery/pkg/api/meta"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/log"
 )
@@ -95,6 +98,12 @@ func (h *handler) updateWorkload(
 
 	if workload.Status.Recommendation == nil || !workload.Status.Recommendation.Equal(targetRes) {
 		workload.Status.Recommendation = targetRes
+		meta.SetStatusCondition(&workload.Status.Conditions, metav1.Condition{
+			Type:               constants.ConditionStatusTypeRecommendationProvided,
+			Status:             metav1.ConditionTrue,
+			Reason:             "GPUResourcesRecommended",
+			LastTransitionTime: metav1.NewTime(time.Now()),
+		})
 		if err := h.Status().Patch(ctx, workload, patch); err != nil {
 			return fmt.Errorf("failed to patch workload status %s: %v", workload.Name, err)
 		}

internal/constants/constants.go

@@ -135,6 +135,8 @@ const (
 	ConditionStatusTypeGPUPool               = "GPUPoolReady"
 	ConditionStatusTypeTimeSeriesDatabase    = "TimeSeriesDatabaseReady"
 	ConditionStatusTypeCloudVendorConnection = "CloudVendorConnectionReady"
+
+	ConditionStatusTypeRecommendationProvided = "RecommendationProvided"
 )
 
 const (

internal/controller/tensorfusionworkload_controller.go

@@ -23,6 +23,7 @@ import (
 
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/errors"
+	"k8s.io/apimachinery/pkg/api/meta"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/client-go/tools/record"
@@ -333,7 +334,6 @@ func (r *TensorFusionWorkloadReconciler) updateStatus(
 
 	// Determine workload phase
 	var phase tfv1.TensorFusionWorkloadPhase
-	var conditions []metav1.Condition
 
 	// Update Ready condition based on readyReplicas and desired replicas
 	readyCondition := metav1.Condition{
@@ -365,7 +365,8 @@ func (r *TensorFusionWorkloadReconciler) updateStatus(
 		readyCondition.Reason = "WaitingForWorkers"
 		readyCondition.Message = fmt.Sprintf("Ready replicas: %d/%d", readyReplicas, *workload.Spec.Replicas)
 	}
-	conditions = append(conditions, readyCondition)
+
+	conditionsChanged := meta.SetStatusCondition(&workload.Status.Conditions, readyCondition)
 
 	// Check if we need to update status
 	totalReplicasChangedInDynamicReplicaMode :=
@@ -374,13 +375,11 @@ func (r *TensorFusionWorkloadReconciler) updateStatus(
 		workload.Status.WorkerCount = int32(len(pods))
 	}
 	statusChanged := totalReplicasChangedInDynamicReplicaMode || workload.Status.ReadyWorkers != readyReplicas ||
-		workload.Status.Phase != phase ||
-		!utils.EqualConditionsDisregardTransitionTime(workload.Status.Conditions, conditions)
+		workload.Status.Phase != phase || conditionsChanged
 
 	if statusChanged {
 		log.Info("Updating workload status", "phase", phase, "readyReplicas", readyReplicas)
 		workload.Status.Phase = phase
-		workload.Status.Conditions = conditions
 		workload.Status.ReadyWorkers = readyReplicas
 		if err := r.Status().Update(ctx, workload); err != nil {
 			return fmt.Errorf("update workload status: %w", err)