Bug: CDN version bug

[lnorby]

If I load the library through CDN, DisclosureMenu throws this error: TypeError: Cannot set properties of undefined (setting 'menu-gduhniu') at K.initialize (accessible-menu.iife.js:3:582) and doesn't work at all. The last working version through CDN is 4.1.2. If I install it through NPM, everything works fine, even in the latest versions.

You can try it easily in the example on Codepen here: https://codepen.io/nickdjm/pen/NWmWMea
If you remove the import and load the library through CDN, it will stop working.

[NickDJM]

@lnorby Which CDN are you using? Can you set up an example using the CDN?

[lnorby]

jsDelivr CDN. https://codepen.io/laszlonorbert/pen/VYjKLbB

[NickDJM]

Thanks! I'll take a look

[NickDJM]

Ok I know what the issue is. It's because when we load from a CDN like jsdelivr and don't use a specific menu type, everything is loaded in window.AccessibleMenu which is also what we're using for storage.

I currently only check to see if window.AccessibleMenu exists. I'll add a check to make sure window.AccessibleMenu.menus exists and that'll fix it.

This is going to be a fix only for v4 though- v5 the whole storage system is changing and we'll just avoid the naming conflict all together.

[NickDJM]

I can't replicate this at all outside of codepen, but when I change the code to be:

document.addEventListener("DOMContentLoaded", () => {
  const nav = document.querySelector("nav");
  const menuElement = nav.querySelector("ul");
  const controllerElement = nav.querySelector("button");
  
  window.AccessibleMenu.menus = window.AccessibleMenu.menus || {};
  
  const menu = new AccessibleMenu.DisclosureMenu({
    menuElement,
    submenuItemSelector: ".dropdown",
    containerElement: nav,
    controllerElement,
    optionalKeySupport: true,
    hoverType: "dynamic", // "on", "off"
  });
});

It works as expected.

[NickDJM]

@lnorby I published v4.4.0. I tested it in the codepen you linked and it appears to work. Let me know if that resolves it on your end!

[lnorby]

Yes, it works. Thanks a lot!