fix: Clean up all compiler warnings

- Add #[allow(dead_code)] annotations to async features
- Fix unused imports in tests
- Gate async-dependent tests with feature flag
- Zero compiler warnings remaining

Author: K-NRS

src/pty/io_handler.rs

@@ -11,6 +11,7 @@ use crate::pty_buffer::PtyBuffer;
 
 /// Buffer size constants for improved performance
 pub const DEFAULT_BUFFER_SIZE: usize = 16384; // 16KB for better throughput
+#[allow(dead_code)]
 pub const SMALL_BUFFER_SIZE: usize = 4096; // 4KB for control messages
 
 /// Handle reading from PTY master and broadcasting to clients

src/pty/io_handler_async.rs

@@ -12,11 +12,13 @@ use crate::pty::socket_async::DEFAULT_BUFFER_SIZE;
 use crate::pty_buffer::PtyBuffer;
 
 /// Handle reading from PTY master and broadcasting to clients (async version)
+#[allow(dead_code)]
 pub struct AsyncPtyIoHandler {
     master_fd: RawFd,
     buffer_size: usize,
 }
 
+#[allow(dead_code)]
 impl AsyncPtyIoHandler {
     pub fn new(master_fd: RawFd) -> Self {
         Self {
@@ -67,11 +69,13 @@ impl AsyncPtyIoHandler {
 }
 
 /// Handle scrollback buffer management with thread-safe async operations
+#[allow(dead_code)]
 pub struct AsyncScrollbackHandler {
     buffer: Arc<RwLock<Vec<u8>>>,
     max_size: usize,
 }
 
+#[allow(dead_code)]
 impl AsyncScrollbackHandler {
     pub fn new(max_size: usize) -> Self {
         Self {
@@ -104,6 +108,7 @@ impl AsyncScrollbackHandler {
 }
 
 /// Async task that reads from socket and writes to stdout
+#[allow(dead_code)]
 pub async fn socket_to_stdout_task(
     mut socket: UnixStream,
     running: Arc<AtomicBool>,
@@ -158,6 +163,7 @@ pub async fn socket_to_stdout_task(
 }
 
 /// Async task that monitors terminal size changes
+#[allow(dead_code)]
 pub async fn resize_monitor_task(
     mut socket: UnixStream,
     running: Arc<AtomicBool>,
@@ -183,6 +189,7 @@ pub async fn resize_monitor_task(
 }
 
 /// Helper to send buffered output to a new client (async version)
+#[allow(dead_code)]
 pub async fn send_buffered_output_async(
     stream: &mut UnixStream,
     output_buffer: &PtyBuffer,
@@ -226,11 +233,13 @@ pub async fn send_buffered_output_async(
 }
 
 /// Session manager using Arc<RwLock> for multi-threaded access
+#[allow(dead_code)]
 pub struct AsyncSessionManager {
     sessions: Arc<RwLock<std::collections::HashMap<String, SessionData>>>,
 }
 
 #[derive(Clone)]
+#[allow(dead_code)]
 pub struct SessionData {
     pub id: String,
     pub master_fd: RawFd,
@@ -239,6 +248,7 @@ pub struct SessionData {
     pub created_at: std::time::SystemTime,
 }
 
+#[allow(dead_code)]
 impl AsyncSessionManager {
     pub fn new() -> Self {
         Self {

src/pty/socket_async.rs

@@ -7,10 +7,13 @@ use crate::error::{NdsError, Result};
 use crate::session::Session;
 
 /// Buffer size constants for improved performance
+#[allow(dead_code)]
 pub const DEFAULT_BUFFER_SIZE: usize = 16384; // 16KB for better throughput
+#[allow(dead_code)]
 pub const SMALL_BUFFER_SIZE: usize = 4096; // 4KB for control messages
 
 /// Creates a Unix socket listener for a session with secure permissions
+#[allow(dead_code)]
 pub async fn create_listener_async(session_id: &str) -> Result<(UnixListener, PathBuf)> {
     let socket_path = Session::socket_dir()?.join(format!("{}.sock", session_id));
 
@@ -33,6 +36,7 @@ pub async fn create_listener_async(session_id: &str) -> Result<(UnixListener, Pa
 }
 
 /// Send a resize command to the daemon through the socket (async version)
+#[allow(dead_code)]
 pub async fn send_resize_command_async(
     socket: &mut UnixStream,
     cols: u16,
@@ -114,6 +118,7 @@ pub fn is_valid_command(cmd: &str) -> bool {
 }
 
 /// Get the end index of an NDS command in the data (with bounds checking)
+#[allow(dead_code)]
 pub fn get_command_end_secure(data: &[u8]) -> Option<usize> {
     if data.len() < 8192 && data.starts_with(b"\x1b]nds:") {
         if let Ok(cmd_str) = std::str::from_utf8(data) {

src/pty/tests.rs

@@ -188,7 +188,6 @@ mod tests {
         use crate::pty::client::*;
         use crate::pty::io_handler::*;
         use crate::pty::socket::*;
-        use crate::pty::terminal::*;
 
         #[test]
         fn test_parse_nds_command_empty() {

tests/security_test.rs

@@ -24,6 +24,7 @@ fn test_socket_permissions() {
 }
 
 #[test]
+#[cfg(feature = "async")]
 fn test_input_sanitization() {
     use detached_shell::pty::socket_async::{is_valid_command, sanitize_string_input};
 
@@ -40,6 +41,7 @@ fn test_input_sanitization() {
 }
 
 #[test]
+#[cfg(feature = "async")]
 fn test_numeric_bounds() {
     use detached_shell::pty::socket_async::sanitize_numeric_input;
 
@@ -50,6 +52,7 @@ fn test_numeric_bounds() {
 }
 
 #[test]
+#[cfg(feature = "async")]
 fn test_command_length_limits() {
     use detached_shell::pty::socket_async::parse_nds_command_secure;