Music support?

[Entity378]

I was thinking it would be nice if you implemented some sort of support for the game's music too. I know the biggest problem would be editing the looppoints, but I recently made a python script that can change them and since that script changes the Hex of the file you can remake the script in Java using the same logic (If you want I can also rewrite the functions in Java and send them to you) . If you are interested in this let me know.

[NotThorny]

If you have a map of hashes for all music in the game and their associated actual file name then implementing it would be no issue at all.

[Entity378]

I've been looking for the music hashmaps for at least a year now but I think it's impossible to find them. The way my script works is through the song IDs in the music.pck files. However, if you want, the music files aren't huge, so hypothetically with a little patience you could create a table by hand where all the songs are mapped.

[Entity378]

hashmap aside, I think it would be enough to have an "advanced" section where you can replace songs and looppoints with the ID (to edit looppoints you need to know the ID of the song inside the music.pck) Furthermore, i think that, even having the hashmap, without ID you wouldn't do anything since information like looppoints are stored in the banks.pck and not in the music.pck (you're probably more informed than me on this point)

[NotThorny]

Getting music ids after knowing the hashes and what music they refer to is not an issue. Rewriting the program to not use hashes (or manually listening to and mapping all of them) is.

The goal of this program is to make it as simple as possible to make mods, so a section that requires manual work in searching inside of pcks (or pck maps that are not hashes) for ids or names goes beyond the intended scope. I would only be adding it in a way where everything is already mapped with the associated file hash, e.g. how voices are handled currently.

If anyone would like to manually match music ids with names to hashes on their own and provide that, then including an automatic loop point editor after to match the changed audio would not be a problem.

[Entity378]

Getting music ids after knowing the hashes and what music they refer to is not an issue. Rewriting the program to not use hashes (or manually listening to and mapping all of them) is.

The goal of this program is to make it as simple as possible to make mods, so a section that requires manual work in searching inside of pcks (or pck maps that are not hashes) for ids or names goes beyond the intended scope. I would only be adding it in a way where everything is already mapped with the associated file hash, e.g. how voices are handled currently.

If anyone would like to manually match music ids with names to hashes on their own and provide that, then including an automatic loop point editor after to match the changed audio would not be a problem.

I would be willing to do so, the problem is that I have no idea how to create/get the hashmap. Since you seem to know more than me, I was wondering if you could at least tell me where to start

EDIT: I wanted to verify how the hashmaps you use for voicelines were made and even after analyzing the code, I can't understand where the names and IDs of the audio files are associated. (Maybe I misunderstood how the application works)

also, if I manage to get/make an ashmap with only some songs and not all of them, it would be fine for the moment? (I'm quite busy lately)

[NotThorny]

Voice hashes are FNV1-64 hashes of the lowercase audio filepath, including language. Those are easily obtained from dumped game resources (example) which have a chain of ids leading back to the textmap that has what the voiceline actually says. Since they are the same format for most lines, the path can be inferred and hashed, then checked against the existence of a file with matching hash in dumped audio, without needing to explicitly know whether that path does exist or not beforehand.

Since music/other sounds don't have a clear filepath like this in resources - at least not that I know of - you don't have a path to just take and hash. The "simple" method would be to dump all the files, listen to each one, and manually associate the hash (which you know because you dumped the files) to the name/id/etc (which you inferred from listening to the file). This would be long and tedious, but "easy" in that nothing else would be required.

A more complex but faster long-term and reusable method might use something else from the dumped game resources, or from content of the file, or somewhere else that has information which can be clearly associated with a specific file and then putting that in a map of hash : identifier (+ any other useful info that is not already the identifier. ie. file name, music id, etc.).

If that partial mapping included at least the most common music (ie. ones that would have demand to be replaced) such as menu theme, combat start, etc., then it would have reason to get an implementation going. A random map of uncommon music would just cause frustration with users hearing "music available" only to be met with nothing they wanted to replace.

[Entity378]

Both methods seem very complicated, so the question that comes to mind is this: is it really necessary to know the songs hashes? In the end, the song IDs remain the same as the versions go by and always remain in the same .pck files, so wouldn't it be easier to listen to all the .pck files by hand and create a list? What I mean is this: for example, I know that the abyss ost id is in the music30.pck and music22.pck files and they have certain IDs (for example, the one in music30 is ID 1014711628 and the one in music22 is another ID), wouldn't it be enough to create a table in which I associate the abyss ost to those certain IDs and files?

[NotThorny]

To replace sound files the way this program does, yes is it necessary to know the hash - which is the name of the file being replaced.

[Entity378]

So the first step would be to "decompile" the game files with assetstudio/assetripper? I ask because if I remember correctly hoyo game files even if they are made with Unity are encrypted right?

[NotThorny]

If you believe there is some useful information you could gleam that way, then by all means. If you're just talking about extracting the audio files from the pcks, that is done using a wwise pck extractor.

[Entity378]

If you believe there is some useful information you could gleam that way, then by all means. If you're just talking about extracting the audio files from the pcks, that is done using a wwise pck extractor.

like, you said before: "The simple method would be to dump all the files, listen to each one, and manually associate the hash", so I figured you had to do something with assetstudio or like that. I know i can use other programs for audio files, I have worked with pck files in the past and used FusionTools to view/edit the content, I just don't understand what I should use to get the hashes. Sorry but I've never been interested in the game hashes until now and I know almost nothing about them

[NotThorny]

I just don't understand what I should use to get the hashes

You just dump the audio files from the pcks. As stated before, the hashes are the names of the files. You dump the file, it is named the hash. That's why hashes are needed to replace files, because the hash is the name of the file being replaced.

[Entity378]

I just don't understand what I should use to get the hashes

You just dump the audio files from the pcks. As stated before, the hashes are the names of the files. You dump the file, it is named the hash. That's why hashes are needed to replace files, because the hash is the name of the file being replaced.

ok then it's much simpler than expected, the only thing is that I can't use FusionTools because it doesn't keep the original audio names. Can you recommend me a pck extractor that keeps the audio names? And anyway, thanks for all the patience and support you are trying to give me

[NotThorny]

If you believe there is some useful information you could gleam that way, then by all means. If you're just talking about extracting the audio files from the pcks, that is done using a wwise pck extractor.

Wwise pck extractor. There are a couple if you just google that, they use the same tools regardless of which one you look at. Alternatively you can find the one shared in the AGMG discord server, it again uses the same tools to extract.

If you are really struggling to decide on which one, you can simply use the ones I've reuploaded previously from AGMG, https://drive.google.com/drive/folders/1aNLYe_H_F2oZGXrTiS8O4gP0Kwz9eowf

[Entity378]

i used the tool you sent me to extract the files and apparently the names of the extracted .wem files are equivalent to the IDs. This confuses me a lot.
EDIT: apparently the hash is the id of the song in hexadecimal.