Fix Windows CI workflow failure by conditionally generating coverage

- Split unit test step into two conditional steps
- Generate coverage only on ubuntu-latest (where it's uploaded)
- Run tests without coverage on macOS and Windows
- Fixes 'no required module provides package .txt' error on Windows
- Improves CI efficiency by not generating unused coverage files

Author: pierre-b

.github/workflows/test.yml

@@ -34,9 +34,14 @@ jobs:
       - name: Verify dependencies
         run: go mod verify
 
-      - name: Run unit tests
+      - name: Run unit tests (with coverage)
+        if: matrix.os == 'ubuntu-latest'
         run: go test -v -race -coverprofile=coverage.txt -covermode=atomic github.com/Notifuse/liquidgo/liquid
 
+      - name: Run unit tests (without coverage)
+        if: matrix.os != 'ubuntu-latest'
+        run: go test -v -race github.com/Notifuse/liquidgo/liquid
+
       - name: Run tag tests
         run: go test -v -race github.com/Notifuse/liquidgo/liquid/tag/... github.com/Notifuse/liquidgo/liquid/tags/...
 

liquid/tags/if.go

@@ -126,13 +126,6 @@ func (i *IfTag) parseBodyForBlock(tokenizer *liquid.Tokenizer, condition Conditi
 
 	foundEndTag := false
 	unknownTagHandler := func(endTagName, endTagMarkup string) bool {
-		// Update blank status (Ruby: @blank &&= body.blank?)
-		if !attachment.Blank() {
-			// If attachment is not blank, the if tag is not blank
-			// We can't directly set Block.blank, so we track it via the Block's body
-			// For now, we'll handle this in Blank() method
-		}
-
 		if endTagName == i.BlockDelimiter() {
 			foundEndTag = true
 			return false // Stop parsing - found endif

liquid/tags/include.go

@@ -92,7 +92,7 @@ func (i *IncludeTag) RenderToOutputBuffer(context liquid.TagContext, output *str
 	templateNameStr, ok := templateName.(string)
 	if !ok {
 		var locale *liquid.I18n
-		if pc, ok := i.Tag.ParseContext().(*liquid.ParseContext); ok {
+		if pc, ok := i.ParseContext().(*liquid.ParseContext); ok {
 			locale = pc.Locale()
 		}
 		var msg string
@@ -107,7 +107,7 @@ func (i *IncludeTag) RenderToOutputBuffer(context liquid.TagContext, output *str
 	}
 
 	// Load partial from cache
-	partial, err := liquid.LoadPartial(templateNameStr, context, i.Tag.ParseContext())
+	partial, err := liquid.LoadPartial(templateNameStr, context, i.ParseContext())
 	if err != nil {
 		errorMsg := context.HandleError(err, nil)
 		*output += errorMsg

liquid/tags/render.go

@@ -121,7 +121,7 @@ func (r *RenderTag) RenderToOutputBuffer(context liquid.TagContext, output *stri
 		}
 	} else if templateNameStr, ok := template.(string); ok {
 		// String template name - load from cache
-		partialInterface, err := liquid.LoadPartial(templateNameStr, context, r.Tag.ParseContext())
+		partialInterface, err := liquid.LoadPartial(templateNameStr, context, r.ParseContext())
 		if err != nil {
 			errorMsg := context.HandleError(err, nil)
 			*output += errorMsg

liquid/template.go

@@ -395,17 +395,11 @@ func (t *Template) buildContext(assigns interface{}, options *RenderOptions) Tag
 	default:
 		// Check if it's a drop - if so, we need to make it accessible for variable lookups
 		// In Ruby Liquid, drops can be passed as context and their methods become available as variables
-		var outerScope map[string]interface{}
-		var dropToStore interface{}
-
-		if assigns != nil {
-			dropToStore = assigns
-			// Wrap the drop in the outer scope so it's accessible
-			// The drop itself will be the context for variable lookups
-			outerScope = map[string]interface{}{"__drop__": assigns}
-		} else {
-			outerScope = t.instanceAssigns
-		}
+		// assigns is not nil here (nil case handled above)
+		dropToStore := assigns
+		// Wrap the drop in the outer scope so it's accessible
+		// The drop itself will be the context for variable lookups
+		outerScope := map[string]interface{}{"__drop__": assigns}
 
 		ctx = BuildContext(ContextConfig{
 			Environments:   []map[string]interface{}{t.assigns},
@@ -438,11 +432,6 @@ func (t *Template) buildContext(assigns interface{}, options *RenderOptions) Tag
 			}
 		}
 
-		// Set output if provided
-		if options.Output != nil {
-			// Output is handled in Render method
-		}
-
 		// Apply other options
 		if options.Filters != nil {
 			ctx.AddFilters(options.Filters)

liquid/tokenizer.go

@@ -128,10 +128,11 @@ func (t *Tokenizer) nextToken() string {
 
 		byteB := t.ss.PeekByte()
 
-		if byteB == percentage {
+		switch byteB {
+		case percentage:
 			t.ss.ScanByte()
 			return t.nextTagToken()
-		} else if byteB == openCurley {
+		case openCurley:
 			t.ss.ScanByte()
 			return t.nextVariableToken()
 		}

performance/shopify/comment_form.go

@@ -21,7 +21,7 @@ func NewCommentForm(tagName, markup string, parseContext liquid.ParseContextInte
 	matches := re.FindStringSubmatch(markup)
 
 	if matches == nil {
-		return nil, fmt.Errorf("Syntax Error in 'comment_form' - Valid syntax: comment_form [article]")
+		return nil, fmt.Errorf("syntax error in 'comment_form' - valid syntax: comment_form [article]")
 	}
 
 	block := liquid.NewBlock(tagName, markup, parseContext)
@@ -55,7 +55,7 @@ func (c *CommentForm) RenderToOutputBuffer(context liquid.TagContext, output *st
 	ctx.Set("form", form)
 
 	// Render block content
-	bodyOutput := c.Block.Render(context)
+	bodyOutput := c.Render(context)
 
 	// Wrap in form tag
 	articleID := "unknown"

performance/shopify/paginate.go

@@ -25,7 +25,7 @@ func NewPaginate(tagName, markup string, parseContext liquid.ParseContextInterfa
 	matches := re.FindStringSubmatch(markup)
 
 	if matches == nil {
-		return nil, fmt.Errorf("Syntax Error in tag 'paginate' - Valid syntax: paginate [collection] by number")
+		return nil, fmt.Errorf("syntax error in tag 'paginate' - valid syntax: paginate [collection] by number")
 	}
 
 	block := liquid.NewBlock(tagName, markup, parseContext)
@@ -82,7 +82,7 @@ func (p *Paginate) RenderToOutputBuffer(context liquid.TagContext, output *strin
 	collection := ctx.FindVariable(p.collectionName, false)
 	if collection == nil {
 		// In non-error mode, just render the block
-		bodyOutput := p.Block.Render(context)
+		bodyOutput := p.Render(context)
 		*output += bodyOutput
 		return
 	}
@@ -95,7 +95,7 @@ func (p *Paginate) RenderToOutputBuffer(context liquid.TagContext, output *strin
 		collectionSize = len(c)
 	default:
 		// In non-error mode, just render the block
-		bodyOutput := p.Block.Render(context)
+		bodyOutput := p.Render(context)
 		*output += bodyOutput
 		return
 	}
@@ -151,7 +151,7 @@ func (p *Paginate) RenderToOutputBuffer(context liquid.TagContext, output *strin
 	pagination["parts"] = parts
 
 	// Render block content
-	bodyOutput := p.Block.Render(context)
+	bodyOutput := p.Render(context)
 	*output += bodyOutput
 }