[IMP] l10n_es_aeat_sii_invoice_summary: Refactor to avoid overwrite when it is not necessary

TT60749

Author: carlosdauden

l10n_es_aeat_sii_invoice_summary/models/account_move.py

@@ -1,8 +1,9 @@
 # © 2017 FactorLibre - Hugo Santos <hugo.santos@factorlibre.com>
 # © 2018 FactorLibre - Victor Rodrigo <victor.rodrigo@factorlibre.com>
 # © 2022 ProcessControl - David Ramia <david.ramia@processcontrol.es>
+# Copyright 2026 Tecnativa - Carlos Dauden
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
-from odoo import _, exceptions, fields, models
+from odoo import _, fields, models
 
 
 class AccountMove(models.Model):
@@ -12,54 +13,40 @@ class AccountMove(models.Model):
     sii_invoice_summary_start = fields.Char("SII Invoice Summary: First Invoice")
     sii_invoice_summary_end = fields.Char("SII Invoice Summary: Last Invoice")
 
+    def _is_aeat_summary_invoice(self):
+        if (
+            self.is_invoice_summary
+            and self.is_sale_document()
+            and self.sii_invoice_summary_start != self.sii_invoice_summary_end
+        ):
+            return True
+        return False
+
+    def _is_aeat_simplified_invoice(self):
+        # En el SII, una factura resumen (F4) debe considerarse, a efectos de estructura
+        # y validaciones, equivalente a una factura simplificada (F2), compartiendo
+        # todas sus restricciones y campos obligatorios, con la única diferencia de
+        # requerir la clave TipoFactura = F4 y el campo adicional
+        # NumSerieFacturaEmisorResumenFin
+        return self.is_invoice_summary or super()._is_aeat_simplified_invoice()
+
     def _get_sii_invoice_type(self):
-        if self.is_invoice_summary and self.is_sale_document():
-            if self.move_type == "out_refund":
-                # TODO: It may not be necessary since a summary invoice implies
-                #  simplified invoice
-                invoice_type = "R5"
-            elif self.sii_invoice_summary_start == self.sii_invoice_summary_end:
-                invoice_type = "F2"
-            else:
-                invoice_type = "F4"
-        else:
-            invoice_type = super()._get_sii_invoice_type()
+        invoice_type = super()._get_sii_invoice_type()
+        if self._is_aeat_summary_invoice() and invoice_type == "F2":
+            invoice_type = "F4"
         return invoice_type
 
     def _get_aeat_invoice_dict_out(self, cancel=False):
         inv_dict = super()._get_aeat_invoice_dict_out(cancel=cancel)
-        if self.is_invoice_summary and self.is_sale_document():
-            if self.sii_invoice_summary_start != self.sii_invoice_summary_end:
-                inv_dict["IDFactura"][
-                    "NumSerieFacturaEmisor"
-                ] = self.sii_invoice_summary_start
-                inv_dict["IDFactura"][
-                    "NumSerieFacturaEmisorResumenFin"
-                ] = self.sii_invoice_summary_end
-            # TODO: It may not be necessary since a summary invoice implies
-            #  simplified invoice
-            if inv_dict.get("FacturaExpedida", {}).get("Contraparte"):
-                del inv_dict["FacturaExpedida"]["Contraparte"]
+        if inv_dict.get("FacturaExpedida", {}).get("TipoFactura", "") == "F4":
+            inv_dict["IDFactura"][
+                "NumSerieFacturaEmisor"
+            ] = self.sii_invoice_summary_start
+            inv_dict["IDFactura"][
+                "NumSerieFacturaEmisorResumenFin"
+            ] = self.sii_invoice_summary_end
         return inv_dict
 
-    def _aeat_check_exceptions(self):
-        """Inheritable method for exceptions control when sending SII invoices."""
-        res = False
-        try:
-            res = super()._aeat_check_exceptions()
-        except exceptions.UserError as e:
-            if (
-                e.args[0] == _("The partner has not a VAT configured.")
-                and self.is_invoice_summary
-            ):
-                pass
-            else:
-                raise
-
-        if self.is_invoice_summary and self.is_purchase_document():
-            raise exceptions.UserError(_("You can't make a supplier summary invoice."))
-        return res
-
     def write(self, vals):
         """Cannot let change sii_invoice_summary fields
         values in a SII registered supplier invoice"""

l10n_es_aeat_sii_invoice_summary/tests/json/sii_out_refund_s_iva0_sp_i_s_iva0_g_i_dict.json

@@ -12,7 +12,7 @@
     "Periodo": "01"
   },
   "FacturaExpedida": {
-    "TipoFactura": "F4",
+    "TipoFactura": "R5",
     "ClaveRegimenEspecialOTrascendencia": "01",
     "DescripcionOperacion": "/",
     "TipoDesglose": {
@@ -36,6 +36,7 @@
         }
       }
     },
+    "TipoRectificativa": "I",
     "ImporteTotal": -300.0
   }
 }

l10n_es_aeat_sii_invoice_summary/tests/json/sii_out_refund_s_iva10b_s_iva10b_s_iva21s_dict.json

@@ -12,7 +12,7 @@
     "Periodo": "01"
   },
   "FacturaExpedida": {
-    "TipoFactura": "F4",
+    "TipoFactura": "R5",
     "ClaveRegimenEspecialOTrascendencia": "01",
     "DescripcionOperacion": "/",
     "TipoDesglose": {
@@ -51,6 +51,7 @@
         }
       }
     },
+    "TipoRectificativa": "I",
     "ImporteTotal": -462.0
   }
 }

l10n_es_aeat_sii_invoice_summary/tests/json/sii_out_refund_s_iva_e_s_iva0_g_e_dict.json

@@ -12,7 +12,7 @@
     "Periodo": "01"
   },
   "FacturaExpedida": {
-    "TipoFactura": "F4",
+    "TipoFactura": "R5",
     "ClaveRegimenEspecialOTrascendencia": "01",
     "DescripcionOperacion": "/",
     "TipoDesglose": {
@@ -36,6 +36,7 @@
         }
       }
     },
+    "TipoRectificativa": "I",
     "ImporteTotal": -300.0
   }
 }