[IMP] delivery_gls_asm: raise UserError when validating picking with a PickUp Service

Also raise UserError if trying to send pickup with a non PickUp Service

Author: RicardCForgeFlow

delivery_gls_asm/models/delivery_carrier.py

@@ -269,7 +269,17 @@ def gls_asm_send_shipping(self, pickings):
         result = []
         for picking in pickings:
             if picking.carrier_id.gls_is_pickup_service:
-                continue
+                service_name = dict(
+                    picking.carrier_id._fields["gls_asm_service"].selection
+                ).get(picking.carrier_id.gls_asm_service)
+                raise UserError(
+                    _(
+                        "The service %s is a pickup service. "
+                        "If you want to record a pickup, please first use the "
+                        "'Send Pickup' button in the picking."
+                    )
+                    % service_name
+                )
             vals = self._prepare_gls_asm_shipping(picking)
             if len(vals.get("referencia_c", "")) > 15:
                 raise UserError(
@@ -339,7 +349,12 @@ def gls_asm_send_pickup(self, pickings):
         result = []
         for picking in pickings:
             if not picking.carrier_id.gls_is_pickup_service:
-                continue
+                service_name = dict(
+                    picking.carrier_id._fields["gls_asm_service"].selection
+                ).get(picking.carrier_id.gls_asm_service)
+                raise UserError(
+                    _("The service %s is not a pickup service.") % service_name
+                )
             vals = self._prepare_gls_asm_pickup(picking)
             vals.update({"tracking_number": False, "exact_price": 0})
             response = gls_request._send_pickup(vals)