[17.0] l10n_es_partner: v17.0.1.0.7 - Error entering contacts

[Tomero-Dev]

Module

l10n_es_partner

Describe the bug

Incompatibility with the base_search_custom_field_filter module.

To Reproduce

Create a custom filter field for the res.partner model

Now, with the new version of the l10n_es_partner module, if we go to contacts it gives an error because it is not a str.

OCA/l10n-spain/l10n_es_partner/models/res_partner.py", line 75, in get_views
    res["views"]["search"]["arch"] = res["views"]["search"]["arch"].replace(
TypeError: a bytes-like object is required, not 'str'

This is because the base_search_custom_field_filter module returns the search view encoded in base64 instead of str, resulting in an error in the replace() function.

    @api.model
    def get_views(self, views, options=None):
        res = super().get_views(views, options)
        # Inject the commercial field into the domain when searching by complete_name
        if "search" in res["views"]:
            res["views"]["search"]["arch"] = res["views"]["search"]["arch"].replace(
                "'|', ('complete_name', 'ilike', self)",
                "'|','|',('complete_name','ilike',self),('comercial','ilike',self)",
            )
        return res

[pedrobaeza]

¿base_search_custom_field_filter debería devolver el contenido en base64? ¿El estándar cómo devuelve eso?

[Tomero-Dev]

Buenas Pedro,
También me ha sorprendido porque el estandar (en versiones CE y EE) devuelve un STR.
Pero con este modulo instalado, y al añadirle un filtro custom a contactos hace lo siguiente:
Fichero bse.py: line 41-21

            if custom_filters:
                res = self._add_custom_filters(res, custom_filters)

Y en esta función:

    @api.model
    def _add_custom_filters(self, res, custom_filters):
        arch = etree.fromstring(res["arch"])
        for custom_filter in custom_filters:
            node = False
            if custom_filter.position_after:
                node = arch.xpath("//field[@name='%s']" % custom_filter.position_after)
            if not node:
                node = arch.xpath("//field[last()]")
            if node:
                elem = etree.Element(
                    "field",
                    {"name": custom_filter.expression, "string": custom_filter.name},
                )
                node[0].addnext(elem)
        res["arch"] = etree.tostring(arch)  # <- esta es la que devuelve el problema
        return res

etree.tostring(arch) devuelve lo siguiente:

No lo termina de pasar a string.

La versión de la librería lxml es:
lxml == 4.9.3

[pedrobaeza]

Entonces el parche debe ser hacer que el otro módulo lo convierta a string.