[MIG] maintenance_plan: Migration to 19.0

JasminSForgeFlow · JasminSForgeFlow · commit 52b144341834 · 2025-12-03T12:26:25.000Z
diff --git a/maintenance_plan/README.rst b/maintenance_plan/README.rst
@@ -11,7 +11,7 @@ Maintenance Plan
    !! This file is generated by oca-gen-addon-readme !!
    !! changes will be overwritten.                   !!
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-   !! source digest: sha256:222d80cfe136b8eb3f8e49710a9b76fdb27647e87145a28bfc621253f3581a22
+   !! source digest: sha256:cd21f05e56ccccd12e88d22a3009fd970401a379a695813d5815b03ed56303a2
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 
 .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
@@ -21,13 +21,13 @@ Maintenance Plan
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fmaintenance-lightgray.png?logo=github
-    :target: https://github.com/OCA/maintenance/tree/18.0/maintenance_plan
+    :target: https://github.com/OCA/maintenance/tree/19.0/maintenance_plan
     :alt: OCA/maintenance
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/maintenance-18-0/maintenance-18-0-maintenance_plan
+    :target: https://translation.odoo-community.org/projects/maintenance-19-0/maintenance-19-0-maintenance_plan
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/maintenance&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/maintenance&target_branch=19.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -115,7 +115,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/maintenance/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/maintenance/issues/new?body=module:%20maintenance_plan%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/maintenance/issues/new?body=module:%20maintenance_plan%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -154,6 +154,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/maintenance <https://github.com/OCA/maintenance/tree/18.0/maintenance_plan>`_ project on GitHub.
+This module is part of the `OCA/maintenance <https://github.com/OCA/maintenance/tree/19.0/maintenance_plan>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
diff --git a/maintenance_plan/__manifest__.py b/maintenance_plan/__manifest__.py
@@ -3,7 +3,7 @@
 {
     "name": "Maintenance Plan",
     "summary": "Extends preventive maintenance planning",
-    "version": "18.0.1.0.0",
+    "version": "19.0.1.0.0",
     "author": "Camptocamp SA, ForgeFlow, Odoo Community Association (OCA)",
     "license": "AGPL-3",
     "category": "Maintenance",
diff --git a/maintenance_plan/hooks.py b/maintenance_plan/hooks.py
@@ -3,7 +3,6 @@
 
 import logging
 
-from odoo import _
 from odoo.exceptions import UserError
 
 
@@ -27,7 +26,7 @@ def post_init_hook(env):
             )
             if len(request) > 1:
                 raise UserError(
-                    _(
+                    env._(
                         "You have multiple preventive maintenance requests on "
                         "equipment %(name)s next action date (%(date)s). "
                         "Please leave only one preventive request on the "
diff --git a/maintenance_plan/migrations/18.0.1.0.0/pre-migrate.py b/maintenance_plan/migrations/18.0.1.0.0/pre-migrate.py
diff --git a/maintenance_plan/models/maintenance_equipment.py b/maintenance_plan/models/maintenance_equipment.py
@@ -2,7 +2,7 @@
 # Copyright 2019-20 ForgeFlow S.L. (https://www.forgeflow.com)
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
-from odoo import _, api, fields, models
+from odoo import api, fields, models
 from odoo.exceptions import ValidationError
 
 
@@ -59,7 +59,7 @@ def _check_company_id(self):
                 rec.company_id == p.company_id for p in rec.maintenance_plan_ids
             ):
                 raise ValidationError(
-                    _(
+                    self.env._(
                         "Some maintenance plan's company is incompatible with "
                         "the company of this equipment."
                     )
@@ -85,8 +85,10 @@ def _prepare_request_from_plan(self, maintenance_plan, next_maintenance_date):
             team_id = request_model._get_default_team_id()
 
         description = self.name if self else maintenance_plan.name
-        kind = maintenance_plan.maintenance_kind_id.name or _("Unspecified kind")
-        name = _(
+        kind = maintenance_plan.maintenance_kind_id.name or self.env._(
+            "Unspecified kind"
+        )
+        name = self.env._(
             "Preventive Maintenance (%(kind)s) - %(description)s",
             kind=kind,
             description=description,
diff --git a/maintenance_plan/models/maintenance_kind.py b/maintenance_plan/models/maintenance_kind.py
@@ -12,6 +12,6 @@ class MaintenanceKind(models.Model):
     name = fields.Char(required=True, translate=True)
     active = fields.Boolean("Active Kind", required=True, default=True)
 
-    _sql_constraints = [
-        ("name_uniq", "unique (name)", "Maintenance kind name already exists.")
-    ]
+    _name_uniq = models.Constraint(
+        "unique (name)", "Maintenance kind name already exists."
+    )
diff --git a/maintenance_plan/models/maintenance_plan.py b/maintenance_plan/models/maintenance_plan.py
@@ -4,7 +4,7 @@
 
 from dateutil.relativedelta import relativedelta
 
-from odoo import _, api, fields, models
+from odoo import api, fields, models
 from odoo.exceptions import UserError, ValidationError
 from odoo.tools import safe_eval
 
@@ -102,7 +102,7 @@ class MaintenancePlan(models.Model):
     @api.model
     def _search_search_equipment(self, operator, value):
         if operator != "=" or (not value and not isinstance(value, models.NewId)):
-            raise ValueError(_("Unsupported search operator"))
+            raise ValueError(self.env._("Unsupported search operator"))
         plans = self.search([("generate_with_domain", "=", True)])
         plan_ids = []
         equipment = self.env["maintenance.equipment"].browse(value)
@@ -133,7 +133,7 @@ def _get_eval_context(self):
     @api.depends("maintenance_kind_id.name", "equipment_id.name")
     def _compute_display_name(self):
         for plan in self:
-            plan.display_name = plan.name or _(
+            plan.display_name = plan.name or self.env._(
                 "Unnamed %(kind)s plan (%(eqpmt)s)",
                 kind=plan.maintenance_kind_id.name or "",
                 eqpmt=plan.equipment_id.name,
@@ -210,7 +210,9 @@ def _check_company_id(self):
                 and rec.company_id != rec.equipment_id.company_id
             ):
                 raise ValidationError(
-                    _("Maintenace Equipment must belong to the equipment's company")
+                    self.env._(
+                        "Maintenace Equipment must belong to the equipment's company"
+                    )
                 )
 
     def unlink(self):
@@ -225,8 +227,8 @@ def unlink(self):
                 )
             )
             if request:
-                raise UserError(
-                    _(
+                raise UserError(  # pylint: disable=no-raise-unlink
+                    self.env._(
                         "The maintenance plan %(kind)s of equipment %(eqpmnt)s "
                         "has generated a request which is not done "
                         "yet. You should either set the request as "
@@ -238,14 +240,11 @@ def unlink(self):
                 )
         return super().unlink()
 
-    _sql_constraints = [
-        (
-            "equipment_kind_uniq",
-            "unique (equipment_id, maintenance_kind_id)",
-            "You cannot define multiple times the same maintenance kind on an "
-            "equipment maintenance plan.",
-        )
-    ]
+    _equipment_kind_uniq = models.Constraint(
+        "unique (equipment_id, maintenance_kind_id)",
+        "You cannot define multiple times the same maintenance kind on an "
+        "equipment maintenance plan.",
+    )
 
     def button_manual_request_generation(self):
         """Call the same method that the cron for generating manually the maintenance
diff --git a/maintenance_plan/static/description/index.html b/maintenance_plan/static/description/index.html
@@ -372,9 +372,9 @@ <h1>Maintenance Plan</h1>
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-!! source digest: sha256:222d80cfe136b8eb3f8e49710a9b76fdb27647e87145a28bfc621253f3581a22
+!! source digest: sha256:cd21f05e56ccccd12e88d22a3009fd970401a379a695813d5815b03ed56303a2
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/maintenance/tree/18.0/maintenance_plan"><img alt="OCA/maintenance" src="https://img.shields.io/badge/github-OCA%2Fmaintenance-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/maintenance-18-0/maintenance-18-0-maintenance_plan"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/maintenance&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/maintenance/tree/19.0/maintenance_plan"><img alt="OCA/maintenance" src="https://img.shields.io/badge/github-OCA%2Fmaintenance-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/maintenance-19-0/maintenance-19-0-maintenance_plan"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/maintenance&amp;target_branch=19.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module extends the functionality of Odoo Maintenance module by
 allowing an equipment to have different preventive maintenance kinds.</p>
 <p><strong>Table of contents</strong></p>
@@ -456,7 +456,7 @@ <h2><a class="toc-backref" href="#toc-entry-4">Bug Tracker</a></h2>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/maintenance/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/maintenance/issues/new?body=module:%20maintenance_plan%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/maintenance/issues/new?body=module:%20maintenance_plan%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -491,7 +491,7 @@ <h3><a class="toc-backref" href="#toc-entry-8">Maintainers</a></h3>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/maintenance/tree/18.0/maintenance_plan">OCA/maintenance</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/maintenance/tree/19.0/maintenance_plan">OCA/maintenance</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>
diff --git a/maintenance_plan/tests/test_maintenance_plan.py b/maintenance_plan/tests/test_maintenance_plan.py
@@ -3,7 +3,7 @@
 
 from dateutil.relativedelta import relativedelta
 
-from odoo import _, fields
+from odoo import fields
 
 from .common import TestMaintenancePlanBase
 
@@ -17,15 +17,15 @@ def setUpClass(cls):
     def test_display_name(self):
         self.assertEqual(
             self.maintenance_plan_1.display_name,
-            _(
+            self.env._(
                 "Unnamed %(void)s plan (%(eqpmnt)s)",
                 void="",
                 eqpmnt=self.maintenance_plan_1.equipment_id.name,
             ),
         )
         self.assertEqual(
             self.maintenance_plan_2.display_name,
-            _(
+            self.env._(
                 "Unnamed %(kind)s plan (%(eqpmnt)s)",
                 kind=self.maintenance_plan_2.maintenance_kind_id.name,
                 eqpmnt=self.maintenance_plan_2.equipment_id.name,
@@ -46,7 +46,8 @@ def test_next_maintenance_date_01(self):
         )
 
     def test_next_maintenance_date_02(self):
-        self.cron.method_direct_trigger()
+        with self.enter_registry_test_mode():
+            self.cron.method_direct_trigger()
         # Check maintenance plan dates
         self.assertEqual(
             self.maintenance_plan_1.start_maintenance_date, self.today_date
@@ -98,7 +99,8 @@ def test_next_maintenance_date_02(self):
         )
 
     def test_generate_requests(self):
-        self.cron.method_direct_trigger()
+        with self.enter_registry_test_mode():
+            self.cron.method_direct_trigger()
         generated_requests = self.maintenance_request_obj.search(
             [("maintenance_plan_id", "=", self.maintenance_plan_1.id)],
             order="schedule_date asc",
@@ -120,15 +122,16 @@ def test_generate_requests(self):
         )
         self.assertEqual(
             generated_request.name,
-            _(
+            self.env._(
                 "Preventive Maintenance (%(kind)s) - %(plan)s",
                 kind=self.weekly_kind.name,
                 plan=self.maintenance_plan_4.name,
             ),
         )
 
     def test_generate_requests2(self):
-        self.cron.method_direct_trigger()
+        with self.enter_registry_test_mode():
+            self.cron.method_direct_trigger()
         generated_requests = self.maintenance_request_obj.search(
             [("maintenance_plan_id", "=", self.maintenance_plan_1.id)],
             order="schedule_date asc",
@@ -140,7 +143,8 @@ def test_generate_requests2(self):
         new_date = fields.Date.from_string("2023-04-25")
         self.maintenance_plan_1.next_maintenance_date = new_date
         self.maintenance_plan_1.maintenance_plan_horizon = 3
-        self.cron.method_direct_trigger()
+        with self.enter_registry_test_mode():
+            self.cron.method_direct_trigger()
         generated_requests = self.maintenance_request_obj.search(
             [("maintenance_plan_id", "=", self.maintenance_plan_1.id)],
             order="schedule_date asc",
@@ -149,7 +153,8 @@ def test_generate_requests2(self):
         self.assertEqual(generated_requests[-1].request_date, new_date)
 
     def test_generate_requests_no_equipment(self):
-        self.cron.method_direct_trigger()
+        with self.enter_registry_test_mode():
+            self.cron.method_direct_trigger()
         generated_requests = self.maintenance_request_obj.search(
             [("maintenance_plan_id", "=", self.maintenance_plan_5.id)],
             order="schedule_date asc",
@@ -168,8 +173,8 @@ def test_generate_requests_no_equipment(self):
                 "maintenance_plan_horizon": 3,
             }
         )
-
-        self.cron.method_direct_trigger()
+        with self.enter_registry_test_mode():
+            self.cron.method_direct_trigger()
 
         generated_requests = self.maintenance_request_obj.search(
             [("maintenance_plan_id", "=", self.maintenance_plan_5.id)],
@@ -196,22 +201,25 @@ def test_get_relativedelta(self):
 
     def test_generate_requests_inactive_equipment(self):
         self.equipment_1.active = False
-        self.cron.method_direct_trigger()
+        with self.enter_registry_test_mode():
+            self.cron.method_direct_trigger()
         generated_requests = self.maintenance_request_obj.search(
             [("maintenance_plan_id", "=", self.maintenance_plan_1.id)],
             order="schedule_date asc",
         )
         self.assertEqual(len(generated_requests), 0)
         self.equipment_1.active = True
-        self.cron.method_direct_trigger()
+        with self.enter_registry_test_mode():
+            self.cron.method_direct_trigger()
         generated_requests = self.maintenance_request_obj.search(
             [("maintenance_plan_id", "=", self.maintenance_plan_1.id)],
             order="schedule_date asc",
         )
         self.assertEqual(len(generated_requests), 3)
 
     def test_maintenance_request_report(self):
-        self.cron.method_direct_trigger()
+        with self.enter_registry_test_mode():
+            self.cron.method_direct_trigger()
         generated_request = self.maintenance_request_obj.search(
             [("maintenance_plan_id", "=", self.maintenance_plan_1.id)],
             order="schedule_date asc",
diff --git a/maintenance_plan/tests/test_maintenance_plan_domain.py b/maintenance_plan/tests/test_maintenance_plan_domain.py
@@ -8,7 +8,8 @@
 
 class TestMaintenancePlanDomain(TestMaintenancePlanBase):
     def test_generate_requests_no_domain(self):
-        self.cron.method_direct_trigger()
+        with self.enter_registry_test_mode():
+            self.cron.method_direct_trigger()
         generated_requests = self.maintenance_request_obj.search(
             [("maintenance_plan_id", "=", self.maintenance_plan_5.id)],
             order="schedule_date asc",
@@ -27,7 +28,8 @@ def test_generate_requests_domain(self):
                 ),
             }
         )
-        self.cron.method_direct_trigger()
+        with self.enter_registry_test_mode():
+            self.cron.method_direct_trigger()
         generated_requests = self.maintenance_request_obj.search(
             [("maintenance_plan_id", "=", self.maintenance_plan_5.id)],
             order="schedule_date asc",
diff --git a/maintenance_plan/views/maintenance_plan_views.xml b/maintenance_plan/views/maintenance_plan_views.xml
diff --git a/maintenance_plan/views/maintenance_request_views.xml b/maintenance_plan/views/maintenance_request_views.xml

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`{`
`4`	`4`	`"name": "Maintenance Plan",`
`5`	`5`	`"summary": "Extends preventive maintenance planning",`
`6`		`- "version": "18.0.1.0.0",`
	`6`	`+ "version": "19.0.1.0.0",`
`7`	`7`	`"author": "Camptocamp SA, ForgeFlow, Odoo Community Association (OCA)",`
`8`	`8`	`"license": "AGPL-3",`
`9`	`9`	`"category": "Maintenance",`