convert_to_company_dependent function for v18+

[Tisho99]

Since version 18 of Odoo, company_dependent fields are stored in JSONB dictionaries instead of the ir.property table.

The convert_to_company_dependent function was designed to convert regular fields into company_dependent ones by storing their values in the ir.property table. However, it no longer works as expected in version 18 or later, since that table no longer exists.

That said, I think a new version of this method should be created in openupgrade_180.py, or the existing method should be refactored to also work with JSONB dictionaries.

openupgrade_180.py already includes the convert_company_dependent function, but its purpose is different: it converts company-dependent fields from version 17 to version 18, migrating data from the ir.property table to JSONB.

Before starting the development, I’d appreciate it if someone could share their opinion or confirm whether this approach makes sense.

[Tisho99]

@angelgarciadelachica

[pedrobaeza]

You have to use https://github.com/OCA/openupgradelib/blob/master/openupgradelib/openupgrade_180.py#L7

[Tisho99]

Hello @pedrobaeza

I write in response of this PR and OCA/bank-payment#1520

I have tried to use https://github.com/OCA/openupgradelib/blob/master/openupgradelib/openupgrade_180.py#L7, however it does not convert a normal field to a company dependent one in v18, even when renaming the column

The reason is that the ir_property table does not exist in version 18. Sources:
https://github.com/OCA/OpenUpgrade/blob/73c5015a2dc37f861526bc43e5ef55dd22c4f452/openupgrade_scripts/scripts/base/18.0.1.3/upgrade_analysis_work.txt#L2

openupgradelib/openupgradelib/openupgrade_180.py

Line 24 in 189837e

if not table_exists(env.cr, "ir_property"):

That said, I insist that the solution is the described in this issue, modifying the convert_to_company_dependent function to also be able to work with the jsonb fields of the new versions

[pedrobaeza]

If you are migrating from enterprise, you have to manually rename the table _ir_property to ir_property.

[StefanRijnhart]

@pedrobaeza Isn't the point that OCA/bank-payment#1520 assumes that the user is migrating from an older version of Odoo with a version of account_banking_mandate_contact already including OCA/bank-payment#1518? It will not work for users that are already using account_banking_mandate_contact in Odoo 18 from before the introduction of the company-dependent flag on the field. They will loose some data during the module update.

To cover for the latter situation, @Tisho99 is right in saying we'd need a version of openupgradelib's convert_to_company_dependent (not to be confused with openupgrade_180's convert_company_dependent) that is compatible with the new json field + ir.defaults implementation, unless Odoo 18 will now natively convert fields to company dependent by itself which I haven't tested tbh.

[pedrobaeza]

You have to update to the latest version inside the same Odoo major version before migrating, so I don't see the problem.

[StefanRijnhart]

@pedrobaeza The problem is for people who are not migrating. It's for people who started to use the module in 18.0 before the change.