precommit + readme

Author: quentinDupont

pos_cash_move_reason/README.rst

@@ -33,7 +33,7 @@ POS cash in-out reason
 |badge1| |badge2| |badge3| |badge4| |badge5|
 
 This module allow to define some reasons for the functionality of
-"Put Money In" and "Take Money Out" available in point of sale session.
+"Cash In / Out" available in point of sale session.
 
 So, with this module it's possible to impact directly an expense or income
 account which is defined on the related reasons and create according
@@ -77,6 +77,8 @@ to enable the feature.
 Usage
 =====
 
+**In backoffice**
+
 * Go to your current session
 
 * Click on the button "Put Money In" or "Take Money Out"
@@ -88,12 +90,24 @@ Usage
 
 .. figure:: https://raw.githubusercontent.com/OCA/pos/16.0/pos_cash_move_reason/static/description/wizard_pos_move_reason_form.png
 
-* When closing the session, an account move will be created, with two lines,
+* An account move will be created, with two lines,
   one with the default journal account, and one with the expense / income
   reason account.
 
 .. figure:: https://raw.githubusercontent.com/OCA/pos/16.0/pos_cash_move_reason/static/description/account_move_form.png
 
+**In POS UI**
+
+* Click on Cash In / Out
+
+* Choose Cash In or Cash Out then write the amount
+
+* Choose a Reason
+
+* If it has a Journal, choose Journal and confirm
+
+.. figure:: https://raw.githubusercontent.com/OCA/pos/16.0/pos_cash_move_reason/static/description/pos_cash_move_ui.png
+
 Known issues / Roadmap
 ======================
 
@@ -105,6 +119,10 @@ hide native obsolete actions available on the model ``pos.session``
 Changelog
 =========
 
+16.0.2.0.0 (2025-07-27)
+~~~~~~~~~~~~~~~~~~~~~~~
+* [IMP] This module works directly on POS UI
+
 16.0.1.0.0 (2025-07-27)
 ~~~~~~~~~~~~~~~~~~~~~~~
 * [MIG] Port module to version 16.0.

pos_cash_move_reason/models/pos_session.py

@@ -2,7 +2,8 @@
 # @author: Sylvain LE GAL (https://twitter.com/legalsylvain)
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 
-from odoo import fields, models
+from odoo import _, fields, models
+from odoo.exceptions import UserError
 
 
 class PosSession(models.Model):

pos_cash_move_reason/readme/DESCRIPTION.rst

@@ -1,5 +1,5 @@
 This module allow to define some reasons for the functionality of
-"Put Money In" and "Take Money Out" available in point of sale session.
+"Cash In / Out" available in point of sale session.
 
 So, with this module it's possible to impact directly an expense or income
 account which is defined on the related reasons and create according

pos_cash_move_reason/readme/HISTORY.rst

@@ -1,3 +1,7 @@
+16.0.2.0.0 (2025-07-27)
+~~~~~~~~~~~~~~~~~~~~~~~
+* [IMP] This module works directly on POS UI
+
 16.0.1.0.0 (2025-07-27)
 ~~~~~~~~~~~~~~~~~~~~~~~
 * [MIG] Port module to version 16.0.

pos_cash_move_reason/readme/USAGE.rst

@@ -1,3 +1,5 @@
+**In backoffice**
+
 * Go to your current session
 
 * Click on the button "Put Money In" or "Take Money Out"
@@ -9,8 +11,20 @@
 
 .. figure:: ../static/description/wizard_pos_move_reason_form.png
 
-* When closing the session, an account move will be created, with two lines,
+* An account move will be created, with two lines,
   one with the default journal account, and one with the expense / income
   reason account.
 
 .. figure:: ../static/description/account_move_form.png
+
+**In POS UI**
+
+* Click on Cash In / Out
+
+* Choose Cash In or Cash Out then write the amount
+
+* Choose a Reason
+
+* If it has a Journal, choose Journal and confirm
+
+.. figure:: ../static/description/pos_cash_move_ui.png

pos_cash_move_reason/static/description/index.html

@@ -376,7 +376,7 @@ <h1>POS cash in-out reason</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
 <p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/pos/tree/16.0/pos_cash_move_reason"><img alt="OCA/pos" src="https://img.shields.io/badge/github-OCA%2Fpos-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_cash_move_reason"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/pos&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module allow to define some reasons for the functionality of
-“Put Money In” and “Take Money Out” available in point of sale session.</p>
+“Cash In / Out” available in point of sale session.</p>
 <p>So, with this module it’s possible to impact directly an expense or income
 account which is defined on the related reasons and create according
 accounting entries.</p>
@@ -395,17 +395,18 @@ <h1>POS cash in-out reason</h1>
 <li><a class="reference internal" href="#usage" id="toc-entry-2">Usage</a></li>
 <li><a class="reference internal" href="#known-issues-roadmap" id="toc-entry-3">Known issues / Roadmap</a></li>
 <li><a class="reference internal" href="#changelog" id="toc-entry-4">Changelog</a><ul>
-<li><a class="reference internal" href="#section-1" id="toc-entry-5">16.0.1.0.0 (2025-07-27)</a></li>
-<li><a class="reference internal" href="#section-2" id="toc-entry-6">12.0.3.0.0 (2019-08-13)</a></li>
-<li><a class="reference internal" href="#section-3" id="toc-entry-7">8.0.2.0.0 (2018-06-25)</a></li>
-<li><a class="reference internal" href="#section-4" id="toc-entry-8">8.0.1.0.0 (2017-06-08)</a></li>
+<li><a class="reference internal" href="#section-1" id="toc-entry-5">16.0.2.0.0 (2025-07-27)</a></li>
+<li><a class="reference internal" href="#section-2" id="toc-entry-6">16.0.1.0.0 (2025-07-27)</a></li>
+<li><a class="reference internal" href="#section-3" id="toc-entry-7">12.0.3.0.0 (2019-08-13)</a></li>
+<li><a class="reference internal" href="#section-4" id="toc-entry-8">8.0.2.0.0 (2018-06-25)</a></li>
+<li><a class="reference internal" href="#section-5" id="toc-entry-9">8.0.1.0.0 (2017-06-08)</a></li>
 </ul>
 </li>
-<li><a class="reference internal" href="#bug-tracker" id="toc-entry-9">Bug Tracker</a></li>
-<li><a class="reference internal" href="#credits" id="toc-entry-10">Credits</a><ul>
-<li><a class="reference internal" href="#authors" id="toc-entry-11">Authors</a></li>
-<li><a class="reference internal" href="#contributors" id="toc-entry-12">Contributors</a></li>
-<li><a class="reference internal" href="#maintainers" id="toc-entry-13">Maintainers</a></li>
+<li><a class="reference internal" href="#bug-tracker" id="toc-entry-10">Bug Tracker</a></li>
+<li><a class="reference internal" href="#credits" id="toc-entry-11">Credits</a><ul>
+<li><a class="reference internal" href="#authors" id="toc-entry-12">Authors</a></li>
+<li><a class="reference internal" href="#contributors" id="toc-entry-13">Contributors</a></li>
+<li><a class="reference internal" href="#maintainers" id="toc-entry-14">Maintainers</a></li>
 </ul>
 </li>
 </ul>
@@ -433,6 +434,7 @@ <h2><a class="toc-backref" href="#toc-entry-1">Configuration</a></h2>
 </div>
 <div class="section" id="usage">
 <h2><a class="toc-backref" href="#toc-entry-2">Usage</a></h2>
+<p><strong>In backoffice</strong></p>
 <ul class="simple">
 <li>Go to your current session</li>
 <li>Click on the button “Put Money In” or “Take Money Out”</li>
@@ -448,13 +450,23 @@ <h2><a class="toc-backref" href="#toc-entry-2">Usage</a></h2>
 <img alt="https://raw.githubusercontent.com/OCA/pos/16.0/pos_cash_move_reason/static/description/wizard_pos_move_reason_form.png" src="https://raw.githubusercontent.com/OCA/pos/16.0/pos_cash_move_reason/static/description/wizard_pos_move_reason_form.png" />
 </div>
 <ul class="simple">
-<li>When closing the session, an account move will be created, with two lines,
+<li>An account move will be created, with two lines,
 one with the default journal account, and one with the expense / income
 reason account.</li>
 </ul>
 <div class="figure">
 <img alt="https://raw.githubusercontent.com/OCA/pos/16.0/pos_cash_move_reason/static/description/account_move_form.png" src="https://raw.githubusercontent.com/OCA/pos/16.0/pos_cash_move_reason/static/description/account_move_form.png" />
 </div>
+<p><strong>In POS UI</strong></p>
+<ul class="simple">
+<li>Click on Cash In / Out</li>
+<li>Choose Cash In or Cash Out then write the amount</li>
+<li>Choose a Reason</li>
+<li>If it has a Journal, choose Journal and confirm</li>
+</ul>
+<div class="figure">
+<img alt="https://raw.githubusercontent.com/OCA/pos/16.0/pos_cash_move_reason/static/description/pos_cash_move_ui.png" src="https://raw.githubusercontent.com/OCA/pos/16.0/pos_cash_move_reason/static/description/pos_cash_move_ui.png" />
+</div>
 </div>
 <div class="section" id="known-issues-roadmap">
 <h2><a class="toc-backref" href="#toc-entry-3">Known issues / Roadmap</a></h2>
@@ -466,13 +478,19 @@ <h2><a class="toc-backref" href="#toc-entry-3">Known issues / Roadmap</a></h2>
 <div class="section" id="changelog">
 <h2><a class="toc-backref" href="#toc-entry-4">Changelog</a></h2>
 <div class="section" id="section-1">
-<h3><a class="toc-backref" href="#toc-entry-5">16.0.1.0.0 (2025-07-27)</a></h3>
+<h3><a class="toc-backref" href="#toc-entry-5">16.0.2.0.0 (2025-07-27)</a></h3>
 <ul class="simple">
-<li>[MIG] Port module to version 16.0.</li>
+<li>[IMP] This module works directly on POS UI</li>
 </ul>
 </div>
 <div class="section" id="section-2">
-<h3><a class="toc-backref" href="#toc-entry-6">12.0.3.0.0 (2019-08-13)</a></h3>
+<h3><a class="toc-backref" href="#toc-entry-6">16.0.1.0.0 (2025-07-27)</a></h3>
+<ul class="simple">
+<li>[MIG] Port module to version 16.0.</li>
+</ul>
+</div>
+<div class="section" id="section-3">
+<h3><a class="toc-backref" href="#toc-entry-7">12.0.3.0.0 (2019-08-13)</a></h3>
 <ul class="simple">
 <li>[MIG] Port module to version 12.0.</li>
 <li>[REF] Don’t use <tt class="docutils literal">product.product</tt> model for Reasons, because Odoo remove
@@ -483,46 +501,46 @@ <h3><a class="toc-backref" href="#toc-entry-6">12.0.3.0.0 (2019-08-13)</a></h3>
 Instead, use new transient model <tt class="docutils literal">wizard.pos.move.reason</tt>.</li>
 </ul>
 </div>
-<div class="section" id="section-3">
-<h3><a class="toc-backref" href="#toc-entry-7">8.0.2.0.0 (2018-06-25)</a></h3>
+<div class="section" id="section-4">
+<h3><a class="toc-backref" href="#toc-entry-8">8.0.2.0.0 (2018-06-25)</a></h3>
 <ul class="simple">
 <li>[REF] Minor code refactoring.</li>
 </ul>
 </div>
-<div class="section" id="section-4">
-<h3><a class="toc-backref" href="#toc-entry-8">8.0.1.0.0 (2017-06-08)</a></h3>
+<div class="section" id="section-5">
+<h3><a class="toc-backref" href="#toc-entry-9">8.0.1.0.0 (2017-06-08)</a></h3>
 <ul class="simple">
 <li>First Version of the module.</li>
 </ul>
 </div>
 </div>
 <div class="section" id="bug-tracker">
-<h2><a class="toc-backref" href="#toc-entry-9">Bug Tracker</a></h2>
+<h2><a class="toc-backref" href="#toc-entry-10">Bug Tracker</a></h2>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/pos/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
 <a class="reference external" href="https://github.com/OCA/pos/issues/new?body=module:%20pos_cash_move_reason%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
-<h2><a class="toc-backref" href="#toc-entry-10">Credits</a></h2>
+<h2><a class="toc-backref" href="#toc-entry-11">Credits</a></h2>
 <div class="section" id="authors">
-<h3><a class="toc-backref" href="#toc-entry-11">Authors</a></h3>
+<h3><a class="toc-backref" href="#toc-entry-12">Authors</a></h3>
 <ul class="simple">
 <li>ACSONE SA/NV</li>
 <li>GRAP</li>
 </ul>
 </div>
 <div class="section" id="contributors">
-<h3><a class="toc-backref" href="#toc-entry-12">Contributors</a></h3>
+<h3><a class="toc-backref" href="#toc-entry-13">Contributors</a></h3>
 <ul class="simple">
 <li>Sylvain LE GAL &lt;<a class="reference external" href="https://twitter.com/legalsylvain">https://twitter.com/legalsylvain</a>&gt;</li>
 <li>Quentin DUPONT</li>
 <li>Dhara Solanki &lt;<a class="reference external" href="mailto:dhara.solanki&#64;initos.com">dhara.solanki&#64;initos.com</a>&gt;</li>
 </ul>
 </div>
 <div class="section" id="maintainers">
-<h3><a class="toc-backref" href="#toc-entry-13">Maintainers</a></h3>
+<h3><a class="toc-backref" href="#toc-entry-14">Maintainers</a></h3>
 <p>This module is maintained by the OCA.</p>
 <a class="reference external image-reference" href="https://odoo-community.org">
 <img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />

pos_cash_move_reason/static/description/pos_cash_move_ui.png

@@ -4,8 +4,6 @@ Copyright (C) 2026-Today: GRAP (https://www.grap.coop)
 License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 */
 odoo.define("pos_cash_move_reason.CashMoveButtonPatch", function (require) {
-
-
     const CashMoveButton = require("point_of_sale.CashMoveButton");
     const Registries = require("point_of_sale.Registries");
     const {_t} = require("web.core");

pos_cash_move_reason/static/src/js/CashMoveButtonPatch.esm.js

@@ -4,6 +4,8 @@ Copyright (C) 2026-Today: GRAP (https://www.grap.coop)
 License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 */
 odoo.define("pos_cash_move_reason.CashMovePopupPatch", function (require) {
+    "use strict";
+
     const CashMovePopup = require("point_of_sale.CashMovePopup");
     const {patch} = require("web.utils");
     const {useState} = owl;
@@ -22,7 +24,7 @@ odoo.define("pos_cash_move_reason.CashMovePopupPatch", function (require) {
         },
         onClickMoveReason(reason_id) {
             this.state.inputMoveReason = reason_id;
-            this.state.inputMoveReasonJournal = ""; // Reset
+            this.state.inputMoveReasonJournal = "";
 
             /* Get Journals linked to Move Reason*/
             const reason = this.env.pos.pos_move_reason.find((r) => r.id === reason_id);
@@ -41,20 +43,19 @@ odoo.define("pos_cash_move_reason.CashMovePopupPatch", function (require) {
             this.state.inputMoveReason = "";
             this.state.inputMoveReasonJournal = "";
             this.state.inputMoveReasonJournalFiltered = [];
-            return this._super(...arguments);
+            return this._super(type);
         },
 
         /* Filter Move Reasons according to cash IN or OUT*/
         get filteredMoveReasons() {
-            const ids = this.state.inputMoveReasonFiltered;
             let res = [];
-            if (this.state.inputType == "in") {
+            if (this.state.inputType === "in") {
                 res = this.env.pos.pos_move_reason.filter(
-                    (reason) => reason.is_income_reason == true
+                    (reason) => reason.is_income_reason === true
                 );
-            } else if (this.state.inputType == "out") {
+            } else if (this.state.inputType === "out") {
                 res = this.env.pos.pos_move_reason.filter(
-                    (reason) => reason.is_expense_reason == true
+                    (reason) => reason.is_expense_reason === true
                 );
             }
             return res;
@@ -67,7 +68,7 @@ odoo.define("pos_cash_move_reason.CashMovePopupPatch", function (require) {
             const res = this.env.pos.account_journal.filter((j) => ids.includes(j.id));
 
             /* Choose journal if there is just one*/
-            if (res.length == 1) {
+            if (res.length === 1) {
                 this.state.inputMoveReasonJournal = res[0].id;
             }
 
@@ -87,14 +88,14 @@ odoo.define("pos_cash_move_reason.CashMovePopupPatch", function (require) {
 
         /* Add new required fields */
         confirm() {
-            if (this.state.inputMoveReason == "") {
+            if (this.state.inputMoveReason === "") {
                 this.state.inputHasError = true;
                 this.errorMessage = this.env._t("Select one Reason before confirming.");
                 return;
             }
             if (
                 this.state.inputMoveReasonJournalFiltered.length > 0 &&
-                this.state.inputMoveReasonJournal == ""
+                this.state.inputMoveReasonJournal === ""
             ) {
                 this.state.inputHasError = true;
                 this.errorMessage = this.env._t(