[17.0] _get_combination_info in product_variant_sale_price passes unused extra argument, causes occasional TypeError

[igallart]

Description:

Hi,
I'm reviewing the product_variant_sale_price module and noticed that in this line, an extra argument seems to be passed to _get_combination_info, specifically the pricelist, which does not appear to be used.

In some cases, this leads to a TypeError, although it doesn't always happen — I haven't been able to identify the exact conditions under which the error is triggered.

Here’s a traceback from one occurrence:

TypeError: ProductTemplate._get_combination_info() takes from 1 to 6 positional arguments but 7 were given

This occurs when calling product._get_combination_info_variant(), which in turn calls product_tmpl_id._get_combination_info(...).

Is the extra pricelist argument necessary for some specific reason, or should it be removed to avoid this type of issue?

Thanks in advance.

[igallart]

In runbot, install first website and ecommerce, after this module, and go to website, shop, and click in any product with variants:

[cparadis-impressfoods]

Should be fixed with #410