Fix failing checks

mitul-tsd · mitul-tsd · commit 54abd51d2896 · 2026-01-12T22:17:55.000+05:30
diff --git a/base_export_async/__manifest__.py b/base_export_async/__manifest__.py
@@ -2,29 +2,29 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
 {
-    'name': 'Base Export Async',
-    'summary': 'Asynchronous export with job queue',
-    'version': '17.0.1.0.0',
-    'license': 'AGPL-3',
-    'author': 'ACSONE SA/NV, Odoo Community Association (OCA)',
-    'website': 'https://github.com/OCA/queue',
-    'depends': ['web', 'queue_job'],
-    'data': [
+    "name": "Base Export Async",
+    "summary": "Asynchronous export with job queue",
+    "version": "17.0.1.0.0",
+    "license": "AGPL-3",
+    "author": "ACSONE SA/NV, Odoo Community Association (OCA)",
+    "website": "https://github.com/OCA/queue",
+    "depends": ["web", "queue_job"],
+    "data": [
         # added this additional rule as when the export happens from queue job module
         # there is no user is there, which was causing an issue when fetching res.currency
-        'security/ir.model.access.csv',
-        'security/ir_rule.xml',
-        'data/config_parameter.xml',
-        'data/cron.xml',
-        'data/mail_template.xml',
+        "security/ir.model.access.csv",
+        "security/ir_rule.xml",
+        "data/config_parameter.xml",
+        "data/cron.xml",
+        "data/mail_template.xml",
     ],
-    'demo': [],
-    'assets': {
-        'web.assets_backend': [
-            'base_export_async/static/src/xml/base.xml',
-            'base_export_async/static/src/js/list_controller.esm.js',
-            'base_export_async/static/src/js/data_export.esm.js',
+    "demo": [],
+    "assets": {
+        "web.assets_backend": [
+            "base_export_async/static/src/xml/base.xml",
+            "base_export_async/static/src/js/list_controller.esm.js",
+            "base_export_async/static/src/js/data_export.esm.js",
         ],
     },
-    'installable': True,
+    "installable": True,
 }
diff --git a/base_export_async/models/delay_export.py b/base_export_async/models/delay_export.py
@@ -7,63 +7,67 @@
 
 from dateutil.relativedelta import relativedelta
 
-from odoo import _, api, fields, models, SUPERUSER_ID
-from odoo.http import request
+from odoo import SUPERUSER_ID, _, api, fields, models
 from odoo.exceptions import UserError
+from odoo.http import request
 
 from odoo.addons.web.controllers.export import CSVExport, ExcelExport
 
 
 class DelayExport(models.Model):
-    _name = 'delay.export'
-    _description = 'Asynchronous Export'
+    _name = "delay.export"
+    _description = "Asynchronous Export"
 
-    user_ids = fields.Many2many('res.users', string='Users', index=True)
+    user_ids = fields.Many2many("res.users", string="Users", index=True)
     model_description = fields.Char()
     url = fields.Char()
     expiration_date = fields.Date()
 
     @api.model
     def delay_export(self, data):
         """Delay the export, called from js"""
-        params = json.loads(data.get('data'))
+        params = json.loads(data.get("data"))
         if not self.env.user.email:
-            raise UserError(_('You must set an email address to your user.'))
+            raise UserError(_("You must set an email address to your user."))
         self.with_delay().export(params)
 
     @api.model
     def _get_file_content(self, params):
-        export_format = params.get('format')
+        export_format = params.get("format")
 
         items = operator.itemgetter(
-            'model', 'fields', 'ids', 'domain', 'import_compat', 'context', 'user_ids'
+            "model", "fields", "ids", "domain", "import_compat", "context", "user_ids"
         )(params)
         (model_name, fields_name, ids, domain, import_compat, context, user_ids) = items
 
-        model = self.env[model_name].sudo().with_context(
-            import_compat=import_compat, **context
+        model = (
+            self.env[model_name]
+            .sudo()
+            .with_context(import_compat=import_compat, **context)
         )
         records = model.browse(ids) or model.search(
             domain, offset=0, limit=False, order=False
         )
 
         if not model._is_an_ordinary_table():
-            fields_name = [field for field in fields_name if field['name'] != 'id']
+            fields_name = [field for field in fields_name if field["name"] != "id"]
 
-        field_names = [f['name'] for f in fields_name]
-        import_data = records.export_data(field_names).get('datas', [])
+        field_names = [f["name"] for f in fields_name]
+        import_data = records.export_data(field_names).get("datas", [])
 
         if import_compat:
             columns_headers = field_names
         else:
-            columns_headers = [val['label'].strip() for val in fields_name]
+            columns_headers = [val["label"].strip() for val in fields_name]
 
         # Patch: ensure request.env is set with a valid uid before triggering ExportXlsxWriter
-        if export_format != 'csv':
-            if not hasattr(request, 'env') or request.env.uid is None:
-                request.env = api.Environment(self.env.cr, SUPERUSER_ID, self.env.context)
+        if export_format != "csv":
+            if not hasattr(request, "env") or request.env.uid is None:
+                request.env = api.Environment(
+                    self.env.cr, SUPERUSER_ID, self.env.context
+                )
 
-        if export_format == 'csv':
+        if export_format == "csv":
             csv = CSVExport()
             return csv.from_data(columns_headers, import_data)
         else:
@@ -79,7 +83,7 @@ def export(self, params):
         * format: csv/excel
         * model: model to export
         * fields: list of fields to export, a list of dict:
-          [{'label': '', 'name': ''}]
+          [{"label": "", "name": ""}]
         * ids: list of ids to export
         * domain: domain for the export
         * context: context for the export (language, ...)
@@ -88,62 +92,62 @@ def export(self, params):
         """
         content = self._get_file_content(params)
 
-        items = operator.itemgetter('model', 'context', 'format', 'user_ids')(params)
+        items = operator.itemgetter("model", "context", "format", "user_ids")(params)
         model_name, context, export_format, user_ids = items
-        users = self.env['res.users'].browse(user_ids)
+        users = self.env["res.users"].browse(user_ids)
 
-        export_record = self.sudo().create({'user_ids': [(6, 0, users.ids)]})
+        export_record = self.sudo().create({"user_ids": [(6, 0, users.ids)]})
 
-        name = '{}.{}'.format(model_name, export_format)
-        attachment = self.env['ir.attachment'].create(
+        name = f"{model_name}.{export_format}"
+        attachment = self.env["ir.attachment"].create(
             {
-                'name': name,
-                'datas': base64.b64encode(content),
-                'type': 'binary',
-                'res_model': self._name,
-                'res_id': export_record.id,
+                "name": name,
+                "datas": base64.b64encode(content),
+                "type": "binary",
+                "res_model": self._name,
+                "res_id": export_record.id,
             }
         )
 
-        url = '{}/web/content/ir.attachment/{}/datas/{}?download=true'.format(
-            self.env['ir.config_parameter'].sudo().get_param('web.base.url'),
+        url = "{}/web/content/ir.attachment/{}/datas/{}?download=true".format(
+            self.env["ir.config_parameter"].sudo().get_param("web.base.url"),
             attachment.id,
             attachment.name,
         )
 
         time_to_live = (
-            self.env['ir.config_parameter'].sudo().get_param('attachment.ttl', 7)
+            self.env["ir.config_parameter"].sudo().get_param("attachment.ttl", 7)
         )
         date_today = fields.Date.today()
         expiration_date = fields.Date.to_string(
             date_today + relativedelta(days=+int(time_to_live))
         )
 
-        odoo_bot = self.sudo().env.ref('base.partner_root')
+        odoo_bot = self.sudo().env.ref("base.partner_root")
         email_from = odoo_bot.email
         model_description = self.env[model_name]._description
         export_record.write(
             {
-                'url': url,
-                'expiration_date': expiration_date,
-                'model_description': model_description,
+                "url": url,
+                "expiration_date": expiration_date,
+                "model_description": model_description,
             }
         )
 
-        self.env.ref('base_export_async.delay_export_mail_template').send_mail(
+        self.env.ref("base_export_async.delay_export_mail_template").send_mail(
             export_record.id,
             email_values={
-                'email_from': email_from,
-                'reply_to': email_from,
-                'recipient_ids': [(6, 0, users.mapped('partner_id').ids)],
+                "email_from": email_from,
+                "reply_to": email_from,
+                "recipient_ids": [(6, 0, users.mapped("partner_id").ids)],
             },
         )
 
     @api.model
     def cron_delete(self):
         time_to_live = (
-            self.env['ir.config_parameter'].sudo().get_param('attachment.ttl', 7)
+            self.env["ir.config_parameter"].sudo().get_param("attachment.ttl", 7)
         )
         date_today = fields.Date.today()
         date_to_delete = date_today + relativedelta(days=-int(time_to_live))
-        self.search([('create_date', '<=', date_to_delete)]).unlink()
+        self.search([("create_date", "<=", date_to_delete)]).unlink()
diff --git a/base_export_async/static/description/index.html b/base_export_async/static/description/index.html
@@ -413,6 +413,7 @@ <h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
 <ul class="simple">
 <li>Arnaud Pineux (ACSONE SA/NV) authored the initial prototype.</li>
 <li>Guewen Baconnier (Camptocamp)</li>
+<li>Mitul Shah (TradeSolutions.Digital GmbH)</li>
 </ul>
 </div>
 <div class="section" id="maintainers">
diff --git a/base_export_async/static/src/js/data_export.esm.js b/base_export_async/static/src/js/data_export.esm.js
@@ -2,7 +2,7 @@
 
 import {ExportDataDialog} from "@web/views/view_dialogs/export_data_dialog";
 import {patch} from "@web/core/utils/patch";
-import { useService } from "@web/core/utils/hooks";
+import {useService} from "@web/core/utils/hooks";
 
 patch(ExportDataDialog.prototype, {
     setup() {
diff --git a/base_export_async/static/src/js/list_controller.esm.js b/base_export_async/static/src/js/list_controller.esm.js
@@ -1,18 +1,18 @@
 /** @odoo-module **/
 
 
-import { AlertDialog } from "@web/core/confirmation_dialog/confirmation_dialog";
+import {AlertDialog} from "@web/core/confirmation_dialog/confirmation_dialog";
 import {ListController} from "@web/views/list/list_controller";
 import {_t} from "@web/core/l10n/translation";
 import {download} from "@web/core/network/download";
 import {patch} from "@web/core/utils/patch";
-import { useService } from "@web/core/utils/hooks";
+import {useService} from "@web/core/utils/hooks";
 
 patch(ListController.prototype, {
     setup() {
         super.setup();
-        this.uiService = useService('ui');
-        this.orm = useService('orm');
+        this.uiService = useService("ui");
+        this.orm = useService("orm");
     },
     async downloadExport(fields, import_compat, format, async = false) {
         let ids = false;
@@ -52,7 +52,9 @@ patch(ListController.prototype, {
             this.orm.call("delay.export", "delay_export", args).then(function () {
                 self.uiService.unblock();
                 self.model.dialog.add(AlertDialog, {
-                    body: _t("You will receive the export file by email as soon as it is finished."),
+                    body: _t(
+                        "You will receive the export file by email as soon as it is finished."
+                    ),
                 });
             });
         } else {
diff --git a/base_export_async/tests/test_base_export_async.py b/base_export_async/tests/test_base_export_async.py
