[17.0] sale_blanket_order: Technical User Group "Disable Adding Lines to SO" not working

[nivels-bt]

sale_blanket_order: The Technical User Group "Disable adding more lines to SOs from Blanket Order" is not working. It's always possible to add another line, even if the checkbox is activated.

Module

sale_blanket_order
https://github.com/OCA/sale-workflow/tree/17.0/sale_blanket_order

Describe the bug

The custom technical user group "Disable adding more lines to SOs from Blanket Orders" which is added trough this module is not working properly. It doesn't have any affect on the Sale Order Lines. Users can add more products to the sales order, even if the checkbox is activated on the user.

To Reproduce

Tested on odoo 17 runboat

Steps to reproduce the behavior:

1. Active the custom user group "Disable adding more lines to SOs from Blanket Orders" on the user you are using:

2. Create a Blanket Order with at least one line

3. Confirm the Blanket Order:

4. Create a Sales Order from this Blanket Order:

Expected behavior
On the created Sales Order, it shouldn't be possible to add anymore Sales Order Lines because of the user group. But it is still possible. It doesn't change anything if you deactivate the user group.

Additional context
I've also tested this in a 17.0 Enterprise environment. There it is the complete opposite: It's not possible to add new order lines, no matter if the user group is set or not.

[nivels-bt]

@StefanRijnhart I saw you pushed the latest commit to sale_blanket_order in 17.0. Can I assign this to you or do you know, who the right person is?

[StefanRijnhart]

@bt-nivels Sorry, I'm not that invested in this module. I'd review a fix though.