[MIG] stock_picking_report_custom_description: Migration to 19.0

Author: miguel-S73

stock_picking_report_custom_description/__manifest__.py

@@ -7,7 +7,7 @@
 {
     "name": "Stock Picking Report Custom Description",
     "summary": "Show moves description in picking reports",
-    "version": "18.0.1.0.0",
+    "version": "19.0.1.0.0",
     "category": "Warehouse",
     "website": "https://github.com/OCA/stock-logistics-reporting",
     "author": "Tecnativa, Odoo Community Association (OCA)",

stock_picking_report_custom_description/models/stock_rule.py

@@ -41,5 +41,4 @@ def _get_stock_move_values(
                 and description_picking != line.product_id.display_name
             ):
                 res["description_picking"] = description_picking
-            res["name"] = line.name
         return res

stock_picking_report_custom_description/readme/CONTRIBUTORS.md

@@ -6,3 +6,5 @@
   - Carolina Fernandez
 - [Heliconia Solutions Pvt. Ltd.](https://www.heliconia.io)
   - Bhavesh Heliconia
+- [Studio73](https://www.studio73.es)
+  - Miguel Gandia

stock_picking_report_custom_description/tests/test_stock_picking_report_custom_description.py

@@ -16,22 +16,50 @@ def setUpClass(cls):
             {
                 "name": "Test product",
                 "type": "consu",
-                "description_sale": "Custom description",
             }
         )
         order_form = Form(cls.env["sale.order"])
         order_form.partner_id = cls.customer
         with order_form.order_line.new() as line_form:
             line_form.product_id = cls.product
+            line_form.name = f"{cls.product.display_name}\nCustom description"
         cls.order = order_form.save()
 
     def test_so_custom_description_transfer_to_picking(self):
         self.order.action_confirm()
         self.assertEqual(
             self.order.order_line.move_ids.description_picking, "Custom description"
         )
-        self.order.order_line.name = "Custom description 2"
+        self.order.order_line.name = (
+            f"{self.order.order_line.product_id.display_name}\nCustom description 2"
+        )
         self.assertEqual(
             self.order.order_line.move_ids.description_picking,
             self.order.order_line.name,
         )
+        # Test description_picking no change when update other field than name
+        self.order.order_line.price_unit = 42.0
+        self.assertEqual(
+            self.order.order_line.move_ids.description_picking,
+            self.order.order_line.name,
+        )
+        # Test description_picking when order line name is empty
+        order_form = Form(self.env["sale.order"])
+        order_form.partner_id = self.customer
+        with order_form.order_line.new() as line_form:
+            line_form.product_id = self.product
+            line_form.name = ""
+        order2 = order_form.save()
+        order2.action_confirm()
+        self.assertEqual(order2.order_line.move_ids.description_picking, "Test product")
+        # Test when auto create picking when confirm other doc than SO
+        self.env["stock.rule"]._get_stock_move_values(
+            product_id=self.product,
+            product_qty=1,
+            product_uom=self.product.uom_id,
+            location_id=self.env.ref("stock.stock_location_customers"),
+            name="Test move",
+            origin="Test origin",
+            company_id=self.env.company,
+            values={"date_planned": "2024-01-01 00:00:00"},
+        )