FIX stock_period_evaluation: remove active handling and fix tests

IMP metadata and style

Author: eLBati

stock_period_evaluation/README.rst

@@ -8,10 +8,10 @@
     "name": "Stock Period Evaluation",
     "summary": "Stock evaluation with FIFO, LIFO and average methods",
     "version": "18.0.1.1.0",
-    "author": "Pordenone Linux User Group (PNLUG), Odoo Community Association (OCA),"
+    "author": "Pordenone Linux User Group (PNLUG), Odoo Community Association (OCA), "
     "Dinamiche Aziendali srl, Sergio Corato",
     "category": "Warehouse",
-    "website": "https://github.com/OCA/stock-logistics-workflow",
+    "website": "https://github.com/OCA/stock-logistics-reporting",
     "license": "AGPL-3",
     "maintainers": ["MarcoCalcagni", "Borruso"],
     "depends": [

stock_period_evaluation/__manifest__.py

@@ -1,9 +1,7 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo noupdate="1">
-
     <record id="last_close_date_config_parameter" model="ir.config_parameter">
         <field name="key">stock_period_evaluation.last_close_date</field>
         <field name="value">2010-01-01</field>
     </record>
-
 </odoo>

stock_period_evaluation/data/ir_config_parameter_data.xml

@@ -57,18 +57,10 @@ def _compute_quantities_available(self, to_date=False):
             quant_qty = row2[0] * 1.0
             product_id = row2[1]
             location_id = row2[2]
-            lot_id = (
-                row2[3] if self.tracking != "serial" and row2[3] is not None else False
-            )
-            package_id = row2[4] if row2[4] and row2[4] is not None else False
-            owner_id = row2[5] if row2[5] and row2[5] is not None else False
-            key = "%d_%d_%d_%d_%d" % (
-                product_id,
-                location_id,
-                lot_id,
-                package_id,
-                owner_id,
-            )
+            lot_id = row2[3] if self.tracking != "serial" and row2[3] is not None else 0
+            package_id = row2[4] if row2[4] and row2[4] is not None else 0
+            owner_id = row2[5] if row2[5] and row2[5] is not None else 0
+            key = f"{product_id}_{location_id}_{lot_id}_{package_id}_{owner_id}"
             if key in quan.keys():
                 quan[key] = quan[key] + quant_qty
             else:
@@ -121,18 +113,10 @@ def _compute_quantities_available(self, to_date=False):
             move_qty = row[0]
             product_id = row[1]
             location_id = row[2]
-            lot_id = (
-                row[3] if self.tracking != "serial" and row[3] is not None else False
-            )
-            package_id = row[4] if row[4] and row[4] is not None else False
-            owner_id = row[5] if row[5] and row[5] is not None else False
-            key = "%d_%d_%d_%d_%d" % (
-                product_id,
-                location_id,
-                lot_id,
-                package_id,
-                owner_id,
-            )
+            lot_id = row[3] if self.tracking != "serial" and row[3] is not None else 0
+            package_id = row[4] if row[4] and row[4] is not None else 0
+            owner_id = row[5] if row[5] and row[5] is not None else 0
+            key = f"{product_id}_{location_id}_{lot_id}_{package_id}_{owner_id}"
             if key in move.keys():
                 move[key] += move_qty
             else:
@@ -179,18 +163,10 @@ def _compute_quantities_available(self, to_date=False):
             move_qty = row[0]
             product_id = row[1]
             location_dest_id = row[2]
-            lot_id = (
-                row[3] if self.tracking != "serial" and row[3] is not None else False
-            )
-            package_id = row[4] if row[4] and row[4] is not None else False
-            owner_id = row[5] if row[5] and row[5] is not None else False
-            key = "%d_%d_%d_%d_%d" % (
-                product_id,
-                location_dest_id,
-                lot_id,
-                package_id,
-                owner_id,
-            )
+            lot_id = row[3] if self.tracking != "serial" and row[3] is not None else 0
+            package_id = row[4] if row[4] and row[4] is not None else 0
+            owner_id = row[5] if row[5] and row[5] is not None else 0
+            key = f"{product_id}_{location_dest_id}_{lot_id}_{package_id}_{owner_id}"
             if key in move.keys():
                 move[key] -= move_qty
             else:

stock_period_evaluation/models/product_product.py

@@ -5,7 +5,7 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
 import logging
-from datetime import datetime, time
+from datetime import datetime
 
 from odoo import _, api, fields, models
 from odoo.exceptions import UserError
@@ -77,10 +77,6 @@ class StockClosePeriod(models.Model):
         copy=False,
         readonly=False,
     )
-    force_archive = fields.Boolean(
-        default=False,
-        help="Marks as archive the inventory move lines used during the process.",
-    )
     purchase_ok = fields.Boolean(
         default=False,
         readonly=True,
@@ -99,11 +95,12 @@ def unlink(self):
             if closing.state in ["confirm", "done"]:
                 raise UserError(
                     _(
-                        "State in '%s'. You can only delete in state 'Draft' or 'Cancelled'."
+                        "State in '%s'. You can only delete in state "
+                        "'Draft' or 'Cancelled'."
                     )
                     % closing.state
                 )
-        return super(StockClosePeriod, self).unlink()
+        return super().unlink()
 
     def action_set_to_draft(self):
         for closing in self:
@@ -203,48 +200,6 @@ def _check_qty_available(self):
             res = True
         return res
 
-    def _deactivate_moves(self):
-        self.ensure_one()
-
-        # set active = False on stock_move and stock_move_line
-        close_date = self.close_date or datetime.combine(self.close_date, time.max)
-
-        self.env.cr.execute(
-            """
-            UPDATE
-                stock_move
-            SET
-                active = false
-            WHERE
-                date <= date(%s)
-                AND state = 'done'
-                AND (
-                    company_id == %s
-                    OR company_id IS NULL
-                );
-            """,
-            (close_date, self.company_id.id),
-        )
-
-        self.env.cr.execute(
-            """
-            UPDATE
-                stock_move_line
-            SET
-                active = false
-            WHERE
-                date <= date(%s)
-                AND state = 'done'
-                AND (
-                    company_id == %s
-                    OR company_id IS NULL
-                );
-            """,
-            (close_date, self.company_id.id),
-        )
-
-        return True
-
     def action_recalculate_purchase(self):
         for closing in self:
             if not closing.bypass_negative_qty and not closing._check_qty_available():
@@ -257,8 +212,6 @@ def action_recalculate_purchase(self):
 
             self.env["stock.move.line"].recompute_average_cost_period_purchase(closing)
             closing.purchase_ok = True
-            if closing.force_archive:
-                closing._deactivate_moves()
             closing.work_end = datetime.now()
         return True
 

stock_period_evaluation/models/stock_close.py

@@ -30,10 +30,9 @@ class StockClosePeriodLine(models.Model):
         required=True,
     )
     product_name = fields.Char(
-        string="Product Name",
         compute="_compute_product_name",
         store=True,
-        readonly=True
+        readonly=True,
     )
     product_code = fields.Char(
         related="product_id.default_code", store=True, readonly=True
@@ -98,7 +97,7 @@ class StockClosePeriodLine(models.Model):
         string="Company",
         store=True,
     )
-    evaluation_details = fields.Text(string="Evaluation Details")
+    evaluation_details = fields.Text()
 
     @api.depends("product_id")
     def _compute_product_name(self):
@@ -117,5 +116,5 @@ def _format_value(self, value):
             self.env,
             value,
             self.company_id.currency_id,
-            lang_code=self.company_id.partner_id.lang
+            lang_code=self.company_id.partner_id.lang,
         )

stock_period_evaluation/models/stock_close_line.py

@@ -16,9 +16,6 @@
 class StockMove(models.Model):
     _inherit = "stock.move"
 
-    # related field to manage closed lines
-    active = fields.Boolean()
-
     def _get_purchase_price_unit(self):
         self.ensure_one()
         invoice_lines = self.env["stock.move.line"]._get_right_invoice_lines(
@@ -61,8 +58,6 @@ def _get_purchase_price_unit(self):
 class StockMoveLine(models.Model):
     _inherit = "stock.move.line"
 
-    # add field to manage closed lines
-    active = fields.Boolean(related="move_id.active", store=True)
     company_id = fields.Many2one(related="move_id.company_id", store=True)
 
     def _get_last_closing(self, closing_id, product_id, company_id):
@@ -116,7 +111,6 @@ def _get_cost_stock_move_purchase_average(self, last_close_date, closing_line_id
                 ("product_id", "=", product_id.id),
                 ("date", ">", min_date),
                 ("date", "<=", max_date),
-                ("active", ">=", 0),
                 ("company_id", "=", company_id),
                 ("location_id.usage", "!=", "inventory"),
                 ("location_dest_id.usage", "!=", "inventory"),
@@ -215,7 +209,6 @@ def _search_same_product_value(self, closing_line_id):
         )
         closing_line_id.cumulative_qty = other_closing_line_id.cumulative_qty
         closing_line_id.evaluation_method = other_closing_line_id.evaluation_method
-        self.env.cr.commit()  # pylint: disable=E8102
 
     def _get_cost_stock_move_lifo_fifo(self, closing_line_id, evaluation_method=False):
         product_id = closing_line_id.product_id
@@ -306,7 +299,6 @@ def price_calculation(self, line, valuation_type, start_qty, start_price):
             ("quantity", ">", 0),
             ("date", "<=", line.close_id.close_date),
             ("date", ">", line.close_id.last_close_date),
-            ("active", "!=", False),
             ("company_id", "=", line.close_id.company_id.id),
         ]
         if valuation_type in ["fifo", "purchase"]:
@@ -421,7 +413,7 @@ def _get_tuples(self, line, move_line_ids, valuation_type, start_qty, start_pric
 
     def _fix_zero_values(self, tuples):
         fixed_tuples = []
-        _logger.info("Current tuples are %s" % str(tuples))
+        _logger.info(f"Current tuples are {tuples}")
         for i, raw_tuple in enumerate(tuples):
             if not raw_tuple[2]:
                 # n.b. the order of the tuples is from the newer to the oldest
@@ -448,7 +440,7 @@ def _fix_zero_values(self, tuples):
                 )
             else:
                 fixed_tuples.append(raw_tuple)
-        _logger.info("Fixed tuples are %s" % str(fixed_tuples))
+        _logger.info(f"Fixed tuples are {fixed_tuples}")
         return fixed_tuples
 
     @staticmethod
@@ -603,7 +595,6 @@ def _recompute_cost_stock_move_purchase(self, closing_id):
                 closing_id, closing_line_id, last_close_date, product_id
             )
 
-            self.env.cr.commit()  # pylint: disable=E8102
         _logger.info("[1/2] Finish recompute average cost product")
 
     def _write_results(self, closing_id):

stock_period_evaluation/models/stock_move.py

@@ -0,0 +1,3 @@
+[build-system]
+requires = ["whool"]
+build-backend = "whool.buildapi"

stock_period_evaluation/pyproject.toml

@@ -0,0 +1,39 @@
+**User Access Configuration**
+
+1.  **Security Groups**:
+
+    - **Stock Period Evaluation Manager**
+      (`stock_period_evaluation.group_stock_period_evaluation_manager`):
+      - Full access to create, edit, validate, and delete closing
+        periods
+      - Access to import wizard and all reporting functions
+      - Can force evaluation methods for cost calculation
+    - **Stock Period Evaluation User Read Only**
+      (`stock_period_evaluation.group_stock_period_evaluation_user_readonly`):
+      - View-only access to closing periods and reports
+      - Cannot modify or create new periods
+
+2.  **User Assignment**:
+
+    Go to *Settings \> Users & Companies \> Users*:
+
+    - Select the user to configure
+    - Assign appropriate Stock Period Evaluation group
+
+**System Parameters**
+
+The module uses a system parameter for default configuration:
+
+- **Default Last Close Date**: `stock_period_evaluation.last_close_date`
+  - Default value: 2010-01-01
+  - Can be modified via *Settings \> Technical \> System Parameters*
+  - Used when no previous closing period is selected
+
+**Performance Settings**
+
+Consider these optional configurations for large databases:
+
+- **Bypass Negative Quantities**: Enable to skip products with negative
+  stock during calculations
+- **No Recompute Lines**: Skip recalculation of quantities for existing
+  lines to improve performance