[MIG] stock_account_valuation_discrepancy_adjust: Migration to 18.0

IsabelAForgeFlow · IsabelAForgeFlow · commit e59f5d4090a5 · 2025-03-13T17:19:46.000+01:00
diff --git a/stock_account_valuation_discrepancy_adjust/__manifest__.py b/stock_account_valuation_discrepancy_adjust/__manifest__.py
@@ -3,7 +3,7 @@
 
 {
     "name": "Account Valuation Discrepancy Adjust",
-    "version": "16.0.1.0.0",
+    "version": "18.0.1.0.0",
     "summary": "Implements Wizard for Adjust "
     "Discrepancies on Account Inventory Valuation",
     "category": "Warehouse Management",
diff --git a/stock_account_valuation_discrepancy_adjust/models/product_product.py b/stock_account_valuation_discrepancy_adjust/models/product_product.py
@@ -19,7 +19,7 @@ def _adjustment_needed(self):
         qty_compare = float_compare(
             self.qty_at_date,
             self.account_qty_at_date,
-            precision_digits=self.uom_id.rounding,
+            precision_rounding=self.uom_id.rounding,
         )
         value_compare = float_compare(
             self.stock_value,
diff --git a/stock_account_valuation_discrepancy_adjust/tests/test_stock_account_valuation_discrepancy_adjust.py b/stock_account_valuation_discrepancy_adjust/tests/test_stock_account_valuation_discrepancy_adjust.py
@@ -80,7 +80,7 @@ def _create_account(self, acc_type, name, code, company):
                 "name": name,
                 "code": code,
                 "account_type": acc_type,
-                "company_id": company.id,
+                "company_ids": [(6, 0, [company.id])],
             }
         )
         return account
@@ -107,9 +107,10 @@ def _create_product(self, standard_price, template, list_price):
                 {
                     "name": "test_product",
                     "categ_id": self.product_ctg.id,
-                    "type": "product",
+                    "type": "consu",
                     "standard_price": standard_price,
                     "valuation": "real_time",
+                    "is_storable": True,
                 }
             )
             return template.product_variant_ids[0]
diff --git a/stock_account_valuation_discrepancy_adjust/wizards/wizard_stock_discrepancy_adjustment.py b/stock_account_valuation_discrepancy_adjust/wizards/wizard_stock_discrepancy_adjustment.py
@@ -110,7 +110,8 @@ def _prepare_counterpart_vals(self, product):
             product: The product.product record
 
         Returns:
-            list: A list containing the line values for the counterpart side of the entry
+            list: A list containing the line values
+            for the counterpart side of the entry
         """
         return [
             (
diff --git a/stock_account_valuation_discrepancy_adjust/wizards/wizard_stock_discrepancy_adjustment_view.xml b/stock_account_valuation_discrepancy_adjust/wizards/wizard_stock_discrepancy_adjustment_view.xml
@@ -34,7 +34,7 @@
     >
         <field name="name">Adjust Stock Valuation Account Discrepancies</field>
         <field name="res_model">wizard.stock.discrepancy.adjustment</field>
-        <field name="binding_view_types">tree,form</field>
+        <field name="binding_view_types">list,form</field>
         <field name="view_id" ref="wizard_stock_discrepancy_adjustment_view_form" />
         <field name="target">new</field>
         <field name="binding_model_id" ref="product.model_product_product" />
diff --git a/test-requirements.txt b/test-requirements.txt
@@ -0,0 +1,2 @@
+odoo_test_helper
+odoo-addon-stock_account_valuation_report @ git+https://github.com/OCA/stock-logistics-reporting.git@refs/pull/368/head#subdirectory=stock_account_valuation_report

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`
`4`	`4`	`{`
`5`	`5`	`"name": "Account Valuation Discrepancy Adjust",`
`6`		`- "version": "16.0.1.0.0",`
	`6`	`+ "version": "18.0.1.0.0",`
`7`	`7`	`"summary": "Implements Wizard for Adjust "`
`8`	`8`	`"Discrepancies on Account Inventory Valuation",`
`9`	`9`	`"category": "Warehouse Management",`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ def _adjustment_needed(self):`
`19`	`19`	`qty_compare = float_compare(`
`20`	`20`	`self.qty_at_date,`
`21`	`21`	`self.account_qty_at_date,`
`22`		`- precision_digits=self.uom_id.rounding,`
	`22`	`+ precision_rounding=self.uom_id.rounding,`
`23`	`23`	`)`
`24`	`24`	`value_compare = float_compare(`
`25`	`25`	`self.stock_value,`
Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ def _create_account(self, acc_type, name, code, company):`
`80`	`80`	`"name": name,`
`81`	`81`	`"code": code,`
`82`	`82`	`"account_type": acc_type,`
`83`		`- "company_id": company.id,`
	`83`	`+ "company_ids": [(6, 0, [company.id])],`
`84`	`84`	`}`
`85`	`85`	`)`
`86`	`86`	`return account`
`@@ -107,9 +107,10 @@ def _create_product(self, standard_price, template, list_price):`
`107`	`107`	`{`
`108`	`108`	`"name": "test_product",`
`109`	`109`	`"categ_id": self.product_ctg.id,`
`110`		`- "type": "product",`
	`110`	`+ "type": "consu",`
`111`	`111`	`"standard_price": standard_price,`
`112`	`112`	`"valuation": "real_time",`
	`113`	`+ "is_storable": True,`
`113`	`114`	`}`
`114`	`115`	`)`
`115`	`116`	`return template.product_variant_ids[0]`
Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,8 @@ def _prepare_counterpart_vals(self, product):`
`110`	`110`	`product: The product.product record`
`111`	`111`
`112`	`112`	`Returns:`
`113`		`- list: A list containing the line values for the counterpart side of the entry`
	`113`	`+ list: A list containing the line values`
	`114`	`+ for the counterpart side of the entry`
`114`	`115`	`"""`
`115`	`116`	`return [`
`116`	`117`	`(`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@`
`34`	`34`	`>`
`35`	`35`	`<field name="name">Adjust Stock Valuation Account Discrepancies</field>`
`36`	`36`	`<field name="res_model">wizard.stock.discrepancy.adjustment</field>`
`37`		`- <field name="binding_view_types">tree,form</field>`
	`37`	`+ <field name="binding_view_types">list,form</field>`
`38`	`38`	`<field name="view_id" ref="wizard_stock_discrepancy_adjustment_view_form" />`
`39`	`39`	`<field name="target">new</field>`
`40`	`40`	`<field name="binding_model_id" ref="product.model_product_product" />`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+odoo_test_helper`
	`2`	`+odoo-addon-stock_account_valuation_report @ git+https://github.com/OCA/stock-logistics-reporting.git@refs/pull/368/head#subdirectory=stock_account_valuation_report`