Reservoir coupling: Populate satellite data for summary output - #6979
Merged
Conversation
hakonhagland
added
the
manual:irrelevant
hakonhagland
marked this pull request as draft
April 10, 2026 07:26
Contributor
Author
|
Putting this in draft mode until #6978 has been merged |
hakonhagland
force-pushed
the
fix_summary2
branch
from
April 10, 2026 08:38
5935c6b to
006b34e
Compare
Add updateScheduleSatelliteData() to ReservoirCouplingMaster and ReservoirCouplingMasterReportStep. Called from EclWriter::evalSummaryState() before summary evaluation. This populates the Schedule's GSatProd and GroupSatelliteInjection with slave production/injection rates received via MPI. The existing satellite_rate machinery in opm-common's Summary.cpp then automatically computes all rate-based summary vectors (FOPR, GOPR, FGOR, FWCT, etc.) correctly for the master model. Requires the companion opm-common PR that adds Schedule::updateSatelliteProduction/Injection().
hakonhagland
force-pushed
the
fix_summary2
branch
from
April 10, 2026 08:40
006b34e to
b292f39
Compare
hakonhagland
marked this pull request as ready for review
April 10, 2026 08:40
Contributor
Author
|
Running jenkins build from OPM/opm-common#5101 |
Replace Schedule mutation with DynamicSimulatorState for passing reservoir coupling group rates to Summary::eval(). Add collectGroupRatesForSummary() on ReservoirCouplingMaster and ReservoirCouplingMasterReportStep, returning a ReservoirCouplingGroupRates struct. EclWriter populates this and passes it through evalSummary() to DynamicSimulatorState. Remove updateScheduleSatelliteData() which mutated the Schedule's GSatProd/GroupSatelliteInjection at runtime. Requires the companion opm-common commit that adds ReservoirCouplingGroupRates to DynamicSimulatorState and modifies satellite_rate() in Summary.cpp to use it.
Contributor
Author
|
jenkins build this serial please |
1 similar comment
Member
|
jenkins build this serial please |
bska
approved these changes
Apr 14, 2026
bska
left a comment
bska
left a comment
Member
There was a problem hiding this comment.
Thanks a lot. This looks good to me and I'll merge into master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
collectGroupRatesForSummary()toReservoirCouplingMasterReportStepandReservoirCouplingMaster, collecting slave production/injection rates into aReservoirCouplingGroupRatesstructDynamicSimulatorStatetoSummary::eval()via an optionalrcGroupRatesparameter onevalSummary()EclWriter::evalSummaryState()before summary evaluation so that all rate-based summary vectors (FOPR, GOPR, FGOR, FWCT, etc.) are computed correctly for the master processBackground
In reservoir coupling, the master model has no wells, all production and injection happens in the slave models. Previously, all rate-based summary vectors (FOPR, GOPR, etc.) were zero in the master's summary output because opm-common's
Summary.cppcomputes them by summing well rates, and the master has no wells.The companion opm-common PR adds a
ReservoirCouplingGroupRatesstruct toDynamicSimulatorStateand extends thesatellite_ratefunction inSummary.cppto check for RC group rates alongside the existing GSatProd/GSATINJE sources. Theaccum_groupstree-walking logic accumulates the rates through the group hierarchy for both group-level (GOPR) and field-level (FOPR) vectors.This PR populates the
ReservoirCouplingGroupRatesstruct from the slave data received via MPI and passes it through theevalSummary()call chain.