Fix delete IoT device metadata

Author: AramAlsabti

src/app/applications/iot-devices/iot-device-edit/iot-device-edit.component.ts

@@ -184,7 +184,9 @@ export class IotDeviceEditComponent implements OnInit, OnDestroy {
     onSubmit(): void {
         this.adjustModelBasedOnType();
 
-        if (this.isMetadataSet()) {
+        if (this.metadataTags.length === 0) {
+          this.iotDevice.metadata = JSON.stringify({});
+        } else if (this.isMetadataSet()) {
           const invalidKey = this.validateMetadata();
 
           if (!invalidKey) {

src/app/shared/components/forms/form-key-value/form-key-value-list/form-key-value-list.component.ts

@@ -1,4 +1,4 @@
-import { Component, Input, OnInit } from '@angular/core';
+import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core';
 import { KeyValue } from '@shared/types/tuple.type';
 
 @Component({
@@ -8,6 +8,7 @@ import { KeyValue } from '@shared/types/tuple.type';
 })
 export class FormKeyValueListComponent implements OnInit {
   @Input() tags: KeyValue[] = [{}];
+  @Output() tagsChange = new EventEmitter<KeyValue[]>();
   @Input() errorFieldId: string | undefined;
 
   constructor() {}
@@ -19,6 +20,8 @@ export class FormKeyValueListComponent implements OnInit {
   }
 
   deleteTag(id: number): void {
-    this.tags = this.tags.filter((_tag, i) => i !== id);
+    const newTags = this.tags.filter((_tag, i) => i !== id);
+    // Update parent with a tag less and banana-in-a-box binding (in html) for the update to propagate 2-way
+    this.tagsChange.emit(newTags);
   }
 }